Page MenuHomePhabricator

terrelln (Nick Terrell)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2016, 4:53 PM (372 w, 3 d)

Recent Activity

Nov 11 2019

terrelln updated the diff for D69295: Optimize SHA1 implementation.

Remove the benchmark

Nov 11 2019, 6:36 PM · Restricted Project
terrelln added a comment to D69295: Optimize SHA1 implementation.

@terrelln No one has responded to http://lists.llvm.org/pipermail/llvm-dev/2019-October/136337.html yet. I think we can just commit the code change for now. Do you need help for committing the patch?

Nov 11 2019, 6:36 PM · Restricted Project

Oct 28 2019

terrelln updated the diff for D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.

Use triple x86_64 in tests.

Oct 28 2019, 9:50 PM · lld, Restricted Project
terrelln retitled D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap from [LLD][ELF] Support -[no-]mmap-output-file with F_no_mmap to [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.
Oct 28 2019, 9:47 PM · lld, Restricted Project

Oct 25 2019

terrelln added a comment to D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.

@smeenai yeah I will

Oct 25 2019, 11:30 AM · lld, Restricted Project
terrelln updated the diff for D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.

Fix comments

Oct 25 2019, 11:11 AM · lld, Restricted Project

Oct 24 2019

terrelln updated the summary of D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.
Oct 24 2019, 6:09 PM · lld, Restricted Project
terrelln abandoned D69293: [Support] Add in memory flag for FileOutputBuffer.

Merged into D69294

Oct 24 2019, 6:08 PM · Restricted Project
terrelln updated the diff for D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.
  • Merge D69293 into this diff.
  • Fix all comments.
Oct 24 2019, 6:08 PM · lld, Restricted Project
terrelln retitled D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap from [LLD][ELF] Support -[no-]mmap-output-file to [LLD][ELF] Support -[no-]mmap-output-file with F_no_mmap.
Oct 24 2019, 6:08 PM · lld, Restricted Project
terrelln added inline comments to D69295: Optimize SHA1 implementation.
Oct 24 2019, 6:08 PM · Restricted Project
terrelln added a comment to D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.

Can you try posix_fallocate(fd, 0, len) and see how it performs under memory pressure with btrfs+compression?

Oct 24 2019, 5:34 PM · lld, Restricted Project

Oct 23 2019

terrelln added a comment to D69295: Optimize SHA1 implementation.

I also agree with this. I think llvm/benchmarks would be fine for now either way, but with more benchmarks (which hopefully would be there at some point, I had plans of adding some for a while now but I'm not sure when I'll get to that) subdirectories make sense.

Oct 23 2019, 11:18 AM · Restricted Project

Oct 22 2019

terrelln added a comment to D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.

I'll update the description to answer questions, and make the requested changes. I've also answered questions inline below.

Oct 22 2019, 1:26 PM · lld, Restricted Project
terrelln added a comment to D69293: [Support] Add in memory flag for FileOutputBuffer.

Maybe this should be merged with https://reviews.llvm.org/D69294. Since we are moving to a single repository that contains both llvm and lld, we no longer have to split a commit at svn repo boundaries. Since this flag will be used only by lld at least for a while, it feels more natural to commit this and the other one as a single commit.

Oct 22 2019, 1:07 PM · Restricted Project
terrelln added a comment to D69295: Optimize SHA1 implementation.

If you really want to make this fast, I think Intel processors have special-purpose instructions to accelerate SHA1 computation. Have you consider using them?

Oct 22 2019, 1:07 PM · Restricted Project

Oct 21 2019

terrelln updated the summary of D69295: Optimize SHA1 implementation.
Oct 21 2019, 8:50 PM · Restricted Project
terrelln updated the summary of D69295: Optimize SHA1 implementation.
Oct 21 2019, 8:50 PM · Restricted Project
terrelln created D69295: Optimize SHA1 implementation.
Oct 21 2019, 8:50 PM · Restricted Project
terrelln updated the summary of D69295: Optimize SHA1 implementation.
Oct 21 2019, 8:50 PM · Restricted Project
terrelln created D69294: [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap.
Oct 21 2019, 8:50 PM · lld, Restricted Project
terrelln edited reviewers for D69293: [Support] Add in memory flag for FileOutputBuffer, added: ruiu; removed: rui314.
Oct 21 2019, 8:41 PM · Restricted Project
terrelln created D69293: [Support] Add in memory flag for FileOutputBuffer.
Oct 21 2019, 8:41 PM · Restricted Project

Feb 29 2016

terrelln added a reviewer for D17702: Fix unqualified type in AST_TYPE_MATCHER: klimek.
Feb 29 2016, 3:00 PM

Feb 28 2016

terrelln retitled D17702: Fix unqualified type in AST_TYPE_MATCHER from to Fix unqualified type in AST_TYPE_MATCHER.
Feb 28 2016, 9:17 PM

Feb 1 2016

terrelln abandoned D16701: [Sema] Fix conditional expression bug.
Feb 1 2016, 9:18 AM

Jan 28 2016

terrelln updated D16701: [Sema] Fix conditional expression bug.
Jan 28 2016, 7:34 PM
terrelln added a reviewer for D16701: [Sema] Fix conditional expression bug: rsmith.
Jan 28 2016, 5:36 PM
terrelln retitled D16701: [Sema] Fix conditional expression bug from to [Sema] Fix conditional expression bug.
Jan 28 2016, 5:26 PM