This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
clang/lib/Headers/
-
lib/
-
Headers/
-
__clang_cuda_math.h

Differential D95299

Fix truncated __OPENMP_NVPTX__ preprocessor condition
ClosedPublic

Authored by r-burns on Jan 23 2021, 3:03 PM.

Download Raw Diff

Details

Reviewers

tra
ABataev

Commits

rGc49142e4f5c8: Fix truncated __OPENMP_NVPTX__ preprocessor condition

Summary

I don't have a test case for this but noticed this warning when including system headers with -I rather than -isystem.

In file included from <built-in>:1:
In file included from /nix/store/jq6bpm0xmhnbffhs5rkxq4n88g5xi2zg-clang-wrapper-11.0.1/resource-root/include/__clang_cuda_runtime_wrapper.h:157:
/nix/store/jq6bpm0xmhnbffhs5rkxq4n88g5xi2zg-clang-wrapper-11.0.1/resource-root/include/__clang_cuda_math.h:39:25: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
#ifdef __OPENMP_NVPTX__ && defined(__cplusplus) && __cplusplus < 201402L
                        ^

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	2,029 ms	x64 debian > libarcher.races::lock-unrelated.c

Event Timeline

r-burns created this revision.Jan 23 2021, 3:03 PM

Herald added subscribers: guansong, yaxunl. · View Herald TranscriptJan 23 2021, 3:03 PM

r-burns requested review of this revision.Jan 23 2021, 3:03 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2021, 3:03 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B86432: Diff 318793.Jan 23 2021, 3:47 PM

LGTM

This revision is now accepted and ready to land.Jan 25 2021, 10:40 AM

capn added a subscriber: jdoerfert.Jun 23 2023, 9:12 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2023, 9:12 AM

Herald added subscribers: sunshaoce, mattd, gchakrabarti, asavonic. · View Herald Transcript

Can a committer go ahead and land this please? I'm running into this warning for any CUDA code compiled by Clang.

@r-burns : what should I use for the authorship (name/pseudo and email)?

Herald added a subscriber: wangpc. · View Herald TranscriptJul 24 2023, 1:06 PM

Hi! You can credit Ryan Burns <rtburns@protonmail.com>.

This revision was landed with ongoing or failed builds.Aug 15 2023, 2:12 PM

Closed by commit rGc49142e4f5c8: Fix truncated __OPENMP_NVPTX__ preprocessor condition (authored by r-burns, committed by mehdi_amini). · Explain Why

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rGc49142e4f5c8: Fix truncated __OPENMP_NVPTX__ preprocessor condition.

Revision Contents

Path

Size

clang/

lib/

Headers/

__clang_cuda_math.h

2 lines

Diff 318793

clang/lib/Headers/__clang_cuda_math.h

Context not available.
	// because the OpenMP overlay requires constexpr functions here but prior to	// because the OpenMP overlay requires constexpr functions here but prior to
	// c++14 void return functions could not be constexpr.	// c++14 void return functions could not be constexpr.
	#pragma push_macro("__DEVICE_VOID__")	#pragma push_macro("__DEVICE_VOID__")
	#ifdef __OPENMP_NVPTX__ && defined(__cplusplus) && __cplusplus < 201402L	#if defined(__OPENMP_NVPTX__) && defined(__cplusplus) && __cplusplus < 201402L
	#define __DEVICE_VOID__ static __attribute__((always_inline, nothrow))	#define __DEVICE_VOID__ static __attribute__((always_inline, nothrow))
	#else	#else
	#define __DEVICE_VOID__ __DEVICE__	#define __DEVICE_VOID__ __DEVICE__
Context not available.
		Lint: Pre-merge checks Inline Actions clang-tidy: error: unknown type name 'device' [clang-diagnostic-error] not useful clang-tidy: error: expected ';' after top level declarator [clang-diagnostic-error] not useful clang-tidy: error: use of undeclared identifier '__nv_abs' [clang-diagnostic-error] not useful Lint: Pre-merge checks: clang-tidy: error: unknown type name '__device__' [clang-diagnostic-error] [[https://github.
		Lint: Pre-merge checks Inline Actions clang-tidy: error: unknown type name 'device' [clang-diagnostic-error] not useful clang-tidy: error: expected ';' after top level declarator [clang-diagnostic-error] not useful clang-tidy: error: use of undeclared identifier '__nv_fabs' [clang-diagnostic-error] not useful Lint: Pre-merge checks: clang-tidy: error: unknown type name '__device__' [clang-diagnostic-error] [[https://github.
		Lint: Pre-merge checks Inline Actions clang-tidy: error: unknown type name 'device' [clang-diagnostic-error] not useful clang-tidy: error: expected ';' after top level declarator [clang-diagnostic-error] not useful clang-tidy: error: use of undeclared identifier '__nv_acos' [clang-diagnostic-error] not useful Lint: Pre-merge checks: clang-tidy: error: unknown type name '__device__' [clang-diagnostic-error] [[https://github.
		Lint: Pre-merge checks Inline Actions clang-tidy: error: unknown type name 'device' [clang-diagnostic-error] not useful clang-tidy: error: expected ';' after top level declarator [clang-diagnostic-error] not useful clang-tidy: error: use of undeclared identifier '__nv_acosf' [clang-diagnostic-error] not useful Lint: Pre-merge checks: clang-tidy: error: unknown type name '__device__' [clang-diagnostic-error] [[https://github.
		Lint: Pre-merge checks Inline Actions clang-tidy: error: unknown type name 'device' [clang-diagnostic-error] not useful clang-tidy: error: expected ';' after top level declarator [clang-diagnostic-error] not useful clang-tidy: error: use of undeclared identifier '__nv_acosh' [clang-diagnostic-error] not useful Lint: Pre-merge checks: clang-tidy: error: unknown type name '__device__' [clang-diagnostic-error] [[https://github.
		Lint: Pre-merge checks Inline Actions clang-tidy: error: unknown type name 'device' [clang-diagnostic-error] not useful clang-tidy: error: expected ';' after top level declarator [clang-diagnostic-error] not useful Lint: Pre-merge checks: clang-tidy: error: unknown type name '__device__' [clang-diagnostic-error] [[https://github.