Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs
ClosedPublic
Actions

Authored by rriddle on Jan 6 2021, 1:21 PM.

Details

Reviewers

jpienaar
mehdi_amini
antiagainst

Commits

rGc42cee0c64fe: [mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs

Summary

This field is currently being used to mean "Fully resolved class name", which breaks the usage by TypeDefs. This revision prefixes the name with the dialect namespace when necessary.

Depends On D94133

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rriddle created this revision.Jan 6 2021, 1:21 PM

Herald added a reviewer: antiagainst. · View Herald TranscriptJan 6 2021, 1:21 PM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 13 others. · View Herald Transcript

rriddle requested review of this revision.Jan 6 2021, 1:21 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2021, 1:21 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

jpienaar accepted this revision.Jan 6 2021, 1:27 PM

This revision is now accepted and ready to land.Jan 6 2021, 1:27 PM

Harbormaster completed remote builds in B84247: Diff 314971.Jan 6 2021, 1:39 PM

rriddle added a child revision: D94194: [mlir][TypeDefGen] Remove the need to define parser/printer for singleton types.Jan 6 2021, 1:49 PM

Closed by commit rGc42cee0c64fe: [mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs (authored by rriddle). · Explain WhyJan 6 2021, 2:22 PM

This revision was automatically updated to reflect the committed changes.

rriddle added a commit: rGc42cee0c64fe: [mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

IR/

OpBase.td

3 lines

TableGen/

Type.h

2 lines

lib/

TableGen/

Type.cpp

17 lines

test/

mlir-tblgen/

op-decl.td

17 lines

Diff 314986

View Options

mlir/include/mlir/IR/OpBase.td

View Options

mlir/include/mlir/TableGen/Type.h

View Options

mlir/lib/TableGen/Type.cpp

View Options

mlir/test/mlir-tblgen/op-decl.td

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 314986

mlir/include/mlir/IR/OpBase.td

mlir/include/mlir/TableGen/Type.h

mlir/lib/TableGen/Type.cpp

mlir/test/mlir-tblgen/op-decl.td

[mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs
ClosedPublic
Actions

Revision Contents
Changeset List