This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add intrinsic testcase for some missing widening reduction.
ClosedPublic

Authored by monkchiang on Dec 28 2020, 10:16 PM.

Details

Summary

Some testcase missing in D93807.

Add more vfredosum/vfredsum/vredsum/vredsumu testcase.

Diff Detail

Event Timeline

monkchiang created this revision.Dec 28 2020, 10:16 PM
monkchiang requested review of this revision.Dec 28 2020, 10:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2020, 10:16 PM

We don't have any tests for integer widening reductions fwredsum(u) that was also added by D93807.

llvm/test/CodeGen/RISCV/rvv/vfwredosum-rv32.ll
1

We're still missing float->double tests for rv32.

Add missing float->double tests for rv32.

Add missing float->double tests for rv32.

Are you also going to add the integer tests to this patch or will that be another patch?

This comment was removed by monkchiang.
llvm/test/CodeGen/RISCV/rvv/vfwredosum-rv32.ll
1

The D set is needed, SEW up to ELEN = max(XLEN,FLEN) are required to be supported

Add missing float->double tests for rv32.

Are you also going to add the integer tests to this patch or will that be another patch?

Yes, thank you for your reminder.
I forgot the integer part. I will add it.

monkchiang edited the summary of this revision. (Show Details)Dec 29 2020, 7:35 PM

Add vredsum and vredsumu test cases

craig.topper added inline comments.Dec 29 2020, 8:37 PM
llvm/test/CodeGen/RISCV/rvv/vfwredosum-rv32.ll
23

Why does this say nxv32i1? There's no argument with that type. And the mask type is inferred anyway so doesn't need to be listed.

address @craig.topper 's comments

This revision is now accepted and ready to land.Dec 29 2020, 10:57 PM
This revision was landed with ongoing or failed builds.Dec 30 2020, 7:15 PM
This revision was automatically updated to reflect the committed changes.