Page MenuHomePhabricator

[mlir] Remove LLVMType, LLVM dialect types now derive Type directly
ClosedPublic

Authored by ftynse on Dec 22 2020, 9:15 AM.

Details

Summary

BEGIN_PUBLIC
[mlir] Remove LLVMType, LLVM dialect types now derive Type directly

This class has become a simple isa hook with no proper functionality.
Removing will allow us to eventually make the LLVM dialect type infrastructure
open, i.e., support non-LLVM types inside container types, which itself will
make the type conversion more progressive.

Introduce a call LLVM::isCompatibleType to be used instead of
isa<LLVMType>. For now, this is strictly equivalent.
END_PUBLIC

Depends On D93681

Diff Detail

Event Timeline

ftynse created this revision.Dec 22 2020, 9:15 AM
ftynse requested review of this revision.Dec 22 2020, 9:15 AM
Herald added a project: Restricted Project. · View Herald Transcript
mehdi_amini accepted this revision.Dec 22 2020, 9:50 AM
mehdi_amini added inline comments.
mlir/docs/Tutorials/Toy/Ch-6.md
39–40

It isn't clear

40–44

I don't think this is correct, shouldn't it be something like: LLVM::LLVMIntegerType::get(context, 32);?
(also I think it belongs to the parent revision)

This revision is now accepted and ready to land.Dec 22 2020, 9:50 AM
ftynse updated this revision to Diff 314603.Jan 5 2021, 7:23 AM

Address review

ftynse updated this revision to Diff 314617.Jan 5 2021, 8:01 AM

Address review

This revision was landed with ongoing or failed builds.Jan 5 2021, 8:37 AM
This revision was automatically updated to reflect the committed changes.