This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] NFC: Shuffle code around to better follow convention
ClosedPublic

Authored by antiagainst on Dec 16 2020, 10:11 AM.

Details

Summary

This commit shuffles SPIR-V code around to better follow MLIR
convention. Specifically,

  • Created IR/, Transforms/, Linking/, and Utils/ subdirectories and moved suitable code inside.
  • Created SPIRVEnums.{h|cpp} for SPIR-V C/C++ enums generated from SPIR-V spec. Previously they are cluttered inside SPIRVTypes.{h|cpp}.
  • Fixed include guards in various header files (both .h and .td).
  • Moved serialization tests under test/Target/SPIRV.
  • Renamed TableGen backend -gen-spirv-op-utils into -gen-spirv-attr-utils as it is only generating utility functions for attributes.

Diff Detail

Event Timeline

antiagainst created this revision.Dec 16 2020, 10:11 AM
antiagainst requested review of this revision.Dec 16 2020, 10:11 AM
mravishankar accepted this revision.Dec 16 2020, 11:11 AM

Thanks for doing this!

This revision is now accepted and ready to land.Dec 16 2020, 11:11 AM
This revision was landed with ongoing or failed builds.Dec 17 2020, 8:03 AM
This revision was automatically updated to reflect the committed changes.
mlir/test/Target/SPIRV/selection.mlir