Page MenuHomePhabricator

[mlir][OpFormat] Add support for emitting newlines from the custom format of an operation
ClosedPublic

Authored by rriddle on Dec 11 2020, 5:45 PM.

Details

Summary

This revision adds a new printNewline hook to OpAsmPrinter that allows for printing a newline within the custom format of an operation, that is then indented to the start of the operation. Support for the declarative assembly format is also added, in the form of a \n literal.

Diff Detail

Event Timeline

rriddle created this revision.Dec 11 2020, 5:45 PM
rriddle requested review of this revision.Dec 11 2020, 5:45 PM

That will be really neat for a few ops out thread :)

mehdi_amini accepted this revision.Dec 14 2020, 11:28 AM

That will be really neat for a few ops out thread :)

I meant to LGTM

This revision is now accepted and ready to land.Dec 14 2020, 11:28 AM
This revision was landed with ongoing or failed builds.Dec 14 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.