Page MenuHomePhabricator

[mlir] Remove the dependency on StandardOps from FoldUtils
ClosedPublic

Authored by rriddle on Dec 9 2020, 4:04 PM.

Details

Summary

OperationFolder currently uses ConstantOp as a backup when trying to materialize a constant after an operation is folded. This dependency isn't really useful or necessary given that dialects can/should provide a materializeConstant implementation.

Fixes PR#44866

Diff Detail

Event Timeline

rriddle created this revision.Dec 9 2020, 4:04 PM
rriddle requested review of this revision.Dec 9 2020, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2020, 4:04 PM
silvas accepted this revision.Dec 9 2020, 4:05 PM
This revision is now accepted and ready to land.Dec 9 2020, 4:05 PM
jpienaar accepted this revision.Dec 9 2020, 4:19 PM
jpienaar added a subscriber: jpienaar.

Nice

This revision was landed with ongoing or failed builds.Dec 10 2020, 2:17 PM
This revision was automatically updated to reflect the committed changes.