Page MenuHomePhabricator

[analyzer] Highlight arrows for currently selected event
Needs ReviewPublic

Authored by vsavchenko on Dec 9 2020, 3:17 AM.

Details

Summary

In some cases, when the execution path of the diagnostic
goes back and forth, arrows can overlap and create a mess.
Dimming arrows that are not relevant at the moment, solves this issue.
They are still visible, but don't draw too much attention.

Diff Detail

Event Timeline

vsavchenko created this revision.Dec 9 2020, 3:17 AM
vsavchenko requested review of this revision.Dec 9 2020, 3:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2020, 3:17 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Here is the HTML file for the test.

HTML sample looks fine! But there is the same problem as in D92639. IE doesn't draw arrows.

clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
162
  1. Whether size() is not an aim?
  2. It can fail in case of empty container.
vsavchenko added inline comments.Feb 5 2021, 1:37 AM
clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
162

size() doesn't mean the same semantically. This structure is at least of size 1. Please, consider the following code on how this data structure is constructed and used.