Page MenuHomePhabricator

nullptr.cpp (Yang Fan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2019, 7:08 PM (91 w, 1 d)

Recent Activity

Thu, Apr 8

nullptr.cpp committed rGca55f0511698: [clang][SourceManager] Fix -Wparentheses warning (NFC) (authored by nullptr.cpp).
[clang][SourceManager] Fix -Wparentheses warning (NFC)
Thu, Apr 8, 7:24 PM

Wed, Apr 7

nullptr.cpp added a comment to D97361: [clang-tidy] Add readability-redundant-using check.

Ping.

Wed, Apr 7, 3:34 AM · Restricted Project, Restricted Project
nullptr.cpp added reviewers for D97361: [clang-tidy] Add readability-redundant-using check: ymandel, steveire.
Wed, Apr 7, 3:34 AM · Restricted Project, Restricted Project

Thu, Apr 1

nullptr.cpp committed rGd441dee5c266: [lld][MachO] Fix -Wsign-compare warning (NFC) (authored by nullptr.cpp).
[lld][MachO] Fix -Wsign-compare warning (NFC)
Thu, Apr 1, 8:34 PM
nullptr.cpp committed rG062d4ddd22c2: [lld] Add missing header guard (NFC) (authored by nullptr.cpp).
[lld] Add missing header guard (NFC)
Thu, Apr 1, 8:13 PM
nullptr.cpp committed rGbc6001ce1e91: [X86] Fix -Wunused-function warning (NFC) (authored by nullptr.cpp).
[X86] Fix -Wunused-function warning (NFC)
Thu, Apr 1, 6:39 PM

Wed, Mar 31

nullptr.cpp committed rGa8219991d024: [clang][APINotes] Fix -Wunused-function warning (NFC) (authored by nullptr.cpp).
[clang][APINotes] Fix -Wunused-function warning (NFC)
Wed, Mar 31, 6:53 PM

Tue, Mar 30

nullptr.cpp committed rG0d7fd9f0d098: [GlobalISel] Fix Wint-in-bool-context warning (NFC) (authored by nullptr.cpp).
[GlobalISel] Fix Wint-in-bool-context warning (NFC)
Tue, Mar 30, 7:00 PM

Mon, Mar 29

nullptr.cpp added a comment to D97361: [clang-tidy] Add readability-redundant-using check.
  • Restrict to only run on C++ code
  • Ignore using defined in macro
  • Support inline namespace
  • Support global namespace
Mon, Mar 29, 2:26 AM · Restricted Project, Restricted Project

Tue, Mar 23

nullptr.cpp committed rG279d74ffd198: [InstSimplify] Fix unused variable warning (NFC) (authored by nullptr.cpp).
[InstSimplify] Fix unused variable warning (NFC)
Tue, Mar 23, 6:57 PM

Mon, Mar 22

nullptr.cpp updated the diff for D99139: [lld][ELF] --warn-backrefs: Fix symbol name demangling.

Use the existing test

Mon, Mar 22, 11:06 PM · Restricted Project
nullptr.cpp requested review of D99139: [lld][ELF] --warn-backrefs: Fix symbol name demangling.
Mon, Mar 22, 8:37 PM · Restricted Project
nullptr.cpp committed rG0db28c0f3b9f: [ELF][docs] Add line breaks (authored by nullptr.cpp).
[ELF][docs] Add line breaks
Mon, Mar 22, 1:09 AM

Sat, Mar 20

nullptr.cpp updated the diff for D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator.
  • Warn on both declarations and definitions
  • Add check for parameter passing
  • Add options CheckParamPassing and ExpensiveToCopySize
Sat, Mar 20, 9:35 PM · Restricted Project

Wed, Mar 17

nullptr.cpp added a comment to D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator.

While we're here, I'm not sure if there is a cppcoreguideline for it, but parameters to comparison functions should be passed by const ref usually, or by value if they are cheap to copy. Maybe there's precedent to extend this to flag parameters that take non const reference, R value reference or by value if not cheap to copy(There's bound to be a function somewhere in clang tidy that determines if a type is a cheap copy)

Wed, Mar 17, 5:08 AM · Restricted Project
nullptr.cpp updated the diff for D97361: [clang-tidy] Add readability-redundant-using check.

Rebase

Wed, Mar 17, 2:23 AM · Restricted Project, Restricted Project
nullptr.cpp updated the diff for D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator.

Update

Wed, Mar 17, 1:48 AM · Restricted Project
nullptr.cpp updated the diff for D97361: [clang-tidy] Add readability-redundant-using check.

Update

Wed, Mar 17, 1:43 AM · Restricted Project, Restricted Project
nullptr.cpp updated the diff for D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator.

Modify according to suggestions

Wed, Mar 17, 12:10 AM · Restricted Project

Tue, Mar 16

Herald added a project to D97361: [clang-tidy] Add readability-redundant-using check: Restricted Project.

Ping

Tue, Mar 16, 5:48 AM · Restricted Project, Restricted Project
nullptr.cpp requested review of D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator.
Tue, Mar 16, 3:45 AM · Restricted Project

Mar 9 2021

nullptr.cpp committed rG3f7f7f161540: [clang][APINotes] Fix gcc Wunused-function warning (NFC) (authored by nullptr.cpp).
[clang][APINotes] Fix gcc Wunused-function warning (NFC)
Mar 9 2021, 7:47 PM
nullptr.cpp committed rGea548a4e4138: [MC][ELF] Fix "enumeral and non-enumeral type in conditional expression"… (authored by nullptr.cpp).
[MC][ELF] Fix "enumeral and non-enumeral type in conditional expression"…
Mar 9 2021, 7:27 PM

Mar 6 2021

nullptr.cpp updated the summary of D97361: [clang-tidy] Add readability-redundant-using check.
Mar 6 2021, 11:27 PM · Restricted Project, Restricted Project
nullptr.cpp updated the diff for D97361: [clang-tidy] Add readability-redundant-using check.
  • Restrict to only run on C++ code
  • Ignore using defined in macro
  • Support inline namespace
  • Support global namespace
Mar 6 2021, 11:20 PM · Restricted Project, Restricted Project

Mar 4 2021

nullptr.cpp added inline comments to rG818772a59403: [Orc] Fix remaining memory size of slab allocator.
Mar 4 2021, 11:37 PM
nullptr.cpp committed rGdbba2f7c41a8: [JITLink] Fix Wtype-limits gcc warning (NFC) (authored by nullptr.cpp).
[JITLink] Fix Wtype-limits gcc warning (NFC)
Mar 4 2021, 11:28 PM
nullptr.cpp committed rG889da9952393: [clang][AST] Fix Wreturn-type gcc warning (NFC) (authored by nullptr.cpp).
[clang][AST] Fix Wreturn-type gcc warning (NFC)
Mar 4 2021, 7:26 PM

Feb 26 2021

nullptr.cpp committed rGe9475a276267: [Sema] Fix MSVC "attribute is not recognized" warning (NFC) (authored by nullptr.cpp).
[Sema] Fix MSVC "attribute is not recognized" warning (NFC)
Feb 26 2021, 1:29 AM
nullptr.cpp committed rGd5e0868e5e32: [Basic] Fix Wreturn-type gcc warning (NFC) (authored by nullptr.cpp).
[Basic] Fix Wreturn-type gcc warning (NFC)
Feb 26 2021, 1:15 AM

Feb 25 2021

nullptr.cpp updated the diff for D97361: [clang-tidy] Add readability-redundant-using check.

Modify according to suggestions

Feb 25 2021, 1:14 AM · Restricted Project, Restricted Project

Feb 24 2021

nullptr.cpp committed rGb950de5c13ef: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11 (authored by nullptr.cpp).
[docs] Add a release note for the removing of -Wreturn-std-move-in-c++11
Feb 24 2021, 6:17 PM
nullptr.cpp closed D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11.
Feb 24 2021, 6:17 PM · Restricted Project
nullptr.cpp added a comment to D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11.

I assume you need someone to land this for you?

Feb 24 2021, 6:16 PM · Restricted Project
nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

We usually rely on the release notes to say something, but we didn't do that here.

Perhaps @nullptr.cpp could add something there? The file is clang/docs/ReleaseNotes.rst.

Add by D97364.

Feb 24 2021, 1:09 AM · Restricted Project
nullptr.cpp added reviewers for D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11: aaronpuchert, aaron.ballman, amccarth.
Feb 24 2021, 1:08 AM · Restricted Project
nullptr.cpp requested review of D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11.
Feb 24 2021, 1:05 AM · Restricted Project

Feb 23 2021

nullptr.cpp requested review of D97361: [clang-tidy] Add readability-redundant-using check.
Feb 23 2021, 11:28 PM · Restricted Project, Restricted Project

Feb 18 2021

nullptr.cpp committed rG64fc9cc72319: [CSSPGO][llvm-profgen] Fix gcc Wcast-qual warning (NFC) (authored by nullptr.cpp).
[CSSPGO][llvm-profgen] Fix gcc Wcast-qual warning (NFC)
Feb 18 2021, 1:12 AM

Feb 17 2021

nullptr.cpp committed rG3ae27fca7ea5: [MC][ELF] Fix gcc "enumeral and non-enumeral type in conditional expression"… (authored by nullptr.cpp).
[MC][ELF] Fix gcc "enumeral and non-enumeral type in conditional expression"…
Feb 17 2021, 10:59 PM
nullptr.cpp committed rG796feb61637c: [MC][ELF] Fix unused variable warning (NFC) (authored by nullptr.cpp).
[MC][ELF] Fix unused variable warning (NFC)
Feb 17 2021, 10:24 PM

Feb 16 2021

nullptr.cpp committed rGa23e6b321ca6: [SampleFDO] Fix MSVC "namespace uses itself" warning (NFC) (authored by nullptr.cpp).
[SampleFDO] Fix MSVC "namespace uses itself" warning (NFC)
Feb 16 2021, 11:28 PM
nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

Ping

Feb 16 2021, 5:46 AM · Restricted Project

Feb 10 2021

nullptr.cpp committed rG984cfdc6ee8b: [clang][cli] Fix gcc warning (NFC) (authored by nullptr.cpp).
[clang][cli] Fix gcc warning (NFC)
Feb 10 2021, 8:38 PM
nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

Ping

Feb 10 2021, 3:17 AM · Restricted Project

Feb 9 2021

nullptr.cpp committed rG66ac53fe319b: [clang][cli] Fix gcc "enumeral and non-enumeral type in conditional expression"… (authored by nullptr.cpp).
[clang][cli] Fix gcc "enumeral and non-enumeral type in conditional expression"…
Feb 9 2021, 7:18 PM

Feb 2 2021

nullptr.cpp committed rGc90c261e44e7: [CSSPGO] Fix MSVC initializing truncation warning (NFC) (authored by nullptr.cpp).
[CSSPGO] Fix MSVC initializing truncation warning (NFC)
Feb 2 2021, 7:07 PM
nullptr.cpp committed rGad50c8633321: [clang-format] Fix MSVC "unsafe use of type 'bool' in operation" warning (NFC) (authored by nullptr.cpp).
[clang-format] Fix MSVC "unsafe use of type 'bool' in operation" warning (NFC)
Feb 2 2021, 6:51 PM
nullptr.cpp committed rG8178a55b2570: [VFS] Fix Wreturn-type gcc warning (NFC) (authored by nullptr.cpp).
[VFS] Fix Wreturn-type gcc warning (NFC)
Feb 2 2021, 6:24 PM

Feb 1 2021

nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

Ping

Feb 1 2021, 3:29 AM · Restricted Project

Jan 29 2021

nullptr.cpp committed rG49556b87ae9b: [NFC][VFS] Fix a build warning due to an extra semicolon (authored by nullptr.cpp).
[NFC][VFS] Fix a build warning due to an extra semicolon
Jan 29 2021, 10:53 PM

Jan 28 2021

nullptr.cpp committed rG59bd2068e954: [NFC][ScalarizeMaskedMemIntrin] Fix unused variable warning (authored by nullptr.cpp).
[NFC][ScalarizeMaskedMemIntrin] Fix unused variable warning
Jan 28 2021, 11:18 PM
nullptr.cpp committed rGe5f258cb03f2: [NFC][DebugInfo] Fix Wreturn-type gcc warning (authored by nullptr.cpp).
[NFC][DebugInfo] Fix Wreturn-type gcc warning
Jan 28 2021, 7:43 PM
nullptr.cpp committed rGd6d0c09e84d6: [NFC][llvm-nm] Fix unused variable warning (authored by nullptr.cpp).
[NFC][llvm-nm] Fix unused variable warning
Jan 28 2021, 7:43 PM
nullptr.cpp committed rGfc4e8a3e8b4a: [NFC][IR][AsmWriter] Fix Wreturn-type gcc warning (authored by nullptr.cpp).
[NFC][IR][AsmWriter] Fix Wreturn-type gcc warning
Jan 28 2021, 12:43 AM
nullptr.cpp committed rG8644eb024bbd: [NFC][Transforms][Coroutines] Remove unused variable (authored by nullptr.cpp).
[NFC][Transforms][Coroutines] Remove unused variable
Jan 28 2021, 12:43 AM

Jan 26 2021

nullptr.cpp added reviewers for D88220: [C++20] P1825R0: More implicit moves: erik.pilkington, david_stone.
Jan 26 2021, 7:26 PM · Restricted Project

Jan 21 2021

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Update

Jan 21 2021, 10:29 PM · Restricted Project
nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Add test

Jan 21 2021, 7:51 PM · Restricted Project
nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

I notice a lack of any explicitly co_return-related tests and/or code in this patch. I'm just going to assume that is fine.

Jan 21 2021, 7:48 PM · Restricted Project

Jan 18 2021

nullptr.cpp committed rG9a0900dc4c6b: [NFC][AIX][XCOFF] Fix compile warning on strncpy (authored by nullptr.cpp).
[NFC][AIX][XCOFF] Fix compile warning on strncpy
Jan 18 2021, 10:07 PM
nullptr.cpp closed D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.
Jan 18 2021, 10:07 PM · Restricted Project
nullptr.cpp updated the diff for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.

Use StringRef

Jan 18 2021, 7:27 PM · Restricted Project
nullptr.cpp added inline comments to D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.
Jan 18 2021, 3:33 PM · Restricted Project
nullptr.cpp added a reviewer for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy: hubert.reinterpretcast.
Jan 18 2021, 2:20 AM · Restricted Project
nullptr.cpp updated the diff for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.

Use memcpy

Jan 18 2021, 1:18 AM · Restricted Project

Jan 16 2021

nullptr.cpp updated the diff for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.

rebase

Jan 16 2021, 10:51 PM · Restricted Project
nullptr.cpp requested review of D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.
Jan 16 2021, 8:40 PM · Restricted Project

Jan 12 2021

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

rebase

Jan 12 2021, 6:34 PM · Restricted Project

Jan 5 2021

nullptr.cpp committed rGa032a4e7998c: [-Wcalled-once-parameter][NFC] Fix operator precedence warning (authored by nullptr.cpp).
[-Wcalled-once-parameter][NFC] Fix operator precedence warning
Jan 5 2021, 8:17 PM
nullptr.cpp committed rG74f93bc373d0: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp).
[Sema] Fix deleted function problem in implicitly movable test
Jan 5 2021, 6:06 PM
nullptr.cpp closed D92936: [Sema] Fix deleted function problem in implicitly movable test.
Jan 5 2021, 6:06 PM · Restricted Project

Jan 4 2021

nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

Fix use-of-uninitialized-value and -Wreturn-std-move with delete function

Jan 4 2021, 11:34 PM · Restricted Project
nullptr.cpp reopened D92936: [Sema] Fix deleted function problem in implicitly movable test.
Jan 4 2021, 11:25 PM · Restricted Project
nullptr.cpp added a reverting change for rG89b0972aa2f5: [Sema] Fix deleted function problem in implicitly movable test: rGe43b3d1f5e05: Revert "[Sema] Fix deleted function problem in implicitly movable test".
Jan 4 2021, 1:22 AM
nullptr.cpp committed rGe43b3d1f5e05: Revert "[Sema] Fix deleted function problem in implicitly movable test" (authored by nullptr.cpp).
Revert "[Sema] Fix deleted function problem in implicitly movable test"
Jan 4 2021, 1:22 AM
nullptr.cpp added a reverting change for D92936: [Sema] Fix deleted function problem in implicitly movable test: rGe43b3d1f5e05: Revert "[Sema] Fix deleted function problem in implicitly movable test".
Jan 4 2021, 1:22 AM · Restricted Project

Jan 1 2021

nullptr.cpp committed rG471dec3801b3: [CodeGen][NFC] Fix a build warning due to an extra semicolon (authored by nullptr.cpp).
[CodeGen][NFC] Fix a build warning due to an extra semicolon
Jan 1 2021, 6:43 PM
nullptr.cpp updated the diff for D93955: [Sema] Add support for reporting multiple errors during initialization.

Separate out D93962

Jan 1 2021, 1:56 AM · Restricted Project
nullptr.cpp requested review of D93962: [Sema] Fix the program state in reference initialization.
Jan 1 2021, 1:42 AM · Restricted Project
nullptr.cpp committed rGd5324c052b21: [clang-tidy][NFC] Fix a build warning due to an extra semicolon (authored by nullptr.cpp).
[clang-tidy][NFC] Fix a build warning due to an extra semicolon
Jan 1 2021, 12:00 AM
nullptr.cpp closed D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon.
Jan 1 2021, 12:00 AM · Restricted Project

Dec 31 2020

nullptr.cpp committed rG89b0972aa2f5: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp).
[Sema] Fix deleted function problem in implicitly movable test
Dec 31 2020, 11:48 PM
nullptr.cpp closed D92936: [Sema] Fix deleted function problem in implicitly movable test.
Dec 31 2020, 11:48 PM · Restricted Project
nullptr.cpp requested review of D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon.
Dec 31 2020, 10:19 PM · Restricted Project
nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

rebase

Dec 31 2020, 10:14 PM · Restricted Project
nullptr.cpp updated the diff for D93955: [Sema] Add support for reporting multiple errors during initialization.

Update

Dec 31 2020, 2:03 AM · Restricted Project
nullptr.cpp requested review of D93955: [Sema] Add support for reporting multiple errors during initialization.
Dec 31 2020, 1:42 AM · Restricted Project

Dec 29 2020

nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

Ping

Dec 29 2020, 1:52 AM · Restricted Project

Dec 28 2020

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

rebase

Dec 28 2020, 12:29 AM · Restricted Project

Dec 27 2020

nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

rebase

Dec 27 2020, 11:47 PM · Restricted Project

Dec 23 2020

nullptr.cpp added a comment to D92936: [Sema] Fix deleted function problem in implicitly movable test.

Ping

Dec 23 2020, 12:04 AM · Restricted Project

Dec 22 2020

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Add more tests

Dec 22 2020, 11:57 PM · Restricted Project

Dec 11 2020

nullptr.cpp added a comment to D92936: [Sema] Fix deleted function problem in implicitly movable test.

Note: The failed test has nothing to do with this patch.

Dec 11 2020, 4:57 AM · Restricted Project
nullptr.cpp updated the summary of D92936: [Sema] Fix deleted function problem in implicitly movable test.
Dec 11 2020, 3:31 AM · Restricted Project
nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

Fix format

Dec 11 2020, 3:22 AM · Restricted Project
nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

Update

Dec 11 2020, 1:17 AM · Restricted Project

Dec 9 2020

nullptr.cpp requested review of D92936: [Sema] Fix deleted function problem in implicitly movable test.
Dec 9 2020, 6:52 AM · Restricted Project

Dec 7 2020

nullptr.cpp updated the summary of D88220: [C++20] P1825R0: More implicit moves.
Dec 7 2020, 5:02 AM · Restricted Project
nullptr.cpp updated the summary of D88220: [C++20] P1825R0: More implicit moves.
Dec 7 2020, 5:01 AM · Restricted Project