Page MenuHomePhabricator

nullptr.cpp (Yang Fan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2019, 7:08 PM (67 w, 6 d)

Recent Activity

Today

nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

move test to class/class.init/class.copy.elision/p1.cpp

Sat, Oct 31, 2:19 AM · Restricted Project

Thu, Oct 29

nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

rebase

Thu, Oct 29, 11:56 PM · Restricted Project
nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Could you perhaps integrate this into the existing test clang/test/CXX/special/class.copy/implicit-move.cpp instead?
Whenever you have something that closely corresponds to the standard, CXX is probably the right place for a test.

clang/test/CXX/special/class.copy/implicit-move.cpp and clang/test/CXX/special/class.copy/implicit-move-def.cpp are tests for implicit (non-)declaration of move constructor and assignment, they have nothing to do with this patch.
Because copy/move elision is defined in section [class.copy.elision] in standard, so I put the test in clang/test/CXX/special/class.copy/copy-elision.cpp.

Thu, Oct 29, 9:44 PM · Restricted Project
nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

make test more clearly

Thu, Oct 29, 9:25 PM · Restricted Project

Wed, Oct 28

nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Ping
I don't have commit access, can anyone help me commit this with "Yang Fan <nullptr.cpp@gmail.com>" ?
Thanks!

Wed, Oct 28, 1:29 AM · Restricted Project
nullptr.cpp added reviewers for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move: nlewycky, rjmccall, aaronpuchert.
Wed, Oct 28, 1:29 AM · Restricted Project

Thu, Oct 15

nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Ping!
I don't have commit access, can anyone help me commit this with "Yang Fan <nullptr.cpp@gmail.com>" ?
Thanks!

Thu, Oct 15, 12:40 AM · Restricted Project

Sep 26 2020

nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.
  • C++11:

[class.copy]p32:
When the criteria for elision of a copy operation are met or would be met save for the fact that the source object is a function parameter, and the object to be copied is designated by an lvalue, overload resolution to select the constructor for the copy is first performed as if the object were designated by an rvalue.

Thus should use rules at:

[class.copy]p31:
— in a return statement in a function with a class return type, when the expression is the name of a non-volatile automatic object ...

Volatile automatic objects cannot pass this check.

Sep 26 2020, 1:11 AM · Restricted Project
nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Add test.

Sep 26 2020, 1:06 AM · Restricted Project

Sep 25 2020

nullptr.cpp requested review of D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.
Sep 25 2020, 5:09 AM · Restricted Project

Sep 24 2020

nullptr.cpp requested review of D88220: [C++20] Implement more implicit moves for return statements(Part of P1825R0).
Sep 24 2020, 5:18 AM · Restricted Project

Sep 10 2020

nullptr.cpp removed 1 auditor(s) for rG24ecfdac7b7d: [APFloat] Fix uninitialized variable in IEEEFloat constructors: nullptr.cpp.
Sep 10 2020, 5:43 AM
nullptr.cpp added 1 auditor(s) for rG24ecfdac7b7d: [APFloat] Fix uninitialized variable in IEEEFloat constructors: nullptr.cpp.
Sep 10 2020, 5:37 AM
nullptr.cpp updated the diff for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 10 2020, 4:59 AM · Restricted Project, Restricted Project
nullptr.cpp updated the diff for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 10 2020, 2:42 AM · Restricted Project, Restricted Project
nullptr.cpp requested review of D87436: [NFC] Fix pessimizing-move warnings due to std::move in return statements.
Sep 10 2020, 12:10 AM · Restricted Project

Sep 9 2020

nullptr.cpp added a comment to D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.

I don't have commit access, can anyone help me commit this with "Yang Fan <nullptr.cpp@gmail.com>" ?
Thanks!

Sep 9 2020, 8:08 PM · Restricted Project, Restricted Project
nullptr.cpp updated the summary of D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 9 2020, 7:28 PM · Restricted Project, Restricted Project
nullptr.cpp updated the diff for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.

Fix by directly using INT_MAX and INT32_MAX.

Sep 9 2020, 7:27 PM · Restricted Project, Restricted Project
nullptr.cpp added a comment to D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.

I don't have commit access, can anyone help me commit this and D86997?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Sep 9 2020, 1:14 AM · Restricted Project, Restricted Project
nullptr.cpp added reviewers for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness: Eugene.Zelenko, spatel, aardappel, aheejin, sbc100, hiraditya.
Sep 9 2020, 1:13 AM · Restricted Project, Restricted Project
nullptr.cpp requested review of D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 9 2020, 12:09 AM · Restricted Project, Restricted Project

Sep 3 2020

nullptr.cpp added a comment to D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

I don't have commit access, can anyone help commit this?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Sep 3 2020, 4:47 PM · Restricted Project
nullptr.cpp retitled D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors from [APFloat] Fix uninitialized variable in IEEEFloat constructor to [APFloat] Fix uninitialized variable in IEEEFloat constructors.
Sep 3 2020, 2:46 AM · Restricted Project
nullptr.cpp updated the diff for D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

Also fix other constructors.

Sep 3 2020, 2:43 AM · Restricted Project

Sep 1 2020

nullptr.cpp added a comment to D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

What problem does this cause? IEEEFloat::initFromFloatAPInt which is called for IEEEFloat::IEEEFloat(float f) also doesn't assign exponent from what I can see.

Sep 1 2020, 7:37 PM · Restricted Project
nullptr.cpp added reviewers for D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors: craig.topper, lattner, ekatz.
Sep 1 2020, 7:37 PM · Restricted Project
nullptr.cpp requested review of D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.
Sep 1 2020, 6:46 PM · Restricted Project

Aug 31 2020

nullptr.cpp added a comment to D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

@jdoerfert @ABataev
I don't have commit access, can you help commit this?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Aug 31 2020, 9:16 PM · Restricted Project
nullptr.cpp updated the diff for D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

trigger rebuild

Aug 31 2020, 8:45 PM · Restricted Project
nullptr.cpp added a comment to D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.

Nice, thank you! Did you stumble across this, or found it with a tool?

I just happened to see these code:-).
Maybe we should write a checker to check this situation? I will start doing this!

Good idea! And thanks for the fix! :)

Aug 31 2020, 12:42 AM · Restricted Project

Aug 30 2020

nullptr.cpp added a comment to D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

Can you add the test that exposed this?

Aug 30 2020, 11:56 PM · Restricted Project
nullptr.cpp updated the summary of D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().
Aug 30 2020, 11:49 PM · Restricted Project
nullptr.cpp updated the diff for D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

Fix by changing the loop condition to Level > 0.

Aug 30 2020, 11:48 PM · Restricted Project
nullptr.cpp requested review of D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().
Aug 30 2020, 9:33 PM · Restricted Project
nullptr.cpp requested review of D86856: [ORC][NFC] Fix gcc warning by remove the extra semicolon.
Aug 30 2020, 8:49 PM · Restricted Project

Aug 27 2020

nullptr.cpp added a comment to D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.

@Szelethus @martong
Sorry to interrupt, I don't have commit access, can you help commit this and D86334?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Aug 27 2020, 6:49 AM · Restricted Project
nullptr.cpp added a comment to D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.

Nice, thank you! Did you stumble across this, or found it with a tool?

Aug 27 2020, 4:19 AM · Restricted Project
nullptr.cpp requested review of D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.
Aug 27 2020, 1:56 AM · Restricted Project

Aug 21 2020

nullptr.cpp added a comment to D86334: [analyzer] Remove redundant output errs.

I don't have commit access, can you help commit it?

Aug 21 2020, 2:59 AM · Restricted Project
nullptr.cpp added a reviewer for D86334: [analyzer] Remove redundant output errs: xazax.hun.
Aug 21 2020, 1:57 AM · Restricted Project
nullptr.cpp added reviewers for D86334: [analyzer] Remove redundant output errs: dcoughlin, NoQ, george.karpenkov.
Aug 21 2020, 12:52 AM · Restricted Project
nullptr.cpp requested review of D86334: [analyzer] Remove redundant output errs.
Aug 21 2020, 12:50 AM · Restricted Project

Aug 20 2020

nullptr.cpp updated nullptr.cpp.
Aug 20 2020, 11:43 PM