This patch makes DWARF writer emit DW_AT_string_length using the stringLengthExp operand of DIStringType.
This is part of the effort to add debug info support for Fortran deferred length strings.
Also updated the tests to exercise the change.
Paths
| Differential D92412
[DebugInfo] Add handling of stringLengthExp operand of DIStringType ClosedPublic Authored by cchen15 on Dec 1 2020, 11:19 AM.
Details Summary This patch makes DWARF writer emit DW_AT_string_length using the stringLengthExp operand of DIStringType. This is part of the effort to add debug info support for Fortran deferred length strings. Also updated the tests to exercise the change.
Diff Detail Event Timeline
Comment Actions Thanks @cchen15 for the patch! It seems like you're also adding support for FORTRAN deferred length string would you please make appropriate changes in summary to reflect the intent.
This revision is now accepted and ready to land.Dec 3 2020, 9:59 PM Closed by commit rG1f67247eea13: [DebugInfo] Add handling of stringLengthExp operand of DIStringType. (authored by cchen15). · Explain WhyDec 8 2020, 11:50 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 308716 llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
llvm/test/DebugInfo/X86/distringtype.ll
llvm/test/DebugInfo/fortran-string-type.ll |
Can we consolidate stringLength and stringLengthExp into one operand? It seems to me that a DIStringType can have one or the other, but not both.