Page MenuHomePhabricator

cchen15 (Chih-Ping Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 20 2020, 8:47 AM (88 w, 1 d)

Recent Activity

Apr 15 2022

cchen15 committed rGeab6e94f912d: [DebugInfo] Add a TargetFuncName field in DISubprogram for (authored by cchen15).
[DebugInfo] Add a TargetFuncName field in DISubprogram for
Apr 15 2022, 1:42 PM · Restricted Project, Restricted Project
cchen15 closed D123697: [DebugInfo] Add a TargetFuncName field in DISubprogram..
Apr 15 2022, 1:41 PM · debug-info, Restricted Project, Restricted Project
cchen15 added a comment to D123697: [DebugInfo] Add a TargetFuncName field in DISubprogram..

Thanks, @aprantl for the suggestion. Please review the doc change.

Apr 15 2022, 11:11 AM · debug-info, Restricted Project, Restricted Project
cchen15 updated the diff for D123697: [DebugInfo] Add a TargetFuncName field in DISubprogram..

Updated SourceLevelDebugging.rst.

Apr 15 2022, 11:10 AM · debug-info, Restricted Project, Restricted Project
cchen15 added a comment to D123697: [DebugInfo] Add a TargetFuncName field in DISubprogram..

could you also update SourceLevelDebugging.rst?

Apr 15 2022, 5:55 AM · debug-info, Restricted Project, Restricted Project
cchen15 updated the diff for D123697: [DebugInfo] Add a TargetFuncName field in DISubprogram..

Doubled round-trip and moved the test to test/Assembler.

Apr 15 2022, 5:46 AM · debug-info, Restricted Project, Restricted Project

Apr 13 2022

cchen15 requested review of D123697: [DebugInfo] Add a TargetFuncName field in DISubprogram..
Apr 13 2022, 11:06 AM · debug-info, Restricted Project, Restricted Project

Apr 7 2022

cchen15 added inline comments to D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..
Apr 7 2022, 7:44 AM · Restricted Project, debug-info, Restricted Project
cchen15 closed D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..

Closed by commit rGc226a5c4d7ea: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran.

Apr 7 2022, 4:54 AM · Restricted Project, debug-info, Restricted Project

Apr 6 2022

cchen15 added a comment to D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..

@dblaikie: A quick git blame shows that the original code for getDefaultLowerBound was added to DwarfCompileUnit.cpp in the following commit in 2012:

Apr 6 2022, 12:34 PM · Restricted Project, debug-info, Restricted Project
cchen15 updated the diff for D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..

@aprantl: Thanks for the feedback. I have updated the patch as you suggested. Please review.

Apr 6 2022, 7:18 AM · Restricted Project, debug-info, Restricted Project

Apr 4 2022

cchen15 added a comment to D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..

IMHO, it's a bit excessive to go through DISubrange for this simple language-specific attribute; plus, doing that would require a DIBuilder API change. DwarfUnit::getDefaultLowerBound probably went through a similar discussion and it's currently using getLanguage. Perhaps these can all be overhauled based on your suggestion when support is needed for some language that allows non-integer array index type, and we go forward with this simple change for now?

Apr 4 2022, 3:30 AM · Restricted Project, debug-info, Restricted Project

Apr 1 2022

cchen15 added a comment to D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..

For my experiment, I use the two files in the attachment: test-c.cpp is the main program. It calls the Fortran function DegCtoF in test.f90.

Apr 1 2022, 10:55 AM · Restricted Project, debug-info, Restricted Project

Mar 30 2022

cchen15 added a comment to D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..

Thank you @aprantl and @dblaikie for the feedback. I will do some experiments with LTO and provide an update.

Mar 30 2022, 5:02 AM · Restricted Project, debug-info, Restricted Project

Mar 28 2022

cchen15 requested review of D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..
Mar 28 2022, 6:58 AM · Restricted Project, debug-info, Restricted Project

Feb 2 2022

cchen15 added inline comments to D118276: Adding a DIBuilder interface for Fortran's assumed length string.
Feb 2 2022, 8:56 AM · Restricted Project, Restricted Project
cchen15 added inline comments to D118276: Adding a DIBuilder interface for Fortran's assumed length string.
Feb 2 2022, 6:47 AM · Restricted Project, Restricted Project

Feb 1 2022

cchen15 added inline comments to D118276: Adding a DIBuilder interface for Fortran's assumed length string.
Feb 1 2022, 1:33 PM · Restricted Project, Restricted Project
cchen15 added inline comments to D118276: Adding a DIBuilder interface for Fortran's assumed length string.
Feb 1 2022, 7:22 AM · Restricted Project, Restricted Project

Jan 28 2022

cchen15 added inline comments to D118276: Adding a DIBuilder interface for Fortran's assumed length string.
Jan 28 2022, 7:42 AM · Restricted Project, Restricted Project

Jan 26 2022

cchen15 added a comment to D118276: Adding a DIBuilder interface for Fortran's assumed length string.

I just added a new field StringLocationExp to DIStringType in this commit: https://reviews.llvm.org/rG28bfa57a7315c3161124c90b4d52f467616dc92e . Please add an optional argument to these createStringType functions so that the caller can specify this new field if it desires.

Jan 26 2022, 1:13 PM · Restricted Project, Restricted Project

Jan 25 2022

cchen15 added a comment to D117586: [DebugInfo] Add stringLocationExp field to DIStringType.

Added a test for backward compatibility.

Jan 25 2022, 12:21 PM · debug-info, Restricted Project
cchen15 updated the diff for D117586: [DebugInfo] Add stringLocationExp field to DIStringType.
Jan 25 2022, 12:20 PM · debug-info, Restricted Project

Jan 24 2022

cchen15 updated the diff for D117586: [DebugInfo] Add stringLocationExp field to DIStringType.
Jan 24 2022, 2:05 PM · debug-info, Restricted Project
cchen15 added inline comments to D117586: [DebugInfo] Add stringLocationExp field to DIStringType.
Jan 24 2022, 2:04 PM · debug-info, Restricted Project

Jan 18 2022

cchen15 updated the diff for D117586: [DebugInfo] Add stringLocationExp field to DIStringType.

Format fixes.

Jan 18 2022, 12:08 PM · debug-info, Restricted Project
cchen15 requested review of D117586: [DebugInfo] Add stringLocationExp field to DIStringType.
Jan 18 2022, 10:38 AM · debug-info, Restricted Project

Dec 7 2021

cchen15 added a comment to D115257: [NFC][CodeView] Use one unified access to the module in beginModule..

Thanks for the review, Reid.

Dec 7 2021, 10:56 AM · Restricted Project
cchen15 committed rGb5c42ef3da4d: [NFC][CodeView] Use one unified access to the module in beginModule. (authored by cchen15).
[NFC][CodeView] Use one unified access to the module in beginModule.
Dec 7 2021, 10:49 AM
cchen15 closed D115257: [NFC][CodeView] Use one unified access to the module in beginModule..
Dec 7 2021, 10:48 AM · Restricted Project
cchen15 requested review of D115257: [NFC][CodeView] Use one unified access to the module in beginModule..
Dec 7 2021, 8:36 AM · Restricted Project

Nov 9 2021

cchen15 added a comment to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..

Thanks for the review, Reid.

Nov 9 2021, 10:19 AM · Restricted Project
cchen15 committed rGcf0e32d197d3: [CodeView] Properly handle a DISubprogram in getScopeIndex. (authored by cchen15).
[CodeView] Properly handle a DISubprogram in getScopeIndex.
Nov 9 2021, 10:18 AM
cchen15 closed D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Nov 9 2021, 10:18 AM · Restricted Project
cchen15 added inline comments to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Nov 9 2021, 8:25 AM · Restricted Project
cchen15 updated the diff for D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Nov 9 2021, 8:23 AM · Restricted Project

Nov 4 2021

cchen15 added inline comments to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Nov 4 2021, 11:21 AM · Restricted Project
cchen15 added inline comments to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Nov 4 2021, 7:30 AM · Restricted Project
cchen15 added a comment to D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..

Thanks for the feedback, Reid!

Nov 4 2021, 7:00 AM · Restricted Project

Nov 3 2021

cchen15 requested review of D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex..
Nov 3 2021, 1:53 PM · Restricted Project

Nov 2 2021

cchen15 committed rG2ed29d87efbe: [CodeView] Fortran debug info emission in Code View. (authored by cchen15).
[CodeView] Fortran debug info emission in Code View.
Nov 2 2021, 12:07 PM
cchen15 closed D112826: [CodeView] Fortran debug info emission in Code View..
Nov 2 2021, 12:06 PM · Restricted Project
cchen15 added a comment to D112826: [CodeView] Fortran debug info emission in Code View..

FYI: I did check-llvm for both before and after my changes, and the results matched (with the same 9 failed tests).

Nov 2 2021, 11:15 AM · Restricted Project
cchen15 added a comment to D112826: [CodeView] Fortran debug info emission in Code View..

The Windows build seems to be broken by this commit in mlir:

Nov 2 2021, 9:11 AM · Restricted Project
cchen15 added a comment to D112900: [mlir][linalg][bufferize] Move BufferizableOpInterface implementations.

@springerm: It appears that this commit breaks the Windows build. Could you please take a look at this? Thanks!

Nov 2 2021, 9:07 AM · Restricted Project
cchen15 added inline comments to D112826: [CodeView] Fortran debug info emission in Code View..
Nov 2 2021, 6:23 AM · Restricted Project
cchen15 updated the diff for D112826: [CodeView] Fortran debug info emission in Code View..

Addresses formatting issues and comments from Reid. Thanks, Reid!

Nov 2 2021, 6:20 AM · Restricted Project

Oct 29 2021

cchen15 added reviewers for D112826: [CodeView] Fortran debug info emission in Code View.: rnk, alok.
Oct 29 2021, 9:02 AM · Restricted Project
cchen15 retitled D112826: [CodeView] Fortran debug info emission in Code View. from [DebugInfo] Fortran debug info emission in Code View. to [CodeView] Fortran debug info emission in Code View..
Oct 29 2021, 8:58 AM · Restricted Project
cchen15 requested review of D112826: [CodeView] Fortran debug info emission in Code View..
Oct 29 2021, 8:52 AM · Restricted Project

Sep 7 2021

cchen15 added a comment to D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.

Issue fixed as suggested in https://reviews.llvm.org/D108946.

Sep 7 2021, 3:53 AM · debug-info, Restricted Project

Aug 31 2021

cchen15 closed D108946: Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target.

Closed by commit rG1d36988394a5f37: Moved the test to X86 as it's x86 specific. (authored by cchen15).

Aug 31 2021, 12:02 PM · Restricted Project
cchen15 committed rG1d36988394a5: Moved the test to X86 as it's x86 specific. (authored by cchen15).
Moved the test to X86 as it's x86 specific.
Aug 31 2021, 11:50 AM

Aug 30 2021

cchen15 added a comment to D108946: Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target.

Thanks for the suggestion, @lebedev.ri. Could you please approve if this looks good to you?

Aug 30 2021, 2:19 PM · Restricted Project
cchen15 added a reviewer for D108946: Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target: lebedev.ri.
Aug 30 2021, 2:18 PM · Restricted Project
cchen15 updated the diff for D108946: Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target.

Moved the test to CodeGen/X86.

Aug 30 2021, 2:14 PM · Restricted Project
cchen15 added a comment to D108946: Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target.

I can't find documentation on the REQUIRES keyword. A quick grep shows that x86-registered-target seems to be the one to use (I tried x86_64-registered-target but that's reported as UNSUPPORTED). Please suggest a better requirement if there's one.

Aug 30 2021, 1:48 PM · Restricted Project
cchen15 requested review of D108946: Fix dbg-distring-uint.ll test failure on platforms not supporting x86 target.
Aug 30 2021, 1:45 PM · Restricted Project
cchen15 added a comment to D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.

Hi @aprantl. I just got notified by buildbots that the new test fails on clang-aarch64-quick and clang-armv7-quick (maybe more to come). Could you please suggest a way to disable this test on triples that don't support the 'x86_64-unknown-linux-gnu' target? Thanks!

Aug 30 2021, 1:06 PM · debug-info, Restricted Project
cchen15 committed rG070090cfa57f: [DebugInfo] Remove the restriction on the size of DIStringType (authored by cchen15).
[DebugInfo] Remove the restriction on the size of DIStringType
Aug 30 2021, 12:39 PM
cchen15 closed D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.
Aug 30 2021, 12:39 PM · debug-info, Restricted Project

Aug 26 2021

cchen15 added inline comments to D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.
Aug 26 2021, 1:23 PM · debug-info, Restricted Project
cchen15 updated the diff for D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.
Aug 26 2021, 1:21 PM · debug-info, Restricted Project

Aug 24 2021

cchen15 retitled D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType from Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType to [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.
Aug 24 2021, 5:05 AM · debug-info, Restricted Project

Aug 23 2021

cchen15 requested review of D108559: [DebugInfo] Remove the restriction on the size of DIStringType in DebugHandlerBase::isUnsignedDIType.
Aug 23 2021, 8:18 AM · debug-info, Restricted Project

Jan 4 2021

cchen15 committed rG975b64b29375: [docs] Release notes for IsDecl in DIModule. (authored by cchen15).
[docs] Release notes for IsDecl in DIModule.
Jan 4 2021, 4:06 AM
cchen15 closed D93558: [docs] Release notes for IsDecl in DIModule..
Jan 4 2021, 4:05 AM · Restricted Project

Dec 18 2020

cchen15 updated the diff for D93558: [docs] Release notes for IsDecl in DIModule..

Updated the test filename to reflect the change made in D93559.

Dec 18 2020, 1:17 PM · Restricted Project
cchen15 committed rG08c4b4054b3d: Rename files with same (case insensitive) name (authored by cchen15).
Rename files with same (case insensitive) name
Dec 18 2020, 1:05 PM
cchen15 closed D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 1:04 PM · Restricted Project
cchen15 added a comment to D93559: Rename files with same (case insensitive) name.

Thanks a lot, Aditya. Again, my apologies for the screw-up. I will make sure I won't make the same mistake next time I add a new file.

Dec 18 2020, 12:09 PM · Restricted Project
cchen15 added a comment to D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
In D93462#2463742, @gkm wrote:

@cchen15 @SouraVX @aprantl

This diff breaks git source trees on case-insensitive filesystems, such as on macOS.
I did this on Linux, which is case-sensitive:

$ find . |fgrep -i llvm/test/DebugInfo/X86/DIModule.ll
./llvm/test/DebugInfo/X86/DIModule.ll
./llvm/test/DebugInfo/X86/dimodule.ll

On a case-insensitive filesystem, these names collide and one overwrites the other, yeilding a tree with irreconcilable conflicts.

Please fix ASAP! Thanx!

Dec 18 2020, 11:58 AM · debug-info, Restricted Project
cchen15 added a comment to D93559: Rename files with same (case insensitive) name.

Thanks for catching this for me. I don't work on Mac. :(

Dec 18 2020, 11:54 AM · Restricted Project
cchen15 requested review of D93558: [docs] Release notes for IsDecl in DIModule..
Dec 18 2020, 11:36 AM · Restricted Project
cchen15 committed rG5f75dcf5719f: [DebugInfo] Support Fortran 'use <external module>' statement. (authored by cchen15).
[DebugInfo] Support Fortran 'use <external module>' statement.
Dec 18 2020, 10:12 AM
cchen15 closed D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
Dec 18 2020, 10:11 AM · debug-info, Restricted Project
cchen15 added a comment to D93462: [DebugInfo] Support Fortran 'use <external module>' statement..

LGTM! Thanks for the patch.
One small thing, do you mind adding a one liner to release notes ? It would help in tracking extensions to Debug Metadata(previous extensions of DIModule were part of LLVM11).

Dec 18 2020, 5:30 AM · debug-info, Restricted Project

Dec 17 2020

cchen15 requested review of D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
Dec 17 2020, 8:29 AM · debug-info, Restricted Project

Dec 8 2020

cchen15 committed rG1f67247eea13: [DebugInfo] Add handling of stringLengthExp operand of DIStringType. (authored by cchen15).
[DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 8 2020, 11:50 AM
cchen15 closed D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 8 2020, 11:50 AM · debug-info, Restricted Project

Dec 7 2020

cchen15 added a comment to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 7 2020, 3:45 AM · debug-info, Restricted Project

Dec 3 2020

cchen15 added a watcher for debug-info: cchen15.
Dec 3 2020, 12:20 PM
cchen15 added inline comments to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 3 2020, 9:38 AM · debug-info, Restricted Project
cchen15 updated the diff for D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.

Made changes based on the review comments.

Dec 3 2020, 9:35 AM · debug-info, Restricted Project
cchen15 updated the summary of D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 3 2020, 9:34 AM · debug-info, Restricted Project

Dec 1 2020

cchen15 added inline comments to D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 1 2020, 11:21 AM · debug-info, Restricted Project
cchen15 requested review of D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.
Dec 1 2020, 11:19 AM · debug-info, Restricted Project

Oct 28 2020

cchen15 added inline comments to D90323: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 28 2020, 1:32 PM · Restricted Project
cchen15 added a comment to D90323: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 28 2020, 11:13 AM · Restricted Project
cchen15 requested review of D90323: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 28 2020, 11:07 AM · Restricted Project

Oct 26 2020

cchen15 added inline comments to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 26 2020, 1:05 PM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Typed the attributes as PointerUnion<DIExpression *, DIVariable *>, and updated the test to exercise the DIVariable case.

Oct 26 2020, 1:02 PM · Restricted Project
cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

We can do that, but then the debugger would need to work a bit harder in order to get a constant, doesn't it? I don't feel strongly either way. If you do want it done the way you prefer, please let me know and I will make the change.

That's an interesting point. Do we emit different DWARF FORMs for constant vs constant DIExpression? An elegant solution would be to recognize constant DIExpressions in AsmPrinter (DIExpression::isConstant) and emit the same DWARF FORM we would emit for an IR constant if the expression is a constant.

Oct 26 2020, 12:59 PM · Restricted Project

Oct 23 2020

cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Reverted back to type those attributes as Metadata to allow DIVairbale.

Oct 23 2020, 4:04 AM · Restricted Project

Oct 22 2020

cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Also, DIBuilder::createConstantValueExpression(uint64_t) is already available for doing constant via DIExpression,, and its usage is demonstrated in the unit test.

Oct 22 2020, 1:42 PM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Typed the attributes as DIExpression*, as suggested by @aprantl.

Oct 22 2020, 1:39 PM · Restricted Project
cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

These can be DIExpression, ConstantAsMetadata, etc, so Metadata looks to be the right specificity (and the underlying 'get' function it calls types them as Metadata too).

Why do we need to accept both DIExpression and ConstantAsMetadata? Since we can also represent all constants as DIExpression, I think I would prefer to have only one way to represent a constant. Would it be feasible to expect clients to pass constants as DIExpression(DW_OP_constu, <number>, DW_OP_stack_value)? And if it doesn't already exist perhaps add a DIExpression *DIBuilder::createConstantExpression(unsigned value) API?

Oct 22 2020, 10:49 AM · Restricted Project

Oct 21 2020

cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Including the rank attribute in the patch.

Oct 21 2020, 9:19 AM · Restricted Project
cchen15 updated the diff for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Added a unit test for the patch.

Oct 21 2020, 8:29 AM · Restricted Project
cchen15 added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Sorry. Please ignore Patch 2.

Oct 21 2020, 6:04 AM · Restricted Project