- User Since
- Oct 20 2020, 8:47 AM (88 w, 1 d)
Apr 15 2022
Thanks, @aprantl for the suggestion. Please review the doc change.
Doubled round-trip and moved the test to test/Assembler.
Apr 13 2022
Apr 7 2022
Closed by commit rGc226a5c4d7ea: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran.
Apr 6 2022
@dblaikie: A quick git blame shows that the original code for getDefaultLowerBound was added to DwarfCompileUnit.cpp in the following commit in 2012:
@aprantl: Thanks for the feedback. I have updated the patch as you suggested. Please review.
Apr 4 2022
IMHO, it's a bit excessive to go through DISubrange for this simple language-specific attribute; plus, doing that would require a DIBuilder API change. DwarfUnit::getDefaultLowerBound probably went through a similar discussion and it's currently using getLanguage. Perhaps these can all be overhauled based on your suggestion when support is needed for some language that allows non-integer array index type, and we go forward with this simple change for now?
Apr 1 2022
For my experiment, I use the two files in the attachment: test-c.cpp is the main program. It calls the Fortran function DegCtoF in test.f90.
Mar 30 2022
Mar 28 2022
Feb 2 2022
Feb 1 2022
Jan 28 2022
Jan 26 2022
I just added a new field StringLocationExp to DIStringType in this commit: https://reviews.llvm.org/rG28bfa57a7315c3161124c90b4d52f467616dc92e . Please add an optional argument to these createStringType functions so that the caller can specify this new field if it desires.
Jan 25 2022
Added a test for backward compatibility.
Jan 24 2022
Jan 18 2022
Dec 7 2021
Thanks for the review, Reid.
Nov 9 2021
Thanks for the review, Reid.
Nov 4 2021
Thanks for the feedback, Reid!
Nov 3 2021
Nov 2 2021
FYI: I did check-llvm for both before and after my changes, and the results matched (with the same 9 failed tests).
The Windows build seems to be broken by this commit in mlir:
@springerm: It appears that this commit breaks the Windows build. Could you please take a look at this? Thanks!
Addresses formatting issues and comments from Reid. Thanks, Reid!
Oct 29 2021
Sep 7 2021
Issue fixed as suggested in https://reviews.llvm.org/D108946.
Aug 31 2021
Closed by commit rG1d36988394a5f37: Moved the test to X86 as it's x86 specific. (authored by cchen15).
Aug 30 2021
Thanks for the suggestion, @lebedev.ri. Could you please approve if this looks good to you?
Moved the test to CodeGen/X86.
I can't find documentation on the REQUIRES keyword. A quick grep shows that x86-registered-target seems to be the one to use (I tried x86_64-registered-target but that's reported as UNSUPPORTED). Please suggest a better requirement if there's one.
Hi @aprantl. I just got notified by buildbots that the new test fails on clang-aarch64-quick and clang-armv7-quick (maybe more to come). Could you please suggest a way to disable this test on triples that don't support the 'x86_64-unknown-linux-gnu' target? Thanks!
Aug 26 2021
Aug 24 2021
Aug 23 2021
Jan 4 2021
Dec 18 2020
Updated the test filename to reflect the change made in D93559.
Thanks a lot, Aditya. Again, my apologies for the screw-up. I will make sure I won't make the same mistake next time I add a new file.
Thanks for catching this for me. I don't work on Mac. :(
Dec 17 2020
Dec 8 2020
Dec 7 2020
Dec 3 2020
Made changes based on the review comments.
Dec 1 2020
Oct 28 2020
Oct 26 2020
Typed the attributes as PointerUnion<DIExpression *, DIVariable *>, and updated the test to exercise the DIVariable case.
Oct 23 2020
Reverted back to type those attributes as Metadata to allow DIVairbale.
Oct 22 2020
Also, DIBuilder::createConstantValueExpression(uint64_t) is already available for doing constant via DIExpression,, and its usage is demonstrated in the unit test.
Typed the attributes as DIExpression*, as suggested by @aprantl.
Oct 21 2020
Including the rank attribute in the patch.
Added a unit test for the patch.
Sorry. Please ignore Patch 2.