[NFC] Add unit tests for printing/parsing of variadic operands and results.
ClosedPublic
Actions

Authored by jurahul on Nov 16 2020, 11:51 AM.

Details

Reviewers

mehdi_amini
rriddle

Commits

rG8a4fe75d70e1: [NFC] Add unit tests for printing/parsing of variadic operands and results.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jurahul created this revision.Nov 16 2020, 11:51 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2020, 11:51 AM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 11 others. · View Herald Transcript

jurahul requested review of this revision.Nov 16 2020, 11:51 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 16 2020, 11:51 AM

Harbormaster completed remote builds in B78990: Diff 305567.Nov 16 2020, 12:08 PM

rriddle accepted this revision.Nov 16 2020, 4:08 PM

rriddle added inline comments.

mlir/test/lib/Dialect/Test/TestOps.td
1531	nit: <> is really awkward to see(I don't think I've ever seen it used this way, just use [] instead.

This revision is now accepted and ready to land.Nov 16 2020, 4:08 PM

rriddle added inline comments.Nov 16 2020, 4:09 PM

mlir/test/lib/Dialect/Test/TestOps.td
1531	Or ()

Fix nit

Harbormaster completed remote builds in B79033: Diff 305631.Nov 16 2020, 5:59 PM

Closed by commit rG8a4fe75d70e1: [NFC] Add unit tests for printing/parsing of variadic operands and results. (authored by jurahul). · Explain WhyNov 17 2020, 9:22 AM

This revision was automatically updated to reflect the committed changes.

jurahul added a commit: rG8a4fe75d70e1: [NFC] Add unit tests for printing/parsing of variadic operands and results..

Revision Contents
Changeset List

Path

Size

mlir/

test/

lib/

Dialect/

Test/

TestOps.td

26 lines

mlir-tblgen/

op-format.mlir

14 lines

Diff 305826

View Options

mlir/test/lib/Dialect/Test/TestOps.td