This is an archive of the discontinued LLVM Phabricator instance.

Differential D90969

Renovate CMake file for the `llvm-cfi-verify` tool
ClosedPublic

Authored by vtjnash on Nov 6 2020, 1:12 PM.

Details

Reviewers
chapuni
stephenneuendorffer
tstellar
mgorny
hctim
Commits
rG16e7973c5d8f: Renovate CMake file for the `llvm-cfi-verify` tool
Summary

Hopefully this is the non-problematic part from https://reviews.llvm.org/rL342148, which later got reverted in r342336 (b09a8c9bd9b819741b38071a7ccd95042ef2643a) due to problems with the llvm-exegesis part of the change. That part would also still be desirable, but currently appears not to be possible (https://reviews.llvm.org/D81922).

I think this should replace https://reviews.llvm.org/D44650, per Keno's comment there.

Diff Detail

Event Timeline

vtjnash created this revision.Nov 6 2020, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2020, 1:12 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
vtjnash requested review of this revision.Nov 6 2020, 1:12 PM
vtjnash edited the summary of this revision. (Show Details)Nov 6 2020, 1:39 PM
vtjnash added a subscriber: Restricted Project.
Herald added subscribers: mstojanovic, courbet. · View Herald TranscriptNov 6 2020, 1:39 PM
Harbormaster completed remote builds in B77927: Diff 303533.Nov 6 2020, 1:47 PM
vchuravy mentioned this in D44650: Fix build of llvm-cfi-verify on mingw32.Nov 6 2020, 1:53 PM
vtjnash added a reviewer: chapuni.Nov 9 2020, 10:25 AM
vtjnash added reviewers: stephenneuendorffer, tstellar.Nov 23 2020, 5:30 PM
loladiro added reviewers: mgorny, hctim.Jan 5 2021, 3:04 PM
loladiro added subscribers: hctim, loladiro.

LGTM, but adding @mgorny and @hctim for D81921, which also tried to address the same issue as D44650 (which this replaces), in case I missed something that the former is addressing that this revision doesn't.

hctim accepted this revision.Jan 5 2021, 4:53 PM

Looks reasonable to me.

This revision is now accepted and ready to land.Jan 5 2021, 4:53 PM
This revision was landed with ongoing or failed builds.Feb 8 2021, 3:27 PM
Closed by commit rG16e7973c5d8f: Renovate CMake file for the `llvm-cfi-verify` tool (authored by vtjnash). · Explain Why
This revision was automatically updated to reflect the committed changes.
vtjnash added a commit: rG16e7973c5d8f: Renovate CMake file for the `llvm-cfi-verify` tool.

Revision Contents

PathSize
llvm/
tools/
llvm-cfi-verify/
lib/
25 lines

Diff 322230

llvm/tools/llvm-cfi-verify/lib/CMakeLists.txt

add_library(LLVMCFIVerify set(LLVM_LINK_COMPONENTS
STATIC
FileAnalysis.cpp
FileAnalysis.h
GraphBuilder.cpp
GraphBuilder.h
)
llvm_update_compile_flags(LLVMCFIVerify)
if (LLVM_LINK_LLVM_DYLIB)
set(libs LLVM)
else()
llvm_map_components_to_libnames(libs
DebugInfoDWARF DebugInfoDWARF
MC MC
MCParser MCParser
Object Object
Support Support
Symbolize Symbolize
) )
endif()
target_link_libraries(LLVMCFIVerify ${libs}) add_llvm_library(LLVMCFIVerify
set_target_properties(LLVMCFIVerify PROPERTIES FOLDER "Libraries") STATIC
FileAnalysis.cpp
FileAnalysis.h
GraphBuilder.cpp
GraphBuilder.h
)