Page MenuHomePhabricator

[llvm] Avoid linking llvm-cfi-verify to duplicate libs
ClosedPublic

Authored by mgorny on Jun 16 2020, 3:24 AM.

Details

Summary

Fix the CMake rules for LLVMCFIVerify library not to pull duplicate
LLVM .a libraries when linking to the dylib. This prevents problems
due to duplicate symbols and apparently fixes mingw32.

This is an alternative approach to D44650 that just forces .a libraries
instead. However, there doesn't seem to be any reason to do that.

Diff Detail

Event Timeline

mgorny created this revision.Jun 16 2020, 3:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2020, 3:24 AM
hctim accepted this revision.Jun 16 2020, 10:13 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 16 2020, 10:13 AM
This revision was automatically updated to reflect the committed changes.