Page MenuHomePhabricator

mstojanovic (Miloš Stojanović)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 5:05 AM (171 w, 4 d)

Recent Activity

Feb 19 2020

mstojanovic committed rG79c7d34dccda: Recommit: "[llvm-exegesis] Improve error reporting in Assembler.cpp" (authored by mstojanovic).
Recommit: "[llvm-exegesis] Improve error reporting in Assembler.cpp"
Feb 19 2020, 5:43 AM

Feb 18 2020

mstojanovic added a comment to rG63bb9fee525f: [llvm-exegesis] Improve error reporting in Assembler.cpp.

Reverted in rG7603bfb4b0a6.

Feb 18 2020, 9:49 AM
mstojanovic committed rG7603bfb4b0a6: Revert "[llvm-exegesis] Improve error reporting in Assembler.cpp" (authored by mstojanovic).
Revert "[llvm-exegesis] Improve error reporting in Assembler.cpp"
Feb 18 2020, 9:39 AM
mstojanovic committed rG63bb9fee525f: [llvm-exegesis] Improve error reporting in Assembler.cpp (authored by mstojanovic).
[llvm-exegesis] Improve error reporting in Assembler.cpp
Feb 18 2020, 5:32 AM
mstojanovic closed D74325: [llvm-exegesis] Improve error reporting in Assembler.cpp.
Feb 18 2020, 5:32 AM · Restricted Project
mstojanovic added a comment to D74325: [llvm-exegesis] Improve error reporting in Assembler.cpp.

Ping.

Feb 18 2020, 2:50 AM · Restricted Project

Feb 10 2020

mstojanovic added inline comments to D74325: [llvm-exegesis] Improve error reporting in Assembler.cpp.
Feb 10 2020, 7:48 AM · Restricted Project
mstojanovic created D74325: [llvm-exegesis] Improve error reporting in Assembler.cpp.
Feb 10 2020, 7:43 AM · Restricted Project

Feb 7 2020

mstojanovic committed rG205292740d88: [llvm-exegesis] Improve error reporting in BenchmarkRunner.cpp (authored by mstojanovic).
[llvm-exegesis] Improve error reporting in BenchmarkRunner.cpp
Feb 7 2020, 7:33 AM
mstojanovic closed D74215: [llvm-exegesis] Improve error reporting in BenchmarkRunner.cpp.
Feb 7 2020, 7:33 AM · Restricted Project
mstojanovic updated the diff for D74215: [llvm-exegesis] Improve error reporting in BenchmarkRunner.cpp.

Formatted patch.

Feb 7 2020, 6:20 AM · Restricted Project
mstojanovic committed rG446268a22345: [llvm-exegesis] Add a custom error for clustering (authored by mstojanovic).
[llvm-exegesis] Add a custom error for clustering
Feb 7 2020, 5:36 AM
mstojanovic committed rG830af528a550: Recommit: "[llvm-exegesis] Improve error reporting" (authored by mstojanovic).
Recommit: "[llvm-exegesis] Improve error reporting"
Feb 7 2020, 5:36 AM
mstojanovic committed rG4bd40f71a72c: Recommit: "[llvm-exegesis] Improve error reporting in Target.cpp" (authored by mstojanovic).
Recommit: "[llvm-exegesis] Improve error reporting in Target.cpp"
Feb 7 2020, 5:36 AM
mstojanovic closed D74124: [llvm-exegesis] Add a custom error for clustering.
Feb 7 2020, 5:36 AM · Restricted Project
mstojanovic created D74215: [llvm-exegesis] Improve error reporting in BenchmarkRunner.cpp.
Feb 7 2020, 4:42 AM · Restricted Project

Feb 6 2020

mstojanovic created D74124: [llvm-exegesis] Add a custom error for clustering.
Feb 6 2020, 5:23 AM · Restricted Project
mstojanovic committed rG141915963b6a: [llvm-exegesis] Improve error reporting in Target.cpp (authored by mstojanovic).
[llvm-exegesis] Improve error reporting in Target.cpp
Feb 6 2020, 3:28 AM
mstojanovic committed rGb3576f60ebc8: [llvm-exegesis] Improve error reporting (authored by mstojanovic).
[llvm-exegesis] Improve error reporting
Feb 6 2020, 3:28 AM
mstojanovic closed D74113: [llvm-exegesis] Improve error reporting in Target.cpp.
Feb 6 2020, 3:28 AM · Restricted Project
mstojanovic closed D74085: [llvm-exegesis] Improve error reporting.
Feb 6 2020, 3:28 AM · Restricted Project
mstojanovic created D74113: [llvm-exegesis] Improve error reporting in Target.cpp.
Feb 6 2020, 2:08 AM · Restricted Project
mstojanovic committed rGb093b663707a: [NFC] Fix error handling documentation (authored by mstojanovic).
[NFC] Fix error handling documentation
Feb 6 2020, 1:23 AM
mstojanovic closed D74069: [NFC] Fix error handling documentation.
Feb 6 2020, 1:23 AM · Restricted Project

Feb 5 2020

mstojanovic created D74085: [llvm-exegesis] Improve error reporting.
Feb 5 2020, 1:12 PM · Restricted Project
mstojanovic updated the summary of D74069: [NFC] Fix error handling documentation.
Feb 5 2020, 9:46 AM · Restricted Project
mstojanovic created D74069: [NFC] Fix error handling documentation.
Feb 5 2020, 9:46 AM · Restricted Project

Jan 28 2020

mstojanovic committed rG4c8817cddf6a: [mips][NFC] Remove unused instruction formats (authored by mstojanovic).
[mips][NFC] Remove unused instruction formats
Jan 28 2020, 4:41 AM
mstojanovic closed D73489: [mips][NFC] Remove unused instruction formats.
Jan 28 2020, 4:41 AM · Restricted Project

Jan 27 2020

mstojanovic created D73489: [mips][NFC] Remove unused instruction formats.
Jan 27 2020, 8:21 AM · Restricted Project

Jan 23 2020

mstojanovic committed rGe8fc8507dacb: [llvm-exegesis] Don't use unsupported aliasing instructions (authored by mstojanovic).
[llvm-exegesis] Don't use unsupported aliasing instructions
Jan 23 2020, 3:47 AM
mstojanovic closed D73220: [llvm-exegesis] Don't use unsupported aliasing instructions.
Jan 23 2020, 3:47 AM · Restricted Project

Jan 22 2020

mstojanovic created D73220: [llvm-exegesis] Don't use unsupported aliasing instructions.
Jan 22 2020, 12:23 PM · Restricted Project

Jan 21 2020

mstojanovic added a comment to D73108: [docs][mips] 10.0 Release notes.

Initial MIPS support was also added to llvm-exegesis.

Jan 21 2020, 8:23 AM · Restricted Project, Restricted Project
mstojanovic added a comment to D73044: {tablegen] Emit string literals instead of char arrays.

First char of the title: { -> [.

Jan 21 2020, 8:17 AM · Restricted Project
mstojanovic awarded D73044: {tablegen] Emit string literals instead of char arrays a Love token.
Jan 21 2020, 3:46 AM · Restricted Project

Jan 20 2020

mstojanovic committed rGb37f6d3af100: [llvm-exegesis] Remove unused variable after D72928 (authored by mstojanovic).
[llvm-exegesis] Remove unused variable after D72928
Jan 20 2020, 9:30 AM
mstojanovic committed rG24b7b99b7d68: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners (authored by mstojanovic).
[llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners
Jan 20 2020, 7:34 AM
mstojanovic closed D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.
Jan 20 2020, 7:34 AM · Restricted Project
mstojanovic added a comment to D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.

Ok, thank you for the review!

Jan 20 2020, 7:31 AM · Restricted Project
mstojanovic updated the diff for D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.

Added includes for vector, iota and shuffle.
Renamed writeUopsSnippetHtml() -> writeParallelSnippetHtml().

Jan 20 2020, 6:54 AM · Restricted Project
mstojanovic added inline comments to D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.
Jan 20 2020, 6:54 AM · Restricted Project

Jan 17 2020

mstojanovic updated the diff for D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.

Updated the comment.

Jan 17 2020, 8:55 AM · Restricted Project
mstojanovic added inline comments to D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.
Jan 17 2020, 8:15 AM · Restricted Project
mstojanovic created D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.
Jan 17 2020, 8:15 AM · Restricted Project
mstojanovic committed rGea91758a3c45: [llvm-exegesis][mips] Add support for memory instructions (authored by mstojanovic).
[llvm-exegesis][mips] Add support for memory instructions
Jan 17 2020, 4:28 AM
mstojanovic closed D72858: [llvm-exegesis][mips] Add support for memory instructions.
Jan 17 2020, 4:28 AM · Restricted Project

Jan 16 2020

mstojanovic created D72858: [llvm-exegesis][mips] Add support for memory instructions.
Jan 16 2020, 10:22 AM · Restricted Project
mstojanovic committed rG31458a9feecb: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class. (authored by mstojanovic).
[llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Jan 16 2020, 8:57 AM
mstojanovic committed rG6b3578664961: [llvm-exegesis][mips] Add RegisterAliasingTest unit test (authored by mstojanovic).
[llvm-exegesis][mips] Add RegisterAliasingTest unit test
Jan 16 2020, 8:57 AM
mstojanovic closed D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Jan 16 2020, 8:57 AM · Restricted Project
mstojanovic closed D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.
Jan 16 2020, 8:57 AM · Restricted Project
mstojanovic added a comment to D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.

Thank you for the review.
@atanasyan Do you have any comment?

Jan 16 2020, 8:28 AM · Restricted Project

Jan 14 2020

mstojanovic committed rGbff33bd5c83b: [unittests] Fix "comparison of integers of different signs" warnings (authored by mstojanovic).
[unittests] Fix "comparison of integers of different signs" warnings
Jan 14 2020, 4:30 AM
mstojanovic closed D72632: [unittests] Fix "comparison of integers of different signs" warnings.
Jan 14 2020, 4:30 AM · Restricted Project

Jan 13 2020

mstojanovic created D72632: [unittests] Fix "comparison of integers of different signs" warnings.
Jan 13 2020, 10:26 AM · Restricted Project
mstojanovic committed rGa70b993239a8: [llvm-exegesis] Remove unneeded std::move() (authored by mstojanovic).
[llvm-exegesis] Remove unneeded std::move()
Jan 13 2020, 5:20 AM
mstojanovic committed rG804dd6722762: [llvm-exegesis][mips] Expand loadImmediate() (authored by mstojanovic).
[llvm-exegesis][mips] Expand loadImmediate()
Jan 13 2020, 3:39 AM
mstojanovic closed D71873: [llvm-exegesis][mips] Expand loadImmediate().
Jan 13 2020, 3:38 AM · Restricted Project
mstojanovic updated the diff for D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.

Removed leftover lines.

Jan 13 2020, 3:29 AM · Restricted Project

Dec 31 2019

mstojanovic committed rGc7dc4734d23f: [llvm-exegesis] Check counters before running (authored by mstojanovic).
[llvm-exegesis] Check counters before running
Dec 31 2019, 5:23 AM
mstojanovic closed D71927: [llvm-exegesis] Check counters before running.
Dec 31 2019, 5:22 AM · Restricted Project
mstojanovic updated the diff for D71927: [llvm-exegesis] Check counters before running.

Fixed typos.
Added a check of IssueCounters.

Dec 31 2019, 3:02 AM · Restricted Project

Dec 30 2019

mstojanovic created D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.
Dec 30 2019, 7:26 AM · Restricted Project
mstojanovic created D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Dec 30 2019, 7:07 AM · Restricted Project

Dec 27 2019

mstojanovic created D71927: [llvm-exegesis] Check counters before running.
Dec 27 2019, 6:31 AM · Restricted Project

Dec 25 2019

mstojanovic added a reviewer for D71873: [llvm-exegesis][mips] Expand loadImmediate(): atanasyan.
Dec 25 2019, 3:26 AM · Restricted Project
mstojanovic created D71873: [llvm-exegesis][mips] Expand loadImmediate().
Dec 25 2019, 3:24 AM · Restricted Project

Dec 19 2019

mstojanovic committed rGd005df4c1656: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm (authored by mstojanovic).
[llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm
Dec 19 2019, 4:03 AM
mstojanovic closed D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.
Dec 19 2019, 4:02 AM · Restricted Project
mstojanovic retitled D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm from [llvm-exegesis] Fix pfm counter names for Haswell to [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.
Dec 19 2019, 3:07 AM · Restricted Project
mstojanovic added a comment to D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.

I have version 4.4.0+git47-g71166e2-1 so yes, I think this is the problem since the alias was added only after v4.6.0.

Dec 19 2019, 2:59 AM · Restricted Project

Dec 18 2019

Herald added a project to D53502: [llvm-exegesis] ExecutionMode is computed upfront for Uops as well: Restricted Project.
Dec 18 2019, 10:09 AM · Restricted Project
Herald added a project to D55001: [CMake] Fix build with -DLLVM_TOOL_LLVM_{MCA/EXEGESIS}_BUILD=OFF: Restricted Project.
Dec 18 2019, 10:09 AM · Restricted Project
Herald added a project to D54318: [WIP][llvm-exegesis] Add support for memory instructions in latency mode.: Restricted Project.
Dec 18 2019, 10:06 AM · Restricted Project
mstojanovic added a reviewer for D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm: petarj.
Dec 18 2019, 9:56 AM · Restricted Project
mstojanovic created D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.
Dec 18 2019, 9:03 AM · Restricted Project
mstojanovic committed rG862a60241687: [llvm-exegesis][mips] Add lit test (authored by mstojanovic).
[llvm-exegesis][mips] Add lit test
Dec 18 2019, 1:24 AM
mstojanovic closed D71605: [llvm-exegesis][mips] Add lit test.
Dec 18 2019, 1:24 AM · Restricted Project

Dec 17 2019

mstojanovic created D71605: [llvm-exegesis][mips] Add lit test.
Dec 17 2019, 6:10 AM · Restricted Project

Dec 16 2019

mstojanovic committed rGd7efa6b1985f: [mips] Add an assert in getTargetStreamer() (authored by mstojanovic).
[mips] Add an assert in getTargetStreamer()
Dec 16 2019, 8:06 AM
mstojanovic committed rG0add79aec2ee: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test (authored by mstojanovic).
[llvm-exegesis][mips] Add SnippetGeneratorTest unit test
Dec 16 2019, 8:06 AM
mstojanovic closed D71477: [mips] Add an assert in getTargetStreamer().
Dec 16 2019, 8:06 AM · Restricted Project
mstojanovic closed D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.
Dec 16 2019, 8:06 AM · Restricted Project
mstojanovic updated the diff for D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.

Inlined Opcode.

Dec 16 2019, 5:45 AM · Restricted Project
mstojanovic updated the summary of D71477: [mips] Add an assert in getTargetStreamer().
Dec 16 2019, 4:10 AM · Restricted Project

Dec 13 2019

mstojanovic created D71477: [mips] Add an assert in getTargetStreamer().
Dec 13 2019, 10:06 AM · Restricted Project
mstojanovic abandoned D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.
Dec 13 2019, 9:38 AM · Restricted Project
mstojanovic accepted D71468: [llvm-exegesis] Set up AsmTargetStreamer in readSnippets.

LGTM, thanks for the fix!

Dec 13 2019, 9:38 AM · Restricted Project
mstojanovic created D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.
Dec 13 2019, 8:42 AM · Restricted Project
mstojanovic committed rG84728e65e95b: [llvm-exegesis][mips] Add BenchmarkResultTest unit test (authored by mstojanovic).
[llvm-exegesis][mips] Add BenchmarkResultTest unit test
Dec 13 2019, 8:06 AM
mstojanovic closed D71265: [llvm-exegesis][mips] Add BenchmarkResultTest unit test.
Dec 13 2019, 8:06 AM · Restricted Project

Dec 12 2019

mstojanovic added a comment to D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.

@gchatelet @courbet How do you think the example I mentioned in the previous comment should be handeled on X86? This might inform us what (if anything) should be changed for MIPS.

Dec 12 2019, 7:08 AM · Restricted Project

Dec 10 2019

mstojanovic created D71265: [llvm-exegesis][mips] Add BenchmarkResultTest unit test.
Dec 10 2019, 6:23 AM · Restricted Project

Dec 9 2019

mstojanovic added a comment to D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.

Yes, other targets do have it but use it quite sparingly. X86 almost never uses it but there are some edge cases when parsing certain directives. For example, this line will trigger an assert fail because of an uninitialized TargetStreamer on X86:

echo ".cv_fpo_proc foo 4" | llvm-exegesis -mode latency -snippets-file=-

MIPS on the other hand uses TargetStreamer right at the start of the MipsAsmParser constructor and throughout the code used for parsing. The design of this MIPS code is quite different from other architectures (always relying on TargetStreamer or Assembler). I'm not sure if this was out of necessity or if it just evolved in to different path. Either way, the current code doesn't facilitate simple instruction extraction without all the necessary elements being in place.

Dec 9 2019, 7:19 AM · Restricted Project

Dec 6 2019

mstojanovic created D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.
Dec 6 2019, 11:38 AM · Restricted Project

Nov 28 2019

mstojanovic committed rGed864745c97e: [OpenMP][test] Fix test on MIPS-based buildbots (authored by mstojanovic).
[OpenMP][test] Fix test on MIPS-based buildbots
Nov 28 2019, 7:21 AM
mstojanovic closed D70820: [OpenMP][test] Fix test on MIPS-based buildbots.
Nov 28 2019, 7:21 AM · Restricted Project
mstojanovic created D70820: [OpenMP][test] Fix test on MIPS-based buildbots.
Nov 28 2019, 6:16 AM · Restricted Project

Nov 21 2019

mstojanovic committed rG6ba5cbf3ea23: [mips] Add a 'generic' Mips CPU (authored by mstojanovic).
[mips] Add a 'generic' Mips CPU
Nov 21 2019, 6:27 AM