Page MenuHomePhabricator

mstojanovic (Miloš Stojanović)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 5:05 AM (136 w, 3 d)

Recent Activity

Yesterday

mstojanovic updated the diff for D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.

Updated the comment.

Fri, Jan 17, 8:55 AM · Restricted Project
mstojanovic added inline comments to D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.
Fri, Jan 17, 8:15 AM · Restricted Project
mstojanovic created D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.
Fri, Jan 17, 8:15 AM · Restricted Project
mstojanovic committed rGea91758a3c45: [llvm-exegesis][mips] Add support for memory instructions (authored by mstojanovic).
[llvm-exegesis][mips] Add support for memory instructions
Fri, Jan 17, 4:28 AM
mstojanovic closed D72858: [llvm-exegesis][mips] Add support for memory instructions.
Fri, Jan 17, 4:28 AM · Restricted Project

Thu, Jan 16

mstojanovic created D72858: [llvm-exegesis][mips] Add support for memory instructions.
Thu, Jan 16, 10:22 AM · Restricted Project
mstojanovic committed rG31458a9feecb: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class. (authored by mstojanovic).
[llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Thu, Jan 16, 8:57 AM
mstojanovic committed rG6b3578664961: [llvm-exegesis][mips] Add RegisterAliasingTest unit test (authored by mstojanovic).
[llvm-exegesis][mips] Add RegisterAliasingTest unit test
Thu, Jan 16, 8:57 AM
mstojanovic closed D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Thu, Jan 16, 8:57 AM · Restricted Project
mstojanovic closed D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.
Thu, Jan 16, 8:57 AM · Restricted Project
mstojanovic added a comment to D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.

Thank you for the review.
@atanasyan Do you have any comment?

Thu, Jan 16, 8:28 AM · Restricted Project

Tue, Jan 14

mstojanovic committed rGbff33bd5c83b: [unittests] Fix "comparison of integers of different signs" warnings (authored by mstojanovic).
[unittests] Fix "comparison of integers of different signs" warnings
Tue, Jan 14, 4:30 AM
mstojanovic closed D72632: [unittests] Fix "comparison of integers of different signs" warnings.
Tue, Jan 14, 4:30 AM · Restricted Project

Mon, Jan 13

mstojanovic created D72632: [unittests] Fix "comparison of integers of different signs" warnings.
Mon, Jan 13, 10:26 AM · Restricted Project
mstojanovic committed rGa70b993239a8: [llvm-exegesis] Remove unneeded std::move() (authored by mstojanovic).
[llvm-exegesis] Remove unneeded std::move()
Mon, Jan 13, 5:20 AM
mstojanovic committed rG804dd6722762: [llvm-exegesis][mips] Expand loadImmediate() (authored by mstojanovic).
[llvm-exegesis][mips] Expand loadImmediate()
Mon, Jan 13, 3:39 AM
mstojanovic closed D71873: [llvm-exegesis][mips] Expand loadImmediate().
Mon, Jan 13, 3:38 AM · Restricted Project
mstojanovic updated the diff for D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.

Removed leftover lines.

Mon, Jan 13, 3:29 AM · Restricted Project

Tue, Dec 31

mstojanovic committed rGc7dc4734d23f: [llvm-exegesis] Check counters before running (authored by mstojanovic).
[llvm-exegesis] Check counters before running
Tue, Dec 31, 5:23 AM
mstojanovic closed D71927: [llvm-exegesis] Check counters before running.
Tue, Dec 31, 5:22 AM · Restricted Project
mstojanovic updated the diff for D71927: [llvm-exegesis] Check counters before running.

Fixed typos.
Added a check of IssueCounters.

Tue, Dec 31, 3:02 AM · Restricted Project

Mon, Dec 30

mstojanovic added a parent revision for D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test: D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Mon, Dec 30, 7:54 AM · Restricted Project
mstojanovic added a child revision for D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class: D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.
Mon, Dec 30, 7:54 AM · Restricted Project
mstojanovic created D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.
Mon, Dec 30, 7:26 AM · Restricted Project
mstojanovic created D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Mon, Dec 30, 7:07 AM · Restricted Project

Fri, Dec 27

mstojanovic created D71927: [llvm-exegesis] Check counters before running.
Fri, Dec 27, 6:31 AM · Restricted Project

Wed, Dec 25

mstojanovic added a reviewer for D71873: [llvm-exegesis][mips] Expand loadImmediate(): atanasyan.
Wed, Dec 25, 3:26 AM · Restricted Project
mstojanovic created D71873: [llvm-exegesis][mips] Expand loadImmediate().
Wed, Dec 25, 3:24 AM · Restricted Project

Dec 19 2019

mstojanovic committed rGd005df4c1656: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm (authored by mstojanovic).
[llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm
Dec 19 2019, 4:03 AM
mstojanovic closed D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.
Dec 19 2019, 4:02 AM · Restricted Project
mstojanovic retitled D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm from [llvm-exegesis] Fix pfm counter names for Haswell to [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.
Dec 19 2019, 3:07 AM · Restricted Project
mstojanovic added a comment to D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.

I have version 4.4.0+git47-g71166e2-1 so yes, I think this is the problem since the alias was added only after v4.6.0.

Dec 19 2019, 2:59 AM · Restricted Project

Dec 18 2019

Herald added a project to D53502: [llvm-exegesis] ExecutionMode is computed upfront for Uops as well: Restricted Project.
Dec 18 2019, 10:09 AM · Restricted Project
Herald added a project to D55001: [CMake] Fix build with -DLLVM_TOOL_LLVM_{MCA/EXEGESIS}_BUILD=OFF: Restricted Project.
Dec 18 2019, 10:09 AM · Restricted Project
Herald added a project to D54318: [WIP][llvm-exegesis] Add support for memory instructions in latency mode.: Restricted Project.
Dec 18 2019, 10:06 AM · Restricted Project
mstojanovic added a reviewer for D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm: petarj.
Dec 18 2019, 9:56 AM · Restricted Project
mstojanovic created D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.
Dec 18 2019, 9:03 AM · Restricted Project
mstojanovic committed rG862a60241687: [llvm-exegesis][mips] Add lit test (authored by mstojanovic).
[llvm-exegesis][mips] Add lit test
Dec 18 2019, 1:24 AM
mstojanovic closed D71605: [llvm-exegesis][mips] Add lit test.
Dec 18 2019, 1:24 AM · Restricted Project

Dec 17 2019

mstojanovic created D71605: [llvm-exegesis][mips] Add lit test.
Dec 17 2019, 6:10 AM · Restricted Project

Dec 16 2019

mstojanovic committed rGd7efa6b1985f: [mips] Add an assert in getTargetStreamer() (authored by mstojanovic).
[mips] Add an assert in getTargetStreamer()
Dec 16 2019, 8:06 AM
mstojanovic committed rG0add79aec2ee: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test (authored by mstojanovic).
[llvm-exegesis][mips] Add SnippetGeneratorTest unit test
Dec 16 2019, 8:06 AM
mstojanovic closed D71477: [mips] Add an assert in getTargetStreamer().
Dec 16 2019, 8:06 AM · Restricted Project
mstojanovic closed D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.
Dec 16 2019, 8:06 AM · Restricted Project
mstojanovic updated the diff for D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.

Inlined Opcode.

Dec 16 2019, 5:45 AM · Restricted Project
mstojanovic updated the summary of D71477: [mips] Add an assert in getTargetStreamer().
Dec 16 2019, 4:10 AM · Restricted Project

Dec 13 2019

mstojanovic created D71477: [mips] Add an assert in getTargetStreamer().
Dec 13 2019, 10:06 AM · Restricted Project
mstojanovic abandoned D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.
Dec 13 2019, 9:38 AM · Restricted Project
mstojanovic accepted D71468: [llvm-exegesis] Set up AsmTargetStreamer in readSnippets.

LGTM, thanks for the fix!

Dec 13 2019, 9:38 AM · Restricted Project
mstojanovic created D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.
Dec 13 2019, 8:42 AM · Restricted Project
mstojanovic committed rG84728e65e95b: [llvm-exegesis][mips] Add BenchmarkResultTest unit test (authored by mstojanovic).
[llvm-exegesis][mips] Add BenchmarkResultTest unit test
Dec 13 2019, 8:06 AM
mstojanovic closed D71265: [llvm-exegesis][mips] Add BenchmarkResultTest unit test.
Dec 13 2019, 8:06 AM · Restricted Project

Dec 12 2019

mstojanovic added a comment to D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.

@gchatelet @courbet How do you think the example I mentioned in the previous comment should be handeled on X86? This might inform us what (if anything) should be changed for MIPS.

Dec 12 2019, 7:08 AM · Restricted Project

Dec 10 2019

mstojanovic created D71265: [llvm-exegesis][mips] Add BenchmarkResultTest unit test.
Dec 10 2019, 6:23 AM · Restricted Project

Dec 9 2019

mstojanovic added a comment to D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.

Yes, other targets do have it but use it quite sparingly. X86 almost never uses it but there are some edge cases when parsing certain directives. For example, this line will trigger an assert fail because of an uninitialized TargetStreamer on X86:

echo ".cv_fpo_proc foo 4" | llvm-exegesis -mode latency -snippets-file=-

MIPS on the other hand uses TargetStreamer right at the start of the MipsAsmParser constructor and throughout the code used for parsing. The design of this MIPS code is quite different from other architectures (always relying on TargetStreamer or Assembler). I'm not sure if this was out of necessity or if it just evolved in to different path. Either way, the current code doesn't facilitate simple instruction extraction without all the necessary elements being in place.

Dec 9 2019, 7:19 AM · Restricted Project

Dec 6 2019

mstojanovic created D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.
Dec 6 2019, 11:38 AM · Restricted Project

Nov 28 2019

mstojanovic committed rGed864745c97e: [OpenMP][test] Fix test on MIPS-based buildbots (authored by mstojanovic).
[OpenMP][test] Fix test on MIPS-based buildbots
Nov 28 2019, 7:21 AM
mstojanovic closed D70820: [OpenMP][test] Fix test on MIPS-based buildbots.
Nov 28 2019, 7:21 AM · Restricted Project
mstojanovic created D70820: [OpenMP][test] Fix test on MIPS-based buildbots.
Nov 28 2019, 6:16 AM · Restricted Project

Nov 21 2019

mstojanovic committed rG6ba5cbf3ea23: [mips] Add a 'generic' Mips CPU (authored by mstojanovic).
[mips] Add a 'generic' Mips CPU
Nov 21 2019, 6:27 AM
mstojanovic closed D70490: [mips] Add a 'generic' Mips CPU.
Nov 21 2019, 6:27 AM · Restricted Project
mstojanovic added a comment to D70490: [mips] Add a 'generic' Mips CPU.

It's possible to run some tests manually but the test mentioned above, which will be part of lit.local.cfg and which checks whether lit can run llvm-exegesis tests on Mips, is encountering a segfault so I'm working on fixing that first.

Nov 21 2019, 5:59 AM · Restricted Project
mstojanovic updated the diff for D70490: [mips] Add a 'generic' Mips CPU.

I came across this while running llvm-exegesis on a mips board, e.g.:

llvm-exegesis -mode latency -snippets-file /dev/null

It gets the 'generic' CPU name with sys::getHostCPUName() and calls createTargetMachine(), which then emits a warning:

'generic' is not a recognized processor for this target (ignoring processor)
Nov 21 2019, 5:02 AM · Restricted Project

Nov 20 2019

mstojanovic created D70490: [mips] Add a 'generic' Mips CPU.
Nov 20 2019, 6:46 AM · Restricted Project

Nov 15 2019

mstojanovic accepted D70201: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI.

LGTM

Nov 15 2019, 5:37 AM · Restricted Project

Nov 14 2019

mstojanovic committed rG4787c6e2f31e: [mips][NFC] Remove old FIXME comment (authored by mstojanovic).
[mips][NFC] Remove old FIXME comment
Nov 14 2019, 4:29 AM
mstojanovic closed D70231: [mips][NFC] Remove old FIXME comment.
Nov 14 2019, 4:28 AM · Restricted Project
mstojanovic created D70231: [mips][NFC] Remove old FIXME comment.
Nov 14 2019, 3:47 AM · Restricted Project

Nov 13 2019

mstojanovic added a comment to D70017: [mips][test] Add Mips CPU tests.

Thanks for the review. I forgot to mention that I've gotten commit access in meantime so I'll be able to commit future patches.

Nov 13 2019, 3:10 AM · Restricted Project

Nov 12 2019

mstojanovic updated the diff for D70017: [mips][test] Add Mips CPU tests.

Merged and expanded the test.

Nov 12 2019, 7:22 AM · Restricted Project
mstojanovic updated the diff for D70018: [mips][test] Check if the subtarget can support the requested triple width.

Shortened the tests.

Nov 12 2019, 7:22 AM · Restricted Project

Nov 8 2019

mstojanovic created D70018: [mips][test] Check if the subtarget can support the requested triple width.
Nov 8 2019, 10:26 AM · Restricted Project
mstojanovic created D70017: [mips][test] Add Mips CPU tests.
Nov 8 2019, 10:17 AM · Restricted Project

Nov 6 2019

mstojanovic committed rG4601df7d6ac5: [NFC][APInt] Fix typos in comments. (authored by mstojanovic).
[NFC][APInt] Fix typos in comments.
Nov 6 2019, 7:13 AM

Oct 24 2019

mstojanovic updated the diff for D69381: [docs] Update Mips feature table in CodeGenerator.rst.

I agree that yes is fine. Even though it's not enabled but default it's still usable and is in the spirit that the table defines.

Oct 24 2019, 7:25 AM · Restricted Project
mstojanovic updated the diff for D69380: [docs] Add Mips as a supported architecture in GettingStarted.rst.

Added full context to the diff.

Oct 24 2019, 6:03 AM · Restricted Project
mstojanovic added a comment to D69381: [docs] Update Mips feature table in CodeGenerator.rst.

I'm not certain if the tail calls should be marked as partial or if they can be considered supported.

Oct 24 2019, 6:03 AM · Restricted Project
mstojanovic created D69381: [docs] Update Mips feature table in CodeGenerator.rst.
Oct 24 2019, 6:03 AM · Restricted Project
mstojanovic created D69380: [docs] Add Mips as a supported architecture in GettingStarted.rst.
Oct 24 2019, 5:51 AM · Restricted Project
mstojanovic added a reviewer for D69377: [docs] Update link to the MIPS 64-bit ELF object file specification: petarj.
Oct 24 2019, 5:16 AM · Restricted Project
mstojanovic created D69377: [docs] Update link to the MIPS 64-bit ELF object file specification.
Oct 24 2019, 5:16 AM · Restricted Project

Oct 11 2019

mstojanovic accepted D68778: [mips] Store 64-bit `li.d' operand as a single 8-byte value.

LGTM

Oct 11 2019, 6:22 AM · Restricted Project
mstojanovic accepted D68777: [mips] Use less instruction to load zero into FPR by li.s / li.d pseudos.

LGTM

Oct 11 2019, 6:12 AM · Restricted Project

Oct 10 2019

mstojanovic accepted D68776: [mips] Fix loading "double" immediate into a GPR and FPR.

LGTM, just have some clarifying questions.

Oct 10 2019, 9:47 AM · Restricted Project
mstojanovic added a comment to D68649: [Mips][llvm-exegesis] Add a Mips target.

Thank you for the reviews. I don't have commit access. @petarj usually commits the patches.

Oct 10 2019, 4:14 AM · Restricted Project

Oct 9 2019

mstojanovic updated the diff for D68649: [Mips][llvm-exegesis] Add a Mips target.

Removed obsolete llvm:: and includes, ran clang-format. Added direct testing of the instruction.

Oct 9 2019, 11:08 AM · Restricted Project

Oct 8 2019

mstojanovic created D68649: [Mips][llvm-exegesis] Add a Mips target.
Oct 8 2019, 8:16 AM · Restricted Project

Aug 19 2019

mstojanovic added inline comments to D66202: [MIPS GlobalISel] NarrowScalar G_TRUNC .
Aug 19 2019, 2:48 AM · Restricted Project

Jul 26 2019

mstojanovic added a comment to D6016: [mips] MIPS BEQZL and BNEZL instructions.

Should we also add the (dis)assembler tests or are these case covered in other tests?

Jul 26 2019, 9:30 AM

Jul 15 2019

mstojanovic added a comment to D6016: [mips] MIPS BEQZL and BNEZL instructions.

Maybe we should add the tests that this patch had since they were not added in rL234401.
rL234401 also disabled printing of the alias instruction while it's enabled in here. Not sure which one is preferable.

Jul 15 2019, 9:36 AM

Jun 18 2019

mstojanovic added inline comments to D60698: [ARM] add target arch definitions for 8.1-M and MVE..
Jun 18 2019, 9:31 AM · Restricted Project

May 21 2019

mstojanovic added inline comments to D62166: [mips] Always check that `shift and add` optimization is efficient.
May 21 2019, 5:06 AM · Restricted Project

Apr 25 2019

mstojanovic added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Apr 25 2019, 9:20 AM · Restricted Project
mstojanovic added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Apr 25 2019, 7:06 AM · Restricted Project
mstojanovic added a comment to D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS.

Ping

Apr 25 2019, 3:21 AM · Restricted Project
mstojanovic added a reviewer for D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS: atanasyan.
Apr 25 2019, 3:21 AM · Restricted Project
mstojanovic added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Apr 25 2019, 2:29 AM · Restricted Project

Apr 24 2019

mstojanovic added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Apr 24 2019, 10:16 AM · Restricted Project

Apr 3 2019

mstojanovic created D60198: [TextAPI] Fix off-by-one error in the bit index extraction loop.
Apr 3 2019, 6:31 AM · Restricted Project

Mar 28 2019

Herald added a project to D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS: Restricted Project.
Mar 28 2019, 4:09 AM · Restricted Project