Page MenuHomePhabricator

[X86] Improve lowering of fptoui
ClosedPublic

Authored by laytonio on Nov 2 2020, 5:42 PM.

Details

Summary

Invert the select condition when masking in the sign bit of a fptoui operation. Also, rather than lowering the sign mask to select/xor and expecting the select to get cleaned up later, directly lower to shift/xor.

Diff Detail

Event Timeline

laytonio created this revision.Nov 2 2020, 5:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2020, 5:42 PM
laytonio requested review of this revision.Nov 2 2020, 5:42 PM

Prevents some regressions is D90113

This revision is now accepted and ready to land.Nov 3 2020, 7:01 PM
laytonio updated this revision to Diff 302742.Nov 3 2020, 10:04 PM

Rebase after rG40f7ac1a8f61

Thanks for the review! Could you commit this for me? Layton Kifer <laytonkifer@gmail.com>

This revision was automatically updated to reflect the committed changes.