Page MenuHomePhabricator

laytonio (Layton Kifer)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2020, 5:28 PM (5 w, 5 d)

Recent Activity

Sat, May 16

laytonio added a comment to D79660: [TRE] Allow elimination when the returned value is non-constant.

Thank you. I appreciate the help.

Sat, May 16, 2:17 PM · Restricted Project

Fri, May 15

laytonio updated the diff for D79660: [TRE] Allow elimination when the returned value is non-constant.

Address comments. Added a test for multiple eliminations.

Fri, May 15, 3:47 PM · Restricted Project

Fri, May 8

laytonio created D79660: [TRE] Allow elimination when the returned value is non-constant.
Fri, May 8, 7:53 PM · Restricted Project

Tue, May 5

laytonio added a comment to D79299: [TRE][NFC] Refactor shared state into member variables..

Name and email would be great. Thank you.

Tue, May 5, 7:26 PM · Restricted Project
laytonio updated the diff for D79299: [TRE][NFC] Refactor shared state into member variables..

Whoops, deleted one to many static keywords.

Tue, May 5, 2:03 PM · Restricted Project
laytonio updated the diff for D79299: [TRE][NFC] Refactor shared state into member variables..

Nevermind, I'm an idiot.

Tue, May 5, 2:03 PM · Restricted Project
laytonio updated the diff for D79299: [TRE][NFC] Refactor shared state into member variables..

Ah, I misunderstood, fixed now.

Tue, May 5, 2:03 PM · Restricted Project

Mon, May 4

laytonio added a comment to D79299: [TRE][NFC] Refactor shared state into member variables..

In general I agree that keeping mutable state in the class like this is not optimal. In this case though, I do believe it is better than needing to trace the variable up though several functions to find were it is declared, when in is only used in the bottom few functions. I added a comment stating that these variables are populated in createTailRecurseLoopHeader to hopefully make them a little easier to understand. As for moving the functions out of the class, I was trying to avoid cluttering the code with a bunch of "TRE->" everywhere, but if we think it is cleaner to have this be a struct that is passes around instead of a class with member functions, I am okay with that.

Mon, May 4, 5:13 PM · Restricted Project
laytonio updated the diff for D79299: [TRE][NFC] Refactor shared state into member variables..

Added anonymous namespace. Renamed two variables to be more clear. Added some comments.

Mon, May 4, 5:13 PM · Restricted Project

Sat, May 2

laytonio created D79299: [TRE][NFC] Refactor shared state into member variables..
Sat, May 2, 5:29 PM · Restricted Project
laytonio abandoned D78259: [TailCallElim] Add handling of readonly functions.
Sat, May 2, 3:54 PM · Restricted Project

Wed, Apr 29

laytonio updated the diff for D78765: [TRE] Fix bug in handling of switch statements.

I have gotten a version of this that does the accumulation at the end mostly working. I will finish cleaning it up and try to split it into a few different patches as I reworked a fair bit, and found a few addition improvements I think we can make. I went ahead and updated this diff in case we want to consider it a first step of incremental improvement.

Wed, Apr 29, 9:05 PM · Restricted Project

Mon, Apr 27

laytonio added a comment to D78765: [TRE] Fix bug in handling of switch statements.

I'm trying this approach now, but I'm having a hard time seeing a good way to transform this case:

Mon, Apr 27, 7:30 AM · Restricted Project

Apr 24 2020

laytonio added a comment to D78765: [TRE] Fix bug in handling of switch statements.

Suppose, instead, the accumulator always starts at zero.

Apr 24 2020, 6:25 PM · Restricted Project
laytonio added inline comments to D78765: [TRE] Fix bug in handling of switch statements.
Apr 24 2020, 3:44 PM · Restricted Project
laytonio updated the diff for D78765: [TRE] Fix bug in handling of switch statements.

This now fixes both repos of the crash. I removed a test that relied on the bug and actually didn't produce valid output. Added the case with a single branch as a test case. However, all this switch handling really does is propagate a constant. Maybe we should remove it entirely and expect that the constant propagation passes do this for us.

Apr 24 2020, 3:44 PM · Restricted Project

Apr 23 2020

laytonio added inline comments to D78259: [TailCallElim] Add handling of readonly functions.
Apr 23 2020, 3:47 PM · Restricted Project
laytonio created D78765: [TRE] Fix bug in handling of switch statements.
Apr 23 2020, 3:47 PM · Restricted Project

Apr 15 2020

laytonio created D78259: [TailCallElim] Add handling of readonly functions.
Apr 15 2020, 6:14 PM · Restricted Project
laytonio updated the diff for D78259: [TailCallElim] Add handling of readonly functions.

noticed minor typo in the regression test

Apr 15 2020, 6:14 PM · Restricted Project