[clangd] Fix ParsedASTTest.TopLevelDecls test.

[ilya-golovenko]

Summary

Google test matcher DeclKind uses NamedDecl::getDeclKindName() to compare its result with expected declaration name.
Both, returned value of this function and the expected kind name argument have type const char *, so this matcher effectively
compares two pointers instead of the respective strings.

The test was passing on most platforms because compilers mostly were able to coalesce these string literals.

[hokein]

Great! Thanks for doing this!

[ilya-golovenko]

@hokein I don't have commit access. Could you please commit it on my behalf?
Ilya Golovenko <[e-mail]>

clang-tools-extra/clangd/unittests/ParsedASTTests.cpp

if (auto *Stream = result_listener->stream()) {
     llvm::raw_os_ostream OS(*Stream);
     arg->dump(OS);
   }
   return false;
 }
 
 MATCHER_P(DeclKind, Kind, "") {
   if (NamedDecl *ND = dyn_cast<NamedDecl>(arg))
-    if (ND->getDeclKindName() == Kind)
+    if (ND->getDeclKindName() == llvm::StringRef(Kind))
       return true;
   if (auto *Stream = result_listener->stream()) {
     llvm::raw_os_ostream OS(*Stream);
     arg->dump(OS);
   }
   return false;
 }
 

 
 MATCHER(EqInc, "") {
   Inclusion Actual = testing::get<0>(arg);
   Inclusion Expected = testing::get<1>(arg);
   return std::tie(Actual.HashLine, Actual.Written) ==
          std::tie(Expected.HashLine, Expected.Written);
 }
 
-// FIXME: figure out why it fails on clang-ppc64le-rhel buildbot.
-TEST(ParsedASTTest, DISABLED_TopLevelDecls) {
+TEST(ParsedASTTest, TopLevelDecls) {
   TestTU TU;
   TU.HeaderCode = R"(
     int header1();
     int header2;
   )";
   TU.Code = R"cpp(
     int main();
     template <typename> bool X = true;