Page MenuHomePhabricator

ilya-golovenko (Ilya Golovenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2020, 4:29 AM (95 w, 5 d)

Recent Activity

Jan 15 2021

ilya-golovenko committed rG9cc221b99bec: [clangd] exclude symbols from document outline which do not originate from the… (authored by ilya-golovenko).
[clangd] exclude symbols from document outline which do not originate from the…
Jan 15 2021, 3:02 AM
ilya-golovenko closed D94753: [clangd] exclude symbols from document outline which do not originate from the main file.
Jan 15 2021, 3:02 AM · Restricted Project
ilya-golovenko added a comment to D94753: [clangd] exclude symbols from document outline which do not originate from the main file.

btw, do you have commit access or should i land this for you ? (if so please provide your email)

Jan 15 2021, 2:32 AM · Restricted Project
ilya-golovenko added a comment to D94753: [clangd] exclude symbols from document outline which do not originate from the main file.

@kadircet Thank you for review!

Jan 15 2021, 2:10 AM · Restricted Project
ilya-golovenko updated the diff for D94753: [clangd] exclude symbols from document outline which do not originate from the main file.

Update existing test and remove redundant one

Jan 15 2021, 1:58 AM · Restricted Project

Jan 14 2021

ilya-golovenko added reviewers for D94753: [clangd] exclude symbols from document outline which do not originate from the main file: sammccall, kadircet.
Jan 14 2021, 11:50 PM · Restricted Project
ilya-golovenko requested review of D94753: [clangd] exclude symbols from document outline which do not originate from the main file.
Jan 14 2021, 11:47 PM · Restricted Project

Dec 3 2020

ilya-golovenko added a comment to D92484: [clangd] Relation slabs should not be accounted when computing backing storage size.

Thanks, you're right. There's no "payload" memory here, and MemIndex::estimateMemoryUsage should already be accounting for all the memory used.

(Sorry, it's been a while since I looked at this code)

Dec 3 2020, 5:23 AM · Restricted Project
ilya-golovenko added a reviewer for D92484: [clangd] Relation slabs should not be accounted when computing backing storage size: nridge.
Dec 3 2020, 4:34 AM · Restricted Project
ilya-golovenko added a comment to D92484: [clangd] Relation slabs should not be accounted when computing backing storage size.

Can you give a little context? Why not?

Dec 3 2020, 4:33 AM · Restricted Project

Dec 2 2020

ilya-golovenko retitled D92484: [clangd] Relation slabs should not be accounted when computing backing storage size from [clangd] Relations should not be accounted when computing backing storage size to [clangd] Relation slabs should not be accounted when computing backing storage size.
Dec 2 2020, 7:11 AM · Restricted Project
ilya-golovenko requested review of D92484: [clangd] Relation slabs should not be accounted when computing backing storage size.
Dec 2 2020, 7:08 AM · Restricted Project

Nov 5 2020

ilya-golovenko added a comment to D90116: [llvm] CMake: Force MSVC to read code as UTF-8.
Nov 5 2020, 4:41 AM · Restricted Project, Restricted Project

Oct 29 2020

ilya-golovenko added a comment to D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test..

@hokein I don't have commit access. Could you please commit it on my behalf?
Ilya Golovenko <ilya.golovenko@huawei.com>

Oct 29 2020, 6:42 AM · Restricted Project
ilya-golovenko updated the summary of D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test..
Oct 29 2020, 5:41 AM · Restricted Project
ilya-golovenko updated the summary of D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test..
Oct 29 2020, 4:49 AM · Restricted Project
ilya-golovenko updated the summary of D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test..
Oct 29 2020, 4:49 AM · Restricted Project
ilya-golovenko added reviewers for D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.: kadircet, hokein, sammccall.
Oct 29 2020, 4:45 AM · Restricted Project
ilya-golovenko requested review of D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test..
Oct 29 2020, 4:42 AM · Restricted Project

Sep 12 2020

ilya-golovenko abandoned D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..
Sep 12 2020, 5:15 AM · Restricted Project

Aug 5 2020

ilya-golovenko added a comment to D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..

I agree the fix is not correct. I will check how it currently works with clangd built from master branch.

Aug 5 2020, 7:56 AM · Restricted Project

Aug 4 2020

ilya-golovenko updated the summary of D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..
Aug 4 2020, 3:39 PM · Restricted Project
ilya-golovenko added reviewers for D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.: kadircet, sammccall.

I'm not quite sure my fix is the best way to fix the issue, so any advices are appreciated.

Aug 4 2020, 3:38 PM · Restricted Project
ilya-golovenko requested review of D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..
Aug 4 2020, 3:35 PM · Restricted Project

Aug 1 2020

ilya-golovenko added a comment to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

thanks, lgtm!

let me know if i should land this for you

Aug 1 2020, 1:21 PM · Restricted Project

Jul 31 2020

ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Simplify logic in traverseDecl method

Jul 31 2020, 9:02 AM · Restricted Project
ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Remove invalid comment

Jul 31 2020, 5:14 AM · Restricted Project
ilya-golovenko added a comment to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

@kadircet I decided to add OnlyChildren to enum VisitKind instead of making a VisitKindSet - this helped to minimize the changes in shouldVisit(). What do you think?

Jul 31 2020, 5:13 AM · Restricted Project
ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Changes afte code review, add test for export context

Jul 31 2020, 5:11 AM · Restricted Project

Jul 29 2020

ilya-golovenko added inline comments to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..
Jul 29 2020, 7:07 AM · Restricted Project
ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Trigger new build

Jul 29 2020, 5:57 AM · Restricted Project
ilya-golovenko added reviewers for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".: kadircet, sammccall.
Jul 29 2020, 5:42 AM · Restricted Project
ilya-golovenko requested review of D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..
Jul 29 2020, 5:41 AM · Restricted Project

Jul 22 2020

ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

@kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account...
By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?

Not that I'm aware of :( I have way too many accounts myself, I'd be interested in that, too. I think not having your email associated with it anymore would be good.

Hopefully, reviews move to GitHub at some point and this will not be necessary.

Jul 22 2020, 4:47 AM · Restricted Project
ilya-golovenko updated subscribers of D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

@kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account...
By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?

Jul 22 2020, 4:12 AM · Restricted Project
ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

@sammccall sorry for bothering you, could you please land this for me?

Jul 22 2020, 2:33 AM · Restricted Project

Jul 20 2020

ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

Thanks! Do you have commit access, or should I land this for you?

Jul 20 2020, 9:16 PM · Restricted Project
ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

Thanks for doing this! And sorry about the shaky windows support...

(There are potentially other lurking issues due to filenames being used as keys internally, particularly case-insensitivity issues...)

Jul 20 2020, 9:11 AM · Restricted Project
ilya-golovenko added inline comments to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..
Jul 20 2020, 9:06 AM · Restricted Project
ilya-golovenko updated the diff for D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

Address code review comments.

Jul 20 2020, 9:05 AM · Restricted Project
ilya-golovenko added reviewers for D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.: sammccall, kadircet.
Jul 20 2020, 7:35 AM · Restricted Project
Herald added a project to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.: Restricted Project.
Jul 20 2020, 7:31 AM · Restricted Project
ilya-golovenko abandoned D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..
Jul 20 2020, 7:12 AM · Restricted Project, Restricted Project
ilya-golovenko updated the diff for D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..

Consistent naming: hasDriveLetter => isWindowsPath

Jul 20 2020, 7:11 AM · Restricted Project, Restricted Project
ilya-golovenko removed a reviewer for D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.: walrus.
Jul 20 2020, 6:57 AM · Restricted Project, Restricted Project
ilya-golovenko commandeered D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..
Jul 20 2020, 6:55 AM · Restricted Project, Restricted Project
ilya-golovenko updated the diff for D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..

Consistent naming: Name => Path

Jul 20 2020, 6:34 AM · Restricted Project, Restricted Project
ilya-golovenko updated the summary of D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..
Jul 20 2020, 5:16 AM · Restricted Project, Restricted Project
ilya-golovenko added a comment to D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..

This is an attempt to improve handling of Windows UNC paths in clangd. Any feedback is appreciated.

Jul 20 2020, 5:11 AM · Restricted Project, Restricted Project
ilya-golovenko added a project to D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.: Restricted Project.
Jul 20 2020, 5:09 AM · Restricted Project, Restricted Project