Change Details

Google test matcher `DeclKind` uses `NamedDecl::getDeclKindName()` to compare with expected declaration name. Both, returned value of this function and the expected kind name argument have type `const char *`, so this matcher effectively compares two pointers instead of respective strings. The test was passing on most platforms because compilers were able to coalesce these string literals.

Google test matcher `DeclKind` uses `NamedDecl::getDeclKindName()` to compare with expected declaration name. Both, returned value of this function and the expected kind name argument have type `const char *`, so this matcher effectively compares two pointers instead of the respective strings. The test was passing on most platforms because compilers were able to coalesce these string literals.

Google test matcher `DeclKind` uses `NamedDecl::getDeclKindName()` to compare with expected declaration name. Both, returned value of this function and the expected kind name argument have type `const char *`, so this matcher effectively compares two pointers instead of the respective strings. The test was passing on most platforms because compilers were able to coalesce these string literals.