This is an archive of the discontinued LLVM Phabricator instance.

Differential D90213

[PowerPC] [Clang] Enable float128 feature on P9 by default
ClosedPublic

Authored by qiucf on Oct 27 2020, 2:24 AM.

Details

Reviewers
echristo
stefanp
nemanjai
jsji
steven.zhang
Group Reviewers
Restricted Project
Commits
rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default
Summary

As Power9 introduced hardware support for IEEE quad-precision FP type, the feature should be enabled by default on Power9 or newer targets.

And as I saw, GCC also enables the feature for all VSX-enabled targets (Power7 and Power8). If we want to align with GCC behaviors about FP128, we'd also do that after fixing f128 libcalls' calling convention issue.

Diff Detail

Unit TestsFailed

TimeTest
410 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

qiucf created this revision.Oct 27 2020, 2:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2020, 2:24 AM
Herald added subscribers: cfe-commits, dexonsmith, shchenz, kbarton. · View Herald Transcript
qiucf requested review of this revision.Oct 27 2020, 2:24 AM
Harbormaster completed remote builds in B76518: Diff 300919.Oct 27 2020, 3:01 AM
qiucf added a comment.Dec 7 2020, 12:34 AM

Ping..

steven.zhang accepted this revision.Dec 7 2020, 1:26 AM

LGTM as it seems the missing part. Please also fix the error message if with Power8.

This revision is now accepted and ready to land.Dec 7 2020, 1:26 AM
This revision was landed with ongoing or failed builds.Dec 7 2020, 2:38 AM
Closed by commit rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default (authored by qiucf). · Explain Why
This revision was automatically updated to reflect the committed changes.
qiucf added a commit: rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default.
qiucf added a parent revision: D91331: Expand the fp_to_int/int_to_fp/fp_round/fp_extend as libcall for fp128.Dec 7 2020, 9:54 PM
qiucf removed a parent revision: D91331: Expand the fp_to_int/int_to_fp/fp_round/fp_extend as libcall for fp128.

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
3 lines
test/
Driver/
4 lines

Diff 300919

clang/lib/Basic/Targets/PPC.cpp

Show First 20 Lines • Show All 307 Lines • ▼ Show 20 Lines Features["vsx"] = llvm::StringSwitch<bool>(CPU)
.Case("pwr8", true) .Case("pwr8", true)
.Case("pwr7", true) .Case("pwr7", true)
.Default(false); .Default(false);
Features["htm"] = llvm::StringSwitch<bool>(CPU) Features["htm"] = llvm::StringSwitch<bool>(CPU)
.Case("ppc64le", true) .Case("ppc64le", true)
.Case("pwr9", true) .Case("pwr9", true)
.Case("pwr8", true) .Case("pwr8", true)
.Default(false); .Default(false);
Features["float128"] = llvm::StringSwitch<bool>(CPU)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  Features["float128"] = llvm::StringSwitch<bool>(CPU)
-                        .Case("pwr9", true)
-                        .Default(false);
+  Features["float128"] =
+      llvm::StringSwitch<bool>(CPU).Case("pwr9", true).Default(false);
Lint: Pre-merge checks: clang-format: please reformat the code ``` - Features["float128"] = llvm::StringSwitch<bool>…
.Case("pwr9", true)
.Default(false);
Features["spe"] = llvm::StringSwitch<bool>(CPU) Features["spe"] = llvm::StringSwitch<bool>(CPU)
.Case("8548", true) .Case("8548", true)
.Case("e500", true) .Case("e500", true)
.Default(false); .Default(false);
// Power10 includes all the same features as Power9 plus any features specific // Power10 includes all the same features as Power9 plus any features specific
// to the Power10 core. // to the Power10 core.
▲ Show 20 Lines • Show All 220 Lines • Show Last 20 Lines

clang/test/Driver/ppc-f128-support-check.c

// RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \ // RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \
// RUN: -mcpu=pwr9 -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=HASF128 // RUN: -mcpu=pwr9 %s 2>&1 | FileCheck %s --check-prefix=HASF128
// RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \ // RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \
// RUN: -mcpu=power9 -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=HASF128 // RUN: -mcpu=power9 %s 2>&1 | FileCheck %s --check-prefix=HASF128
// RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \ // RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \
// RUN: -mcpu=pwr8 -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=NOF128 // RUN: -mcpu=pwr8 -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=NOF128
// RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \ // RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \
// RUN: -mcpu=pwr7 -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=NOF128 // RUN: -mcpu=pwr7 -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=NOF128
// RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \ // RUN: not %clang -target powerpc64le-unknown-linux-gnu -fsyntax-only \
// RUN: -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=NOF128 // RUN: -mfloat128 %s 2>&1 | FileCheck %s --check-prefix=NOF128
#ifdef __FLOAT128__ #ifdef __FLOAT128__
static_assert(false, "__float128 enabled"); static_assert(false, "__float128 enabled");
#endif #endif
// HASF128: __float128 enabled // HASF128: __float128 enabled
// HASF128-NOT: option '-mfloat128' cannot be specified with // HASF128-NOT: option '-mfloat128' cannot be specified with
// NOF128: option '-mfloat128' cannot be specified with // NOF128: option '-mfloat128' cannot be specified with