This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] [Clang] Enable float128 feature on P9 by default
ClosedPublic

Authored by qiucf on Oct 27 2020, 2:24 AM.

Details

Summary

As Power9 introduced hardware support for IEEE quad-precision FP type, the feature should be enabled by default on Power9 or newer targets.

And as I saw, GCC also enables the feature for all VSX-enabled targets (Power7 and Power8). If we want to align with GCC behaviors about FP128, we'd also do that after fixing f128 libcalls' calling convention issue.

Diff Detail

Event Timeline

qiucf created this revision.Oct 27 2020, 2:24 AM
qiucf requested review of this revision.Oct 27 2020, 2:24 AM
steven.zhang accepted this revision.Dec 7 2020, 1:26 AM

LGTM as it seems the missing part. Please also fix the error message if with Power8.

This revision is now accepted and ready to land.Dec 7 2020, 1:26 AM
This revision was landed with ongoing or failed builds.Dec 7 2020, 2:38 AM
This revision was automatically updated to reflect the committed changes.