[RISCV] [TableGen] Modify RISCVCompressInstEmitter.cpp to use getAllDerivedDefinitions()

[Paul-C-Anagnostopoulos]

Summary

This patch modifies the TableGen backend RISCVCompressInstEmmiter.cpp to use the getAllDerivedDefinitions() functions to get its working records. Before this patch, it filtered the records by hand.

This patch was separated out from a previous TableGen-related patch.

[lattner]

Looks obvious, feel free to directly commit things that you are confident are clear improvements.

[asb]

LGTM, thanks Paul.

[Paul-C-Anagnostopoulos]

Patch has been pushed.

[jrtc27]

As I said in D88832:

Please use arc patch next time to get the Differential Revision: header so the commit and the revision are linked in both directions, which will also automatically close the revision.

[jrtc27]

(so please close this revision now and follow the right process in future)

[Paul-C-Anagnostopoulos]

I do not want the revision to close when I push the patch. I'm using Phabricator to keep track of the status of each patch, so I want to close the revision once I know that the patch built correctly.

Can I cross-link the commit and revision without closing the revision?

[jrtc27]

In D89330#2332401, @Paul-C-Anagnostopoulos wrote:

I do not want the revision to close when I push the patch. I'm using Phabricator to keep track of the status of each patch, so I want to close the revision once I know that the patch built correctly.

Can I cross-link the commit and revision without closing the revision?

Please do not do that, that is not how Phabricator is meant to be used. You can update the Phabricator metadata, but you cannot update the commit once pushed, and it is really important that people be able to look at a commit and get the link to the Phabricator review in order to be able to see the discussion for why the patch ended up the way it did.

[jrtc27]

As for building correctly:

You should be building the patch and running the test suite locally. It is possible that one of the buildbots will spot an error in a different configuration than yours, in which case you can do one of

• direct commit a fix if it's sufficiently obvious; or

• post a fix for quick review as a new patch if the breakage is limited; or

• revert the commit and then reopen the revision here with an updated patch.

[Paul-C-Anagnostopoulos]

Yes, I have been running the TableGen test suite and building all the targets to test my patches. I've added tests as appropriate.

I will use arc patch from now on.

[Paul-C-Anagnostopoulos]

Oh, and thanks for the list of approaches to dealing with a build problem.

llvm/utils/TableGen/RISCVCompressInstEmitter.cpp

 }
 
 void RISCVCompressInstEmitter::run(raw_ostream &o) {
-  Record *CompressClass = Records.getClass("CompressPat");
-  assert(CompressClass && "Compress class definition missing!");
-  std::vector<Record *> Insts;
-  for (const auto &D : Records.getDefs()) {
-    if (D.second->isSubClassOf(CompressClass))
-      Insts.push_back(D.second.get());
-  }
+  std::vector<Record *> Insts = Records.getAllDerivedDefinitions("CompressPat");
 
   // Process the CompressPat definitions, validating them as we do so.
   for (unsigned i = 0, e = Insts.size(); i != e; ++i)