This is an archive of the discontinued LLVM Phabricator instance.

Differential D89312

[SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang
ClosedPublic

Authored by CarolineConcatto on Oct 13 2020, 5:43 AM.

Details

Reviewers
efriedma
david-arm
sdesmalen
Commits
rGe8d9ee9c7cfe: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang
Summary

This patch makes sure that the instance of TypeSize comparison operator is done with a fixed type size.

Diff Detail

Unit TestsFailed

TimeTest
890 mslinux > libarcher.parallel::parallel-nosuppression.c

Event Timeline

CarolineConcatto created this revision.Oct 13 2020, 5:43 AM
Herald added a reviewer: efriedma. · View Herald TranscriptOct 13 2020, 5:43 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, psnobl, tschuett. · View Herald Transcript
CarolineConcatto requested review of this revision.Oct 13 2020, 5:43 AM
CarolineConcatto added a reviewer: david-arm.Oct 13 2020, 5:43 AM
CarolineConcatto retitled this revision from [SVE][CodeGen]Use TypeSize comparison operators in clang to [SVE][CodeGen]Use TypeSize comparison functions in clang.Oct 13 2020, 6:52 AM
CarolineConcatto added a reviewer: sdesmalen.
Harbormaster completed remote builds in B74927: Diff 297834.Oct 13 2020, 7:15 AM
CarolineConcatto edited the summary of this revision. (Show Details)Oct 13 2020, 7:19 AM
CarolineConcatto updated this revision to Diff 297884.Oct 13 2020, 9:20 AM

-Use getFixedSize instead of isKnowXY

CarolineConcatto retitled this revision from [SVE][CodeGen]Use TypeSize comparison functions in clang to [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.Oct 13 2020, 9:22 AM
CarolineConcatto edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B74948: Diff 297884.Oct 13 2020, 10:52 AM
david-arm accepted this revision.Oct 14 2020, 12:02 AM
This revision is now accepted and ready to land.Oct 14 2020, 12:02 AM
This revision was landed with ongoing or failed builds.Oct 16 2020, 3:22 AM
Closed by commit rGe8d9ee9c7cfe: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang (authored by CarolineConcatto). · Explain Why
This revision was automatically updated to reflect the committed changes.
CarolineConcatto added a commit: rGe8d9ee9c7cfe: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.

Revision Contents

PathSize
clang/
lib/
CodeGen/
4 lines

Diff 297884

clang/lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,593 Lines • ▼ Show 20 Lines for (Function::const_arg_iterator ai = F->arg_begin(), ae = F->arg_end();
Ops[j] = CGF.Builder.CreateTruncOrBitCast( Ops[j] = CGF.Builder.CreateTruncOrBitCast(
Ops[j], cast<llvm::VectorType>(ArgTy)->getElementType()); Ops[j], cast<llvm::VectorType>(ArgTy)->getElementType());
Ops[j] = Ops[j] =
CGF.Builder.CreateInsertElement(UndefValue::get(ArgTy), Ops[j], C0); CGF.Builder.CreateInsertElement(UndefValue::get(ArgTy), Ops[j], C0);
} }
Value *Result = CGF.EmitNeonCall(F, Ops, s); Value *Result = CGF.EmitNeonCall(F, Ops, s);
llvm::Type *ResultType = CGF.ConvertType(E->getType()); llvm::Type *ResultType = CGF.ConvertType(E->getType());
if (ResultType->getPrimitiveSizeInBits() < if (ResultType->getPrimitiveSizeInBits().getFixedSize() <
Result->getType()->getPrimitiveSizeInBits()) Result->getType()->getPrimitiveSizeInBits().getFixedSize())
return CGF.Builder.CreateExtractElement(Result, C0); return CGF.Builder.CreateExtractElement(Result, C0);
return CGF.Builder.CreateBitCast(Result, ResultType, s); return CGF.Builder.CreateBitCast(Result, ResultType, s);
} }
Value *CodeGenFunction::EmitCommonNeonBuiltinExpr( Value *CodeGenFunction::EmitCommonNeonBuiltinExpr(
unsigned BuiltinID, unsigned LLVMIntrinsic, unsigned AltLLVMIntrinsic, unsigned BuiltinID, unsigned LLVMIntrinsic, unsigned AltLLVMIntrinsic,
const char *NameHint, unsigned Modifier, const CallExpr *E, const char *NameHint, unsigned Modifier, const CallExpr *E,
▲ Show 20 Lines • Show All 11,306 Lines • Show Last 20 Lines