This is an archive of the discontinued LLVM Phabricator instance.

[X86] Fix assert fail when element type is i1.
ClosedPublic

Authored by pengfei on Oct 9 2020, 12:05 AM.

Details

Summary

extract_vector_elt will turn type vxi1 into i8, which triggers the assertion fail.
Since we don't really handle vxi1 cases in below code, we can just return from here.

Diff Detail

Event Timeline

pengfei created this revision.Oct 9 2020, 12:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2020, 12:05 AM
pengfei requested review of this revision.Oct 9 2020, 12:05 AM
RKSimon accepted this revision.Oct 19 2020, 4:01 AM

LGTM

This revision is now accepted and ready to land.Oct 19 2020, 4:01 AM

sorry - missed a minor - LGTM with that change

llvm/test/CodeGen/X86/vector-reduce-or-cmp.ll
1176

drop the experimental

pengfei marked an inline comment as done.Oct 19 2020, 6:42 PM

Thanks @RKSimon.