This is an archive of the discontinued LLVM Phabricator instance.

[mlir][openacc] Add init operation
ClosedPublic

Authored by clementval on Sep 24 2020, 12:04 PM.

Details

Summary

This patch introduces the init operation that represents the init executable directive
from the OpenACC 3.0 specifications.

Diff Detail

Event Timeline

clementval created this revision.Sep 24 2020, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2020, 12:04 PM
clementval requested review of this revision.Sep 24 2020, 12:04 PM
rriddle added inline comments.Sep 28 2020, 9:59 AM
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
645

You can return the error directly. Also, you can use emitOpError to prefix the message with the op name.

Address review comments

ftynse accepted this revision.Sep 29 2020, 4:56 AM
This revision is now accepted and ready to land.Sep 29 2020, 4:56 AM
This revision was landed with ongoing or failed builds.Sep 29 2020, 7:59 AM
This revision was automatically updated to reflect the committed changes.