Page MenuHomePhabricator

[mlir][openacc] Use OptionalParseResult in loop op parser instead of bool variables
ClosedPublic

Authored by clementval on Sep 22 2020, 11:54 AM.

Details

Summary

This patch switch from using bool variables to OptionalParseResult for the parsing
inside loop operation. This is already done for parallel operation and this patch unify this
in the dialect.

Diff Detail

Event Timeline

clementval created this revision.Sep 22 2020, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 11:54 AM
clementval requested review of this revision.Sep 22 2020, 11:54 AM
ftynse accepted this revision.Sep 23 2020, 6:16 AM

Thanks for following up on this!

mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
123–124

Nit: return failure(parser.... || parser...);

159

clang-tidy: warning: unused variable 'type' [clang-diagnostic-unused-variable]

Please fix

This revision is now accepted and ready to land.Sep 23 2020, 6:16 AM
clementval marked an inline comment as done.

Address review comments

clementval marked an inline comment as done.Sep 23 2020, 7:21 AM

Thanks for following up on this!

Thanks for the reviews!

This revision was landed with ongoing or failed builds.Sep 23 2020, 7:26 AM
This revision was automatically updated to reflect the committed changes.