Page MenuHomePhabricator

[analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries
ClosedPublic

Authored by martong on Sep 22 2020, 8:28 AM.

Details

Summary

The signature should not be part of the summaries as many FIXME comments
suggests. By separating the signature, we open up the way to a generic
matching implementation which could be used later under the hoods of
CallDescriptionMap.

Diff Detail

Event Timeline

martong created this revision.Sep 22 2020, 8:28 AM
martong requested review of this revision.Sep 22 2020, 8:28 AM
Szelethus accepted this revision.Sep 22 2020, 10:30 PM

Yup, we've talked about this before. This is indeed a better interface design. LGTM!

This revision is now accepted and ready to land.Sep 22 2020, 10:30 PM

Thanks for the review! :)

This revision was landed with ongoing or failed builds.Sep 23 2020, 2:02 AM
This revision was automatically updated to reflect the committed changes.