Page MenuHomePhabricator

[analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures
ClosedPublic

Authored by martong on Sep 22 2020, 6:04 AM.

Details

Summary

It is no longer needed to add summaries of 'getline' for different
possible underlying types of ssize_t. We can just simply lookup the
type.

Diff Detail

Event Timeline

martong created this revision.Sep 22 2020, 6:04 AM
martong requested review of this revision.Sep 22 2020, 6:04 AM
Szelethus accepted this revision.Sep 22 2020, 10:27 PM

A joy of reviewing C++ code is that you get to marvel in all the great things the language has, without having to pull fistfuls of hair out to get get to that point. These patches are always a treat. LGTM!

This revision is now accepted and ready to land.Sep 22 2020, 10:27 PM

A joy of reviewing C++ code is that you get to marvel in all the great things the language has, without having to pull fistfuls of hair out to get get to that point. These patches are always a treat. LGTM!

Thanks! And thanks for your time with the review! :)