Page MenuHomePhabricator

[DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.
ClosedPublic

Authored by Higuoxing on Sep 17 2020, 8:03 PM.

Details

Summary

This patch makes the include_directories, file_names and opcodes fields
of the line table optional. This helps us simplify some tests.

Diff Detail

Event Timeline

Higuoxing created this revision.Sep 17 2020, 8:03 PM
Herald added a reviewer: alexshap. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Higuoxing requested review of this revision.Sep 17 2020, 8:03 PM

I might be missing it, but do you have direct testing showing that the default for IncludeDirs\Files\Opcodes is an empty output, when the output is written? I think it's important that this is tested.

Higuoxing updated this revision to Diff 292719.Sep 18 2020, 1:30 AM

I might be missing it, but do you have direct testing showing that the default for IncludeDirs\Files\Opcodes is an empty output, when the output is written? I think it's important that this is tested.

Sorry, I didn't test it.

Add test case (k) in llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml.

This revision is now accepted and ready to land.Sep 18 2020, 1:43 AM