Page MenuHomePhabricator

[DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC.
ClosedPublic

Authored by Higuoxing on Sep 17 2020, 7:46 PM.

Details

Summary

This patch makes checkers stricter so that we are able to avoid
some potential problems earlier.

Diff Detail

Event Timeline

Higuoxing created this revision.Sep 17 2020, 7:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2020, 7:46 PM
Higuoxing requested review of this revision.Sep 17 2020, 7:46 PM
Higuoxing updated this revision to Diff 292693.Sep 17 2020, 7:49 PM

Check the DWARF: tag.

Harbormaster completed remote builds in B72121: Diff 292692.
MaskRay accepted this revision.Sep 17 2020, 11:34 PM

LGTM.

This revision is now accepted and ready to land.Sep 17 2020, 11:34 PM
jhenderson accepted this revision.Sep 18 2020, 1:23 AM

Maybe worth stating in the description and/or title that you are using CHECK-NEXT explicitly to achieve this. Otherwise, LGTM.

Higuoxing retitled this revision from [DWARFYAML][test] Make checkers stricter. NFC. to [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..Sep 18 2020, 1:32 AM
This revision was landed with ongoing or failed builds.Sep 18 2020, 5:20 AM
This revision was automatically updated to reflect the committed changes.