Page MenuHomePhabricator

[mlir][openacc] Add missing operands for acc.parallel operation
ClosedPublic

Authored by clementval on Sep 15 2020, 5:56 PM.

Details

Summary

Add missing operands to represent copin with readonly modifier, copyout with zero
modifier, create with zero modifier and default clause.

Diff Detail

Event Timeline

clementval created this revision.Sep 15 2020, 5:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2020, 5:56 PM
clementval requested review of this revision.Sep 15 2020, 5:56 PM
ftynse accepted this revision.Sep 16 2020, 12:58 AM
ftynse added inline comments.
mlir/test/Dialect/OpenACC/ops.mlir
295

Nit: avoid overly restrictive checks. Does this rest really rely on something being on the _next_ non-empty line?

This revision is now accepted and ready to land.Sep 16 2020, 12:58 AM
clementval added inline comments.Sep 16 2020, 7:00 AM
mlir/test/Dialect/OpenACC/ops.mlir
295

Sure, I'll relax the checks before pushing this change. Thanks for the review.

Relax checks to be less restritive