This is an archive of the discontinued LLVM Phabricator instance.

Differential D87630

[mlir][openacc] Add missing print of vector_length in parallel op
ClosedPublic

Authored by clementval on Sep 14 2020, 1:18 PM.

Details

Reviewers
mehdi_amini
rriddle
ftynse
kiranktp
kiranchandramohan
SouraVX
Commits
rG2d8f0c05dbe7: [mlir][openacc] Add missing print of vector_length in parallel op
Summary

This patch adds the missing print for the vector_length in the parallel operation.

Diff Detail

Event Timeline

clementval created this revision.Sep 14 2020, 1:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2020, 1:18 PM
Herald added subscribers: tatianashp, msifontes, jurahul and 11 others. · View Herald Transcript
clementval requested review of this revision.Sep 14 2020, 1:18 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptSep 14 2020, 1:18 PM
Harbormaster completed remote builds in B71608: Diff 291663.Sep 14 2020, 1:45 PM
ftynse accepted this revision.Sep 15 2020, 1:51 AM
ftynse added inline comments.
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
289

Could you spell out the type? It's not obvious from the context so we prefer explicit types to auto.

This revision is now accepted and ready to land.Sep 15 2020, 1:51 AM
clementval marked an inline comment as done.Sep 15 2020, 6:46 AM
clementval added inline comments.
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
289

Sure I'll update the patch.

clementval updated this revision to Diff 291896.Sep 15 2020, 6:46 AM
clementval marked an inline comment as done.

Address review comments

This revision was landed with ongoing or failed builds.Sep 15 2020, 6:48 AM
Closed by commit rG2d8f0c05dbe7: [mlir][openacc] Add missing print of vector_length in parallel op (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG2d8f0c05dbe7: [mlir][openacc] Add missing print of vector_length in parallel op.
Harbormaster completed remote builds in B71731: Diff 291896.Sep 15 2020, 7:04 AM

Revision Contents

PathSize
mlir/
lib/
Dialect/
OpenACC/
IR/
11 lines
test/
Dialect/
OpenACC/
12 lines

Diff 291897

mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Linesstatic ParseResult parseParallelOp(OpAsmParser &parser,
return success(); return success();
} }
static void print(OpAsmPrinter &printer, ParallelOp &op) { static void print(OpAsmPrinter &printer, ParallelOp &op) {
printer << ParallelOp::getOperationName(); printer << ParallelOp::getOperationName();
// async()? // async()?
if (auto async = op.async()) if (Value async = op.async())
printer << " " << ParallelOp::getAsyncKeyword() << "(" << async << ")"; printer << " " << ParallelOp::getAsyncKeyword() << "(" << async << ")";
// wait()? // wait()?
printOperandList(op.waitOperands(), ParallelOp::getWaitKeyword(), printer); printOperandList(op.waitOperands(), ParallelOp::getWaitKeyword(), printer);
// num_gangs()? // num_gangs()?
if (auto numGangs = op.numGangs()) if (Value numGangs = op.numGangs())
printer << " " << ParallelOp::getNumGangsKeyword() << "(" << numGangs printer << " " << ParallelOp::getNumGangsKeyword() << "(" << numGangs
<< ")"; << ")";
// num_workers()? // num_workers()?
if (auto numWorkers = op.numWorkers()) if (Value numWorkers = op.numWorkers())
printer << " " << ParallelOp::getNumWorkersKeyword() << "(" << numWorkers printer << " " << ParallelOp::getNumWorkersKeyword() << "(" << numWorkers
<< ")"; << ")";
// vector_length()?
if (Value vectorLength = op.vectorLength())
ftynseUnsubmitted
Done
ReplyInline Actions

Could you spell out the type? It's not obvious from the context so we prefer explicit types to auto.

ftynse: Could you spell out the type? It's not obvious from the context so we prefer explicit types to…
clementvalAuthorUnsubmitted
Done
ReplyInline Actions

Sure I'll update the patch.

clementval: Sure I'll update the patch.
printer << " " << ParallelOp::getVectorLengthKeyword() << "("
<< vectorLength << ")";
// if()? // if()?
if (Value ifCond = op.ifCond()) if (Value ifCond = op.ifCond())
printer << " " << ParallelOp::getIfKeyword() << "(" << ifCond << ")"; printer << " " << ParallelOp::getIfKeyword() << "(" << ifCond << ")";
// self()? // self()?
if (Value selfCond = op.selfCond()) if (Value selfCond = op.selfCond())
printer << " " << ParallelOp::getSelfKeyword() << "(" << selfCond << ")"; printer << " " << ParallelOp::getSelfKeyword() << "(" << selfCond << ")";
▲ Show 20 Lines • Show All 365 Lines • Show Last 20 Lines

mlir/test/Dialect/OpenACC/ops.mlir

Show First 20 Lines • Show All 226 Lines • ▼ Show 20 Lines
// CHECK-NEXT: acc.loop vector([[VECTORLENGTH]]) { // CHECK-NEXT: acc.loop vector([[VECTORLENGTH]]) {
// CHECK-NEXT: } // CHECK-NEXT: }
// CHECK-NEXT: acc.loop gang(num: [[GANGNUM]]) worker vector { // CHECK-NEXT: acc.loop gang(num: [[GANGNUM]]) worker vector {
// CHECK-NEXT: } // CHECK-NEXT: }
// CHECK-NEXT: acc.loop gang(num: [[GANGNUM]], static: [[GANGSTATIC]]) worker([[WORKERNUM]]) vector([[VECTORLENGTH]]) { // CHECK-NEXT: acc.loop gang(num: [[GANGNUM]], static: [[GANGSTATIC]]) worker([[WORKERNUM]]) vector([[VECTORLENGTH]]) {
// CHECK-NEXT: } // CHECK-NEXT: }
// CHECK-NEXT: acc.loop tile([[TILESIZE]]: i64, [[TILESIZE]]: i64) { // CHECK-NEXT: acc.loop tile([[TILESIZE]]: i64, [[TILESIZE]]: i64) {
// CHECK-NEXT: } // CHECK-NEXT: }
func @testparallelop() -> () {
%vectorLength = constant 128 : index
acc.parallel vector_length(%vectorLength) {
}
return
}
// CHECK: [[VECTORLENGTH:%.*]] = constant 128 : index
// CHECK-NEXT: acc.parallel vector_length([[VECTORLENGTH]]) {
// CHECK-NEXT: }