This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][ASAN] implementation of internal syscalls wrappers for riscv64
ClosedPublic

Authored by EccoTheDolphin on Sep 12 2020, 5:56 PM.

Details

Summary

implements glibc-like wrappers over Linux syscalls.

[3/11] patch series to port ASAN for riscv64

Depends On D87998

Diff Detail

Event Timeline

EccoTheDolphin created this revision.Sep 12 2020, 5:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2020, 5:56 PM
Herald added subscribers: Restricted Project, evandro, luismarques and 26 others. · View Herald Transcript
EccoTheDolphin requested review of this revision.Sep 12 2020, 5:56 PM
EccoTheDolphin edited the summary of this revision. (Show Details)Sep 12 2020, 7:03 PM
EccoTheDolphin added a reviewer: kcc.
jrtc27 added inline comments.Sep 13 2020, 12:35 PM
compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_riscv64.inc
183

"clobbering"?

EccoTheDolphin added a comment.EditedSep 14 2020, 4:03 AM

yep... Thanks, will adjust

smd added a subscriber: smd.Sep 14 2020, 9:38 AM
EccoTheDolphin edited the summary of this revision. (Show Details)

fixed typo

EccoTheDolphin marked an inline comment as done.Sep 14 2020, 11:31 PM
eugenis added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_riscv64.inc
84

why not

return a0
MaskRay added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_riscv64.inc
34

All long int can be simplified to long

updated implementation of syscall wrappers to follow style of existing codebase

EccoTheDolphin retitled this revision from [RISCV][ASAN] implementation of internal syscalls wrappers for riscv to [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64.Sep 20 2020, 11:22 PM
EccoTheDolphin edited the summary of this revision. (Show Details)
EccoTheDolphin marked 2 inline comments as done.Sep 20 2020, 11:51 PM

rebasing/addressing comments

EccoTheDolphin edited the summary of this revision. (Show Details)Sep 22 2020, 11:37 AM
eugenis accepted this revision.Sep 22 2020, 1:18 PM

LGTM

This revision is now accepted and ready to land.Sep 22 2020, 1:18 PM
This revision was landed with ongoing or failed builds.Sep 22 2020, 9:58 PM
This revision was automatically updated to reflect the committed changes.