Page MenuHomePhabricator

EccoTheDolphin (Anatoly Parshincev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 21 2020, 3:41 AM (17 w, 6 d)

Recent Activity

Mon, Oct 12

EccoTheDolphin accepted D89244: [RISCV][ASAN] Fix TLS offsets.

LGTM

Mon, Oct 12, 8:28 AM · Restricted Project

Thu, Oct 8

EccoTheDolphin added a comment to D87997: [RISCV][crt] support building without init_array.

@phosek, @luismarques thanks for your feedback (sorry for the delay with reply)!

Thu, Oct 8, 10:03 PM · Restricted Project

Mon, Oct 5

EccoTheDolphin committed rGcf4aa6838802: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests (authored by smd).
[RISCV][ASAN] mark asan as supported for RISCV64 and enable tests
Mon, Oct 5, 12:39 AM
EccoTheDolphin closed D87582: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests.
Mon, Oct 5, 12:38 AM · Restricted Project

Sun, Oct 4

EccoTheDolphin updated the diff for D87582: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests.

rebasing

Sun, Oct 4, 8:30 PM · Restricted Project
EccoTheDolphin committed rGa566f0525a69: [RISCV][ASAN] instrumentation pass now uses proper shadow offset (authored by EccoTheDolphin).
[RISCV][ASAN] instrumentation pass now uses proper shadow offset
Sun, Oct 4, 6:31 AM
EccoTheDolphin closed D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.
Sun, Oct 4, 6:31 AM · Restricted Project
EccoTheDolphin added a comment to D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.

Regarding the build failure (linux > libarcher.parallel::parallel-nosuppression.c). I assume that my change is not related to this failure:

  1. This is a completely different codebase.
  2. I observe this failure on other revisions too, for example: https://reviews.llvm.org/D88580
Sun, Oct 4, 6:29 AM · Restricted Project
EccoTheDolphin updated the diff for D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.

[NFC] formatting: kRiscv64_ShadowOffset64->kRISCV64_ShadowOffset64

Sun, Oct 4, 6:06 AM · Restricted Project
EccoTheDolphin updated the diff for D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.

rebasing

Sun, Oct 4, 5:30 AM · Restricted Project
EccoTheDolphin committed rG7ce4dfb4dd2c: [RISCV][ASAN] support code for architecture-specific parts of asan (authored by smd).
[RISCV][ASAN] support code for architecture-specific parts of asan
Sun, Oct 4, 5:22 AM
EccoTheDolphin closed D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sun, Oct 4, 5:22 AM · Restricted Project
EccoTheDolphin updated the diff for D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

rebasing + fixed typo

Sun, Oct 4, 2:40 AM · Restricted Project
EccoTheDolphin committed rG51beb0c80dc4: [RISCV][ASAN] unwind fixup (authored by smd).
[RISCV][ASAN] unwind fixup
Sun, Oct 4, 1:13 AM
EccoTheDolphin closed D87579: [RISCV][ASAN] unwind fixup.
Sun, Oct 4, 1:13 AM · Restricted Project
EccoTheDolphin updated the diff for D87579: [RISCV][ASAN] unwind fixup.

rebasing

Sun, Oct 4, 12:32 AM · Restricted Project

Thu, Oct 1

EccoTheDolphin added a comment to D87579: [RISCV][ASAN] unwind fixup.

@eugenis, @luismarques - I believe all concerns for this one were addressed. Do you mind if I commit this as is?

If some revision of the patch is approved, and all comments are addressed no need to wait for re-approval.
If you still want another look, it's better to somehow attract reviewer's attention, as phabricator hides patches with previously approved revisions from "Ready to Review" list.

Thu, Oct 1, 8:08 PM · Restricted Project
EccoTheDolphin added a comment to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

For versions 2.29 -- 2.31 you have val = 1172. Is that actually correct? I thought you had earlier obtained a value of 1772 for 2.29, so maybe that's a typo?
Other than that issue, LGTM. Just be sure to verify/adjust that.

Thu, Oct 1, 8:06 PM · Restricted Project

Wed, Sep 30

EccoTheDolphin added a comment to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

@luismarques, this commit diff has a mark that a change was requested... I believe that we've addressed known issues. If you have no further objections or comments could you remove the mark?

Wed, Sep 30, 10:25 PM · Restricted Project
EccoTheDolphin added a comment to D87579: [RISCV][ASAN] unwind fixup.

@eugenis, @luismarques - I believe all concerns for this one were addressed. Do you mind if I commit this as is?

Wed, Sep 30, 10:22 PM · Restricted Project
EccoTheDolphin committed rGde973e0b0720: [RISCV][ASAN] implementation for previous/next pc routines for riscv64 (authored by notmytemp0).
[RISCV][ASAN] implementation for previous/next pc routines for riscv64
Wed, Sep 30, 10:15 PM
EccoTheDolphin closed D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.
Wed, Sep 30, 10:15 PM · Restricted Project

Tue, Sep 29

EccoTheDolphin added a comment to D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.

LGTM. I'll commit this.

Tue, Sep 29, 10:03 AM · Restricted Project

Sun, Sep 27

EccoTheDolphin updated the diff for D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

RISCV64 does not use stat64, so the corresponding size constant is set to "0"

Sun, Sep 27, 3:49 PM · Restricted Project
EccoTheDolphin added inline comments to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sun, Sep 27, 3:44 PM · Restricted Project
EccoTheDolphin added a comment to D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.

@reviewers: if you have no further objections, can I proceed with committing this one? (Could you mark the patch as "accepted" once again?)

Sun, Sep 27, 3:41 PM · Restricted Project
EccoTheDolphin updated the summary of D87582: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests.
Sun, Sep 27, 3:39 PM · Restricted Project
EccoTheDolphin updated the diff for D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

addressed review comments

Sun, Sep 27, 3:35 PM · Restricted Project

Sep 24 2020

EccoTheDolphin added inline comments to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sep 24 2020, 4:36 AM · Restricted Project
EccoTheDolphin updated the diff for D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.

addressed review comments

Sep 24 2020, 3:16 AM · Restricted Project
EccoTheDolphin added a comment to D87578: [NFC][RISCV][builtins] remove some hard-coded values from i-cache clear routine.

I can commit this for you. Is assume this the correct author? Alexey Baturo <space.monkey.delivers@gmail.com>

IMO, I think you could request commit access. You have contributed a whole patch series and have been thoughfully participating in its review. Since most commits should go through pre-review anyway, the bar to gain commit access probably shouldn't be too high. IMO it should just be just high enough that random people aren't always screwing everything and disrupting other's work. If you do gain commit access, just keep an eye on the buildbots when you commit a patch, and revert the patch if builds start to fail and you can't immediately fix the issue.

Sep 24 2020, 2:20 AM · Restricted Project
EccoTheDolphin added a comment to D87997: [RISCV][crt] support building without init_array.

RISC-V LLVM and GCC are default using init_array, curious why we need this?

Actually, yes. You are correct - this one is not needed for ASAN support... My understanding is that this may be needed if we link against some custom runtime. I'll adjust the description of the patch.

I would prefer let those custom runtime to using their crt files, otherwise that add extra 18 byte(auipc+jal+auipc+jal+c.nop) or 20 byte (auipc+jal+auipc+jal+nop) for all RISC-V program which using compiler-rt.

Sep 24 2020, 2:15 AM · Restricted Project
EccoTheDolphin added a reviewer for D87997: [RISCV][crt] support building without init_array: phosek.
Sep 24 2020, 2:02 AM · Restricted Project
EccoTheDolphin added a reviewer for D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset: vitalybuka.
Sep 24 2020, 1:11 AM · Restricted Project
EccoTheDolphin added a reviewer for D87580: [RISCV][ASAN] support code for architecture-specific parts of asan: vitalybuka.
Sep 24 2020, 1:10 AM · Restricted Project
EccoTheDolphin added a reviewer for D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64: vitalybuka.
Sep 24 2020, 1:10 AM · Restricted Project
EccoTheDolphin updated the diff for D87582: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests.

rebasing

Sep 24 2020, 12:39 AM · Restricted Project
EccoTheDolphin updated the diff for D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.

rebasing

Sep 24 2020, 12:39 AM · Restricted Project
EccoTheDolphin updated the diff for D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

rebasing + addressing formatting issues

Sep 24 2020, 12:38 AM · Restricted Project
EccoTheDolphin updated the diff for D87579: [RISCV][ASAN] unwind fixup.

rebasing

Sep 24 2020, 12:38 AM · Restricted Project
EccoTheDolphin updated the diff for D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.

rebasing

Sep 24 2020, 12:37 AM · Restricted Project

Sep 23 2020

EccoTheDolphin retitled D87578: [NFC][RISCV][builtins] remove some hard-coded values from i-cache clear routine from [RISCV][builtins] implementation of i-cache clear routine to [NFC][RISCV][builtins] remove some hard-coded values from i-cache clear routine.
Sep 23 2020, 11:48 PM · Restricted Project
EccoTheDolphin updated the diff for D87578: [NFC][RISCV][builtins] remove some hard-coded values from i-cache clear routine.

addressing improvements suggested by Luís Marques

Sep 23 2020, 11:47 PM · Restricted Project
EccoTheDolphin added a comment to D87578: [NFC][RISCV][builtins] remove some hard-coded values from i-cache clear routine.

We don't need to have the two implementations, and in fact with this patch you'll probably get the cache cleared twice. Still, there might be some opportunities for improving the existing code. Some more specific comments:

Sep 23 2020, 9:10 PM · Restricted Project
EccoTheDolphin added a comment to D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.

@reviewers: I believe we are done here. Since we can't add a reliable check to figure out the exactly length - I guess the current implementation should serve fine.

Sep 23 2020, 9:08 PM · Restricted Project
EccoTheDolphin updated the summary of D87997: [RISCV][crt] support building without init_array.
Sep 23 2020, 8:56 PM · Restricted Project
EccoTheDolphin added a comment to D87997: [RISCV][crt] support building without init_array.

RISC-V LLVM and GCC are default using init_array, curious why we need this?

Sep 23 2020, 8:55 PM · Restricted Project
EccoTheDolphin added inline comments to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sep 23 2020, 7:05 AM · Restricted Project
EccoTheDolphin added a comment to D87579: [RISCV][ASAN] unwind fixup.

LGTM

Does gcc use the same frame record layout? We've had issues like that with Arm, see GetCanonicFrame. If not, maybe it's not too late to fix?

I'll double-check.

Sep 23 2020, 12:42 AM · Restricted Project

Sep 22 2020

EccoTheDolphin added inline comments to D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.
Sep 22 2020, 9:38 PM · Restricted Project
EccoTheDolphin added inline comments to D87574: [RISCV][ASAN] implementation for vfork interceptor for riscv64.
Sep 22 2020, 8:23 PM · Restricted Project
EccoTheDolphin added a comment to D87574: [RISCV][ASAN] implementation for vfork interceptor for riscv64.

Can we please just have a riscv version that works for both RV32 and RV64? It should just be a case of changing some ld/sd's to LOAD/STORE macros that are either [ls]w or [ls]d, and the various multiples of 8 to n*__riscv_xlen instead.

Sep 22 2020, 8:16 PM · Restricted Project
EccoTheDolphin updated the diff for D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

addressing review comments

Sep 22 2020, 2:38 PM · Restricted Project
EccoTheDolphin updated the diff for D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.

addressing changes

Sep 22 2020, 2:36 PM · Restricted Project
EccoTheDolphin updated the diff for D87575: [RISCV][ASAN] implementation of ThreadSelf for riscv64.

addressing commits

Sep 22 2020, 2:35 PM · Restricted Project
EccoTheDolphin updated the diff for D87574: [RISCV][ASAN] implementation for vfork interceptor for riscv64.

addressing comments

Sep 22 2020, 2:35 PM · Restricted Project
EccoTheDolphin updated the diff for D87573: [RISCV][ASAN] implementation of clone interceptor for riscv64.

addressing comments

Sep 22 2020, 2:34 PM · Restricted Project
EccoTheDolphin updated the diff for D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.

addressing comments

Sep 22 2020, 2:33 PM · Restricted Project
EccoTheDolphin added inline comments to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sep 22 2020, 1:33 PM · Restricted Project
EccoTheDolphin added a comment to D87579: [RISCV][ASAN] unwind fixup.

LGTM

Does gcc use the same frame record layout? We've had issues like that with Arm, see GetCanonicFrame. If not, maybe it's not too late to fix?

Sep 22 2020, 1:25 PM · Restricted Project
EccoTheDolphin added inline comments to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sep 22 2020, 11:43 AM · Restricted Project
EccoTheDolphin updated the summary of D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.
Sep 22 2020, 11:41 AM · Restricted Project
EccoTheDolphin updated the summary of D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sep 22 2020, 11:41 AM · Restricted Project
EccoTheDolphin updated the summary of D87579: [RISCV][ASAN] unwind fixup.
Sep 22 2020, 11:40 AM · Restricted Project
EccoTheDolphin updated the summary of D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.
Sep 22 2020, 11:40 AM · Restricted Project
EccoTheDolphin updated the summary of D87575: [RISCV][ASAN] implementation of ThreadSelf for riscv64.
Sep 22 2020, 11:39 AM · Restricted Project
EccoTheDolphin updated the summary of D87574: [RISCV][ASAN] implementation for vfork interceptor for riscv64.
Sep 22 2020, 11:39 AM · Restricted Project
EccoTheDolphin updated the summary of D87573: [RISCV][ASAN] implementation of clone interceptor for riscv64.
Sep 22 2020, 11:38 AM · Restricted Project
EccoTheDolphin updated the summary of D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64.
Sep 22 2020, 11:37 AM · Restricted Project
EccoTheDolphin updated the summary of D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.
Sep 22 2020, 11:37 AM · Restricted Project
EccoTheDolphin updated the diff for D87582: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests.

rebasing

Sep 22 2020, 11:17 AM · Restricted Project
EccoTheDolphin updated the diff for D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.

rebasing

Sep 22 2020, 11:16 AM · Restricted Project
EccoTheDolphin updated the diff for D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.

addressing comments

Sep 22 2020, 11:16 AM · Restricted Project
EccoTheDolphin updated the diff for D87579: [RISCV][ASAN] unwind fixup.

rebasing

Sep 22 2020, 11:15 AM · Restricted Project
EccoTheDolphin updated the diff for D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64.

addressing comments/continue

Sep 22 2020, 11:14 AM · Restricted Project
EccoTheDolphin updated the diff for D87575: [RISCV][ASAN] implementation of ThreadSelf for riscv64.

addressing comments/rebasing

Sep 22 2020, 11:14 AM · Restricted Project
EccoTheDolphin updated the diff for D87574: [RISCV][ASAN] implementation for vfork interceptor for riscv64.

addressing comments/rebasing

Sep 22 2020, 11:13 AM · Restricted Project
EccoTheDolphin updated the diff for D87573: [RISCV][ASAN] implementation of clone interceptor for riscv64.

addressing comments/rebasing

Sep 22 2020, 11:13 AM · Restricted Project
EccoTheDolphin updated the diff for D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64.

rebasing/addressing comments

Sep 22 2020, 11:13 AM · Restricted Project
EccoTheDolphin updated the diff for D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.

addressing comments, changing the order of modifications

Sep 22 2020, 11:12 AM · Restricted Project
EccoTheDolphin updated the diff for D87997: [RISCV][crt] support building without init_array.

rebasing patchset...

Sep 22 2020, 11:11 AM · Restricted Project

Sep 21 2020

EccoTheDolphin added a reviewer for D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64: vitalybuka.
Sep 21 2020, 12:29 PM · Restricted Project

Sep 20 2020

EccoTheDolphin retitled D87582: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests from [RISCV][ASAN] mark asan as supported for RISCV and enable tests to [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests.
Sep 20 2020, 11:47 PM · Restricted Project
EccoTheDolphin updated the summary of D87581: [RISCV][ASAN] instrumentation pass now uses proper shadow offset.
Sep 20 2020, 11:45 PM · Restricted Project
EccoTheDolphin retitled D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform from [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 to [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.
Sep 20 2020, 11:44 PM · Restricted Project
EccoTheDolphin added inline comments to D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sep 20 2020, 11:41 PM · Restricted Project
EccoTheDolphin updated the summary of D87580: [RISCV][ASAN] support code for architecture-specific parts of asan.
Sep 20 2020, 11:40 PM · Restricted Project
EccoTheDolphin updated the summary of D87579: [RISCV][ASAN] unwind fixup.
Sep 20 2020, 11:38 PM · Restricted Project
EccoTheDolphin updated the summary of D87579: [RISCV][ASAN] unwind fixup.
Sep 20 2020, 11:36 PM · Restricted Project
EccoTheDolphin abandoned D87576: [RISCV][ASAN] implementation of SignalContext::GetWriteFlag.

the relevant functionality is already implemented/

Sep 20 2020, 11:34 PM · Restricted Project
EccoTheDolphin updated the summary of D87576: [RISCV][ASAN] implementation of SignalContext::GetWriteFlag.
Sep 20 2020, 11:33 PM · Restricted Project
EccoTheDolphin retitled D87577: [RISCV][ASAN] implementation for previous/next pc routines for riscv64 from [RISCV][ASAN] implementation for previous/next pc to [RISCV][ASAN] implementation for previous/next pc routines for riscv64.
Sep 20 2020, 11:33 PM · Restricted Project
EccoTheDolphin retitled D87575: [RISCV][ASAN] implementation of ThreadSelf for riscv64 from [RISCV][ASAN] implementation of ThreadSelf for sanitizer_common lib to [RISCV][ASAN] implementation of ThreadSelf for riscv64.
Sep 20 2020, 11:31 PM · Restricted Project
EccoTheDolphin retitled D87574: [RISCV][ASAN] implementation for vfork interceptor for riscv64 from [RISCV][ASAN] implementation for vfork interceptor to [RISCV][ASAN] implementation for vfork interceptor for riscv64.
Sep 20 2020, 11:29 PM · Restricted Project
EccoTheDolphin retitled D87573: [RISCV][ASAN] implementation of clone interceptor for riscv64 from [RISCV][ASAN] implementation for clone interceptor to [RISCV][ASAN] implementation of clone interceptor for riscv64.
Sep 20 2020, 11:28 PM · Restricted Project
EccoTheDolphin updated the summary of D87578: [NFC][RISCV][builtins] remove some hard-coded values from i-cache clear routine.
Sep 20 2020, 11:25 PM · Restricted Project
EccoTheDolphin retitled D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64 from [RISCV][ASAN] implementation of internal syscalls wrappers for riscv to [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64.
Sep 20 2020, 11:22 PM · Restricted Project
EccoTheDolphin added a reviewer for D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64: eugenis.
Sep 20 2020, 11:17 PM · Restricted Project
EccoTheDolphin updated the summary of D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64.
Sep 20 2020, 11:16 PM · Restricted Project
EccoTheDolphin added reviewers for D87997: [RISCV][crt] support building without init_array: kcc, eugenis, luismarques.
Sep 20 2020, 11:15 PM · Restricted Project