Page MenuHomePhabricator

[MLIR] Fix Win test due to partial order of CHECK directives
ClosedPublic

Authored by nicolasvasilache on Sep 7 2020, 3:06 AM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache requested review of this revision.Sep 7 2020, 3:06 AM
ftynse accepted this revision.Sep 7 2020, 3:43 AM
This revision is now accepted and ready to land.Sep 7 2020, 3:43 AM
rriddle added inline comments.Sep 7 2020, 1:57 PM
mlir/test/Conversion/VectorToSCF/vector-to-loops.mlir
102

What is the cause of this? This revision looks like it's working around a bug in the implementation that relies on something that is non-deterministic w.r.t toolchain.

nicolasvasilache marked an inline comment as done.Sep 7 2020, 2:32 PM
nicolasvasilache added inline comments.
mlir/test/Conversion/VectorToSCF/vector-to-loops.mlir
102
mehdi_amini added inline comments.Sep 7 2020, 3:37 PM
mlir/test/Conversion/VectorToSCF/vector-to-loops.mlir
102

Instead of masking the issue, can you replace the uses of EDSCs with builders in this code?

nicolasvasilache marked an inline comment as done.Sep 8 2020, 12:16 AM
nicolasvasilache added subscribers: burmako, dmgreen, fhahn and 4 others.

First this is not an issue but a feature of C++.
Builders would have the same behavior as explained in the discourse post.

Can you then split the statement to have deterministic portable behavior?