This is an archive of the discontinued LLVM Phabricator instance.

Add lld/ELF release notes for release/11.x
ClosedPublic

Authored by MaskRay on Aug 25 2020, 4:02 PM.

Details

Diff Detail

Event Timeline

MaskRay created this revision.Aug 25 2020, 4:02 PM
MaskRay requested review of this revision.Aug 25 2020, 4:02 PM
MaskRay added a subscriber: hans.Aug 25 2020, 4:08 PM
MaskRay added inline comments.
lld/docs/ReleaseNotes.rst
75

@hans This line is for the the cherry-pick request for D85579:)

grimar added inline comments.Aug 26 2020, 1:27 AM
lld/docs/ReleaseNotes.rst
112

Perhaps, worth grouping 2 Hexagon lines together?

grimar added inline comments.Aug 26 2020, 1:28 AM
lld/docs/ReleaseNotes.rst
34

This and other lines sometimes looks too long. Should them be wrapped like was done for, e.g., --time-trace?

hans added inline comments.Aug 26 2020, 6:37 AM
lld/docs/ReleaseNotes.rst
75

Got it, thanks.

Thanks for putting this together, looks good. I've added a few suggestions, and some typo spots.

lld/docs/ReleaseNotes.rst
27–37

Is it worth starting with the option first. Something like:
`--time-trace` option has been added. It records...

43

Suggest: is added to create separate output sections for orphan sections.

45

"gets" -> "has been"

46

Suggest: "If a link passes with warnings from `--warn-backrefs`"

47

typo "mail" -> "will" or "may"

51

Suggest "is accepted but ignored"

64

I think this is more along the lines of
"were added to select the REL/RELA format for the dynamic relocations. The default is target specific and typically matches the form used in relocatable objects."

69

are -> and

71

can now be used together.

89

Suggest: `INPUT_SECTION_FLAGS` is supported in linker scripts.

95

Does this need a comma after parsed.
`SHT_GNU_verneed` in shared objects are parsed, and versioned undefined symbols in shared objects are respected.

MaskRay updated this revision to Diff 288045.Aug 26 2020, 11:03 AM
MaskRay marked 13 inline comments as done.

Thanks for suggestions!

Updating...

lld/docs/ReleaseNotes.rst
34

In HTML, the multi-line (Dxxxxx ...) will be joined on one line, so I think this may be fine.

MaskRay updated this revision to Diff 288435.Aug 27 2020, 12:48 PM

Mention D85785 (-r)

MaskRay updated this revision to Diff 288436.Aug 27 2020, 12:50 PM

Minor adjustment

Harbormaster completed remote builds in B69830: Diff 288436.
MaskRay updated this revision to Diff 288479.Aug 27 2020, 4:21 PM

Reword --warn-backrefs

Seems all comments were addressed and I have no more comments too.
Happy if Peter is happy (seems all his comments were addressed).

MaskRay added a comment.EditedAug 29 2020, 8:46 AM

Seems all comments were addressed and I have no more comments too.
Happy if Peter is happy (seems all his comments were addressed).

Thanks! I will push this to release/11.x. We can edit the content if there are other suggestions.

edit: 2c6a593b5e186a686fdaf6b6082b0dbcae29c265 in release/11.x

MaskRay accepted this revision.Aug 29 2020, 9:15 AM
This revision is now accepted and ready to land.Aug 29 2020, 9:15 AM
MaskRay closed this revision.Aug 29 2020, 9:15 AM