Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 112 | Perhaps, worth grouping 2 Hexagon lines together? | |
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 34 | This and other lines sometimes looks too long. Should them be wrapped like was done for, e.g., --time-trace? | |
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 75 | Got it, thanks. | |
Thanks for putting this together, looks good. I've added a few suggestions, and some typo spots.
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 37 | Is it worth starting with the option first. Something like: | |
| 43 | Suggest: is added to create separate output sections for orphan sections. | |
| 45 | "gets" -> "has been" | |
| 46 | Suggest: "If a link passes with warnings from `--warn-backrefs`" | |
| 47 | typo "mail" -> "will" or "may" | |
| 51 | Suggest "is accepted but ignored" | |
| 64 | I think this is more along the lines of | |
| 69 | are -> and | |
| 71 | can now be used together. | |
| 89 | Suggest: `INPUT_SECTION_FLAGS` is supported in linker scripts. | |
| 95 | Does this need a comma after parsed. | |
Thanks for suggestions!
Updating...
| lld/docs/ReleaseNotes.rst | ||
|---|---|---|
| 34 | In HTML, the multi-line (Dxxxxx ...) will be joined on one line, so I think this may be fine. | |
Seems all comments were addressed and I have no more comments too.
Happy if Peter is happy (seems all his comments were addressed).
Thanks! I will push this to release/11.x. We can edit the content if there are other suggestions.
edit: 2c6a593b5e186a686fdaf6b6082b0dbcae29c265 in release/11.x
This and other lines sometimes looks too long. Should them be wrapped like was done for, e.g., --time-trace?