This is an archive of the discontinued LLVM Phabricator instance.

Differential D86535

[AArch64][AsmParser] Fix bug in operand printer
ClosedPublic

Authored by c-rhodes on Aug 25 2020, 6:02 AM.

Details

Reviewers
sdesmalen
pbarrio
olista01
david-arm
ostannard
Commits
rG1f44dfb640cb: [AArch64][AsmParser] Fix bug in operand printer
Summary

The switch in AArch64Operand::print was changed in D45688 so the shift
can be printed after printing the register. This is implemented with
LLVM_FALLTHROUGH and was broken in D52485 when BTIHint was put between
the register and shift operands.

Diff Detail

Event Timeline

c-rhodes created this revision.Aug 25 2020, 6:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2020, 6:02 AM
Herald added subscribers: danielkiss, hiraditya, kristof.beyls. · View Herald Transcript
c-rhodes requested review of this revision.Aug 25 2020, 6:02 AM
Harbormaster completed remote builds in B69443: Diff 287646.Aug 25 2020, 6:32 AM
ostannard accepted this revision.Aug 25 2020, 6:34 AM
ostannard added a subscriber: ostannard.

LGTM

This revision is now accepted and ready to land.Aug 25 2020, 6:34 AM
Closed by commit rG1f44dfb640cb: [AArch64][AsmParser] Fix bug in operand printer (authored by c-rhodes). · Explain WhyAug 26 2020, 2:31 AM
This revision was automatically updated to reflect the committed changes.
c-rhodes added a commit: rG1f44dfb640cb: [AArch64][AsmParser] Fix bug in operand printer.

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
AsmParser/
6 lines

Diff 287646

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Show First 20 Lines • Show All 2,065 Lines • ▼ Show 20 Lines if (!Name.empty())
OS << "<prfop " << Name << ">"; OS << "<prfop " << Name << ">";
else else
OS << "<prfop invalid #" << getPrefetch() << ">"; OS << "<prfop invalid #" << getPrefetch() << ">";
break; break;
} }
case k_PSBHint: case k_PSBHint:
OS << getPSBHintName(); OS << getPSBHintName();
break; break;
case k_BTIHint:
OS << getBTIHintName();
break;
case k_Register: case k_Register:
OS << "<register " << getReg() << ">"; OS << "<register " << getReg() << ">";
if (!getShiftExtendAmount() && !hasShiftExtendAmount()) if (!getShiftExtendAmount() && !hasShiftExtendAmount())
break; break;
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
case k_BTIHint:
OS << getBTIHintName();
break;
case k_ShiftExtend: case k_ShiftExtend:
OS << "<" << AArch64_AM::getShiftExtendName(getShiftExtendType()) << " #" OS << "<" << AArch64_AM::getShiftExtendName(getShiftExtendType()) << " #"
<< getShiftExtendAmount(); << getShiftExtendAmount();
if (!hasShiftExtendAmount()) if (!hasShiftExtendAmount())
OS << "<imp>"; OS << "<imp>";
OS << '>'; OS << '>';
break; break;
} }
▲ Show 20 Lines • Show All 3,705 Lines • Show Last 20 Lines