This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj/elf][test] - Add testing for EM_* specific OS/ABI values.
ClosedPublic

Authored by grimar on Aug 21 2020, 4:30 AM.

Details

Summary

We have no tests for OS/ABI values specific to
EM_TI_C6000, ELFOSABI_AMDGPU_MESA3D and ELFOSABI_ARM machines.

Also, related arrays in the code are not grouped together.
(I guess that is why such testing was missed initially).

The patch fixes that all.

Diff Detail

Event Timeline

grimar created this revision.Aug 21 2020, 4:30 AM
grimar requested review of this revision.Aug 21 2020, 4:30 AM
jhenderson accepted this revision.Aug 26 2020, 2:52 AM

LGTM.

llvm/tools/llvm-readobj/ELFDumper.cpp
1338–1341

I'd be inclined to move this further, e.g. to be near where they are used, or at least at the bottom of this block of EnumEntry arrays, since this is still sandwiched between different things that are ELF header specific.

This revision is now accepted and ready to land.Aug 26 2020, 2:52 AM