This is an archive of the discontinued LLVM Phabricator instance.

Differential D85940

Added std.floor operation to match std.ceil
ClosedPublic

Authored by rsuderman on Aug 13 2020, 3:01 PM.

Details

Reviewers
mravishankar
antiagainst
ftynse
herhut
rriddle
Commits
rG55565752306e: Added std.floor operation to match std.ceil
Summary

Added std.floor operation to match std.ceil

Diff Detail

Event Timeline

rsuderman created this revision.Aug 13 2020, 3:01 PM
Herald added a reviewer: mravishankar. · View Herald TranscriptAug 13 2020, 3:01 PM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: ThomasRaoux, AlexeySotkin, msifontes and 16 others. · View Herald Transcript
rsuderman requested review of this revision.Aug 13 2020, 3:01 PM
Herald added a reviewer: herhut. · View Herald TranscriptAug 13 2020, 3:01 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rsuderman retitled this revision from Added std.floor operation to make std.ceil to Added std.floor operation to match std.ceil.Aug 13 2020, 3:13 PM
rsuderman edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B68340: Diff 285505.Aug 13 2020, 3:31 PM
ftynse accepted this revision.Aug 14 2020, 2:29 AM
ftynse added inline comments.
mlir/test/IR/core-ops.mlir
557

Nit: let's just drop the regex on the LHS of = altogether. The fact that = is printed is sufficient to check that an op has a result

This revision is now accepted and ready to land.Aug 14 2020, 2:29 AM
rsuderman added a reviewer: rriddle.Aug 17 2020, 9:49 AM
rsuderman updated this revision to Diff 286060.Aug 17 2020, 10:10 AM

Sync to head.

Harbormaster completed remote builds in B68627: Diff 286060.Aug 17 2020, 10:48 AM
rsuderman updated this revision to Diff 286163.Aug 17 2020, 3:52 PM

Updated for nit comments.

Harbormaster completed remote builds in B68688: Diff 286163.Aug 17 2020, 3:52 PM
rsuderman updated this revision to Diff 286333.Aug 18 2020, 10:11 AM

Sync to head.

Harbormaster completed remote builds in B68770: Diff 286333.Aug 18 2020, 10:11 AM
This revision was landed with ongoing or failed builds.Aug 18 2020, 10:36 AM
Closed by commit rG55565752306e: Added std.floor operation to match std.ceil (authored by rsuderman). · Explain Why
This revision was automatically updated to reflect the committed changes.
rsuderman added a commit: rG55565752306e: Added std.floor operation to match std.ceil.

Revision Contents

PathSize
mlir/
test/
IR/
2 lines

Diff 286163

mlir/test/IR/core-ops.mlir

Show First 20 Lines • Show All 548 Lines • ▼ Show 20 Lines^bb42(%t: tensor<4x4x?xf32>, %f: f32, %i: i32, %idx : index, %j: i64, %half: f16):
%160 = fptosi %f : f32 to i64 %160 = fptosi %f : f32 to i64
// CHECK: = fptosi {{.*}} : f16 to i32 // CHECK: = fptosi {{.*}} : f16 to i32
%161 = fptosi %half : f16 to i32 %161 = fptosi %half : f16 to i32
// CHECK: = fptosi {{.*}} : f16 to i64 // CHECK: = fptosi {{.*}} : f16 to i64
%162 = fptosi %half : f16 to i64 %162 = fptosi %half : f16 to i64
// CHECK: %{{[0-9]+}} = floorf %arg1 : f32 // CHECK: floorf %arg1 : f32
ftynseUnsubmitted
Not Done
ReplyInline Actions

Nit: let's just drop the regex on the LHS of = altogether. The fact that = is printed is sufficient to check that an op has a result

ftynse: Nit: let's just drop the regex on the LHS of `=` altogether. The fact that `=` is printed is…
%163 = "std.floorf"(%f) : (f32) -> f32 %163 = "std.floorf"(%f) : (f32) -> f32
// CHECK: %{{[0-9]+}} = floorf %arg1 : f32 // CHECK: %{{[0-9]+}} = floorf %arg1 : f32
%164 = floorf %f : f32 %164 = floorf %f : f32
// CHECK: %{{[0-9]+}} = floorf %cst_8 : vector<4xf32> // CHECK: %{{[0-9]+}} = floorf %cst_8 : vector<4xf32>
%165 = floorf %vcf32 : vector<4xf32> %165 = floorf %vcf32 : vector<4xf32>
▲ Show 20 Lines • Show All 300 Lines • Show Last 20 Lines