Differential D85857

[NFC][MLIR][OpenMP] Add comments and test for OpenMP enum declaration utility
ClosedPublic
Actions

Authored by kiranchandramohan on Aug 12 2020, 3:07 PM.

Details

Reviewers

mehdi_amini
clementval
sscalpone
jdoerfert

Commits

rGfc544dcf2daa: [NFC][MLIR][OpenMP] Add comments and test for OpenMP enum declaration utility

Summary

Addresses @mehdi_amini's comments in D84347.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kiranchandramohan created this revision.Aug 12 2020, 3:07 PM

Herald added a reviewer: sscalpone. · View Herald TranscriptAug 12 2020, 3:07 PM

Herald added subscribers: msifontes, jurahul, Kayjukh and 13 others. · View Herald Transcript

kiranchandramohan requested review of this revision.Aug 12 2020, 3:07 PM

Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 12 2020, 3:07 PM

Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache. · View Herald Transcript

mehdi_amini accepted this revision.Aug 12 2020, 3:13 PM

This revision is now accepted and ready to land.Aug 12 2020, 3:13 PM

Closed by commit rGfc544dcf2daa: [NFC][MLIR][OpenMP] Add comments and test for OpenMP enum declaration utility (authored by kiranchandramohan). · Explain WhyAug 12 2020, 3:26 PM

This revision was automatically updated to reflect the committed changes.

kiranchandramohan added a commit: rGfc544dcf2daa: [NFC][MLIR][OpenMP] Add comments and test for OpenMP enum declaration utility.

Revision Contents
Changeset List

Path

Size

mlir/

test/

mlir-tblgen/

openmp-common.td

26 lines

tools/

mlir-tblgen/

OpenMPCommonGen.cpp

15 lines

Diff 285191

mlir/test/mlir-tblgen/openmp-common.td

Loading...

mlir/tools/mlir-tblgen/OpenMPCommonGen.cpp

Loading...