Paths

Table of Contentst

Differential D85780

[mlir][Linalg] Fix subview size used within Linalg Tiling pass.
AbandonedPublic
Actions

Authored by mravishankar on Aug 11 2020, 2:03 PM.

Details

Reviewers

nicolasvasilache
ThomasRaoux
bondhugula

Summary

The subview size for a tiled dimension is currently minimum of :

tile size
size of the base operand along that dimension - offset along that dimension. A third value is also to be considered :
size of the base operand along that dimension

The actual subview size should be a minum of all the three. Without this when size of the base operand along that dimension is smaller than the tile size used the subview size is unnecessarily large. This causes issues when using the size of the subview to allocate buffer used during promotion of subviews.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	280 ms	linux > MLIR.Dialect/Linalg::transform-patterns-matmul-to-vector.mlir Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/transform-patterns-matmul-to-vector.mlir -test-linalg-transform-patterns=test-matmul-to-vector-patterns-tile-1d \| /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/transform-patterns-matmul-to-vector.mlir
	220 ms	windows > MLIR.Dialect/Linalg::transform-patterns-matmul-to-vector.mlir Script: -- : 'RUN: at line 1'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\mlir-opt.exe C:\ws\w16c2-1\llvm-project\premerge-checks\mlir\test\Dialect\Linalg\transform-patterns-matmul-to-vector.mlir -test-linalg-transform-patterns=test-matmul-to-vector-patterns-tile-1d \| c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-1\llvm-project\premerge-checks\mlir\test\Dialect\Linalg\transform-patterns-matmul-to-vector.mlir

Event Timeline

mravishankar created this revision.Aug 11 2020, 2:03 PM

Herald added subscribers: msifontes, jurahul, Kayjukh and 12 others. · View Herald TranscriptAug 11 2020, 2:03 PM

mravishankar requested review of this revision.Aug 11 2020, 2:03 PM

Herald added subscribers: limo1996, stephenneuendorffer. · View Herald TranscriptAug 11 2020, 2:04 PM

Harbormaster completed remote builds in B68002: Diff 284887.Aug 11 2020, 3:41 PM

Updating the patch with some changes to make sure that the allocation size bound computation works with addition of the affine.min operation

Herald added a subscriber: mgorny. · View Herald TranscriptAug 13 2020, 11:44 AM

Harbormaster completed remote builds in B68302: Diff 285446.Aug 13 2020, 11:58 AM

asaadaldien added a reviewer: asaadaldien.Aug 17 2020, 4:02 PM

asaadaldien removed a reviewer: asaadaldien.Aug 17 2020, 4:11 PM

bondhugula added inline comments.Aug 18 2020, 5:39 AM

mlir/lib/Dialect/Affine/Utils/Utils.cpp
181	Missing doc comment.
182–186	You can just do `if (... = value.getDefiningOp<AffineMinOp>())`.

bondhugula resigned from this revision.Aug 19 2020, 3:45 PM

mravishankar abandoned this revision.Oct 12 2020, 10:11 PM

Herald added subscribers: rdzhabarov, tatianashp. · View Herald TranscriptOct 12 2020, 10:11 PM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

Affine/

8 lines

lib/

Dialect/

Affine/

Utils/

64 lines

Linalg/

Transforms/

1 line

13 lines

7 lines

test/

Dialect/

Linalg/

77 lines

14 lines

tile_conv_padding.mlir

8 lines

tile_simple_conv.mlir

61 lines

Diff 285446

mlir/include/mlir/Dialect/Affine/Utils.h

Loading...

mlir/lib/Dialect/Affine/Utils/Utils.cpp

Loading...

mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt

Loading...

mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp

Loading...

mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp

Loading...

mlir/test/Dialect/Linalg/tile.mlir

Loading...

mlir/test/Dialect/Linalg/tile_conv.mlir

Loading...

mlir/test/Dialect/Linalg/tile_conv_padding.mlir

Loading...

mlir/test/Dialect/Linalg/tile_simple_conv.mlir

Loading...