Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
We probably want a couple tests where the shift amount is constant, to show we can generate the shift-by-immediate forms.
LGTM assuming those tests do the right thing.
Comment Actions
I can confirm the shift-by-immediate cases don't result in optimal code generation. This is because the current AArch64lsl_p patterns are linked to the unpredicated instructions which explicitly check for an all 1s predicate. I'll fix this up under a separate patch because it might affect the scalable side, which is probably where it's best tested given the fixed length lowering doesn't care about immediates. This is why I'm keen for the fixed-length and scalable lowering to target the same nodes so that fixed-length does not introduce any new isel requirements.