This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Fix warnings in getCopyToPartsVector
ClosedPublic

Authored by david-arm on Jun 29 2020, 2:17 AM.

Details

Summary

Whilst trying to assemble the following test:

clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_set2.c

I discovered we were hitting some warnings about possible invalid
calls to getVectorNumElements() in getCopyToPartsVector(). I've
tried to fix these by using ElementCount types where possible and
I've made the assumption that we don't support using a fixed width
vector to copy parts of a scalable vector, and vice versa. Looking
at how the copy is implemented I think that's the right thing for
now.

Diff Detail

Event Timeline

david-arm created this revision.Jun 29 2020, 2:17 AM
efriedma accepted this revision.Jul 1 2020, 12:18 PM
efriedma added a subscriber: efriedma.

LGTM

This revision is now accepted and ready to land.Jul 1 2020, 12:18 PM
This revision was automatically updated to reflect the committed changes.