Page MenuHomePhabricator

MLIR][Shape] Add function signature conversion to `shape` to `scf` lowering.
AbandonedPublic

Authored by frgossen on Jun 25 2020, 1:57 AM.

Details

Reviewers
rriddle
pifon2a
Summary

The pass lowers fully to scf (and std where unavoidable).
It includes patterns from the shape to std lowering pass for testing
purposes.
This change prepares for the lowering of shape.shape_eq to scf.

Depends On D82528

Diff Detail

Event Timeline

frgossen created this revision.Jun 25 2020, 1:57 AM
Herald added a project: Restricted Project. · View Herald Transcript
frgossen updated this revision to Diff 273388.Jun 25 2020, 8:46 AM

Remove CHECK-DAGs

rriddle added inline comments.Jun 25 2020, 1:20 PM
mlir/lib/IR/Builders.cpp
169

This method doesn't look like it is used in this revision.

frgossen updated this revision to Diff 273657.Jun 26 2020, 4:06 AM
frgossen marked an inline comment as done.

Rebase

frgossen retitled this revision from [MLIR][Shape] Add function signature conversion to `scf` to `std` lowering. to MLIR][Shape] Add function signature conversion to `scf` to `std` lowering..Jun 29 2020, 7:01 AM
frgossen edited the summary of this revision. (Show Details)
frgossen retitled this revision from MLIR][Shape] Add function signature conversion to `scf` to `std` lowering. to MLIR][Shape] Add function signature conversion to `shape` to `scf` lowering..Jul 13 2020, 2:34 AM
frgossen abandoned this revision.Wed, Jul 29, 7:58 AM

No longer relevant for the new lowering strategy