Keep -fsanitize-coverage-{white,black}list as aliases for compatibility for now.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
You'll want to grab blacklist/whitelist in the comments around as well.
We've been talking about having a need for deprecated aliases file for these options - it's probably worth bringing this patch up on cfe-dev and cc'ing richardsmith explicitly. I think we can avoid compatibility aliases, but would like Richard to sign off.
clang/docs/ClangCommandLineReference.rst | ||
---|---|---|
313–316 | Miss merge? | |
887 | I'd remove the uses of blacklist and whitelist here and below. Just have the language and the documentation be for the new option. | |
clang/docs/SanitizerCoverage.rst | ||
435 | blacklist here. | |
clang/include/clang/Driver/Options.td | ||
1002–1005 | Deprecate the option and comment it as such. | |
compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_allowlist_blocklist.cpp | ||
2 | blacklist filename. probably want to change wl_* and bl_* below as well. |
clang/docs/ClangCommandLineReference.rst | ||
---|---|---|
887 | clang-tblgen -gen-opt-docs does not seem to provide a feature to hide an option. HelpHidden does not hide the option. | |
clang/docs/SanitizerCoverage.rst | ||
435 | sancov is another tool that is not touched by this patch. It should be updated separately. | |
clang/include/clang/Driver/Options.td | ||
1002–1005 | HelpHidden will hide the options from help. | |
compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_allowlist_blocklist.cpp | ||
2 | wl_ -> al_ bl_ can still mean blocklist. |
Couple of inline comments then looks good to go. Thank you so much for your effort here.
-eric
clang/docs/ClangCommandLineReference.rst | ||
---|---|---|
887 | Please remove blacklist and whitelist from the option description. | |
compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_allowlist_blocklist.cpp | ||
89 | Make a note that the options below ware deprecated and will be removed. |
clang/docs/ClangCommandLineReference.rst | ||
---|---|---|
887 | I can do that but the next person updating the documentation will add them back. I believe clang-tblgen -gen-opt-docs just doesn't have the feature. Maybe we can delete the old options earlier so that we don't need to worry about the documentation. |
clang/docs/ClangCommandLineReference.rst | ||
---|---|---|
887 | Ugh. Yes, I hope so too. Can you raise it on cfe-dev? |
clang/docs/ClangCommandLineReference.rst | ||
---|---|---|
887 | I can but I need to understand more about clang-tblgen -gen-opt-docs first... Very few people know how to regenerate the doc I think... |
Miss merge?