Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp | ||
---|---|---|
182–183 | These changes are covered by test Transforms/InstCombine/vscale_extractelement.ll, and isn't really a behavior change since it Min is used in exactly the same way as the numElements was before. The Min is not used for iteration, so this should be safe. | |
1993 | This behavioral change is covered by test Transforms/InstCombine/vscale_extractelement.ll. |
LGTM with one minor change.
llvm/include/llvm/Transforms/InstCombine/InstCombiner.h | ||
---|---|---|
338 ↗ | (On Diff #288668) | Change the initialization of InVTy? There's no reason to do the cast<> in two stages. |
clang-tidy: warning: 'auto ArgType' can be declared as 'auto *ArgType' [llvm-qualified-auto]
not useful