clang-tools-extra targets wont be generated without clang being enabled, so to help users know why their build commands are failing emit a warning from cmake.
Still unsure if the correct behaviour would be to do what flang does and automatically enable its dependency - mlir.
Details
Details
- Reviewers
klimek chandlerc DavidTruby
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I'd advocate for issuing a message (along the lines of "clang-tools-extra is enabled, which depends on 'clang'. Automatically enabling 'clang'." and 'doing the right thing' by enabling clang.
In fact, this seems to be a common enough paradigm that it should be handled in the cmake infrastructure.
Comment Actions
I agree that we might want to abstract this somewhere as I can imagine other subprojects wanting to do it as well. It would probably be nicer for the dependency to appear in the subproject CMakeLists but I'm not sure if that's possible.
Perhaps we should change the STATUS message to a WARNING for flang too, or at least keep both the same?